fix: fields with read access should not appear in the list filters since they are not searchable

packages/payload/src/fields/config/sanitize.ts

@@ -38,6 +38,14 @@ type Args = {
   config: Config
   existingFieldNames?: Set<string>
   fields: Field[]
+  /**
+   * Allows parent fields to disable the list filter for child fields.
+   * This is useful for fields that are not intended to be used in list filters,
+   * such as fields that have read access functions where all children fields should be omitted from the list filter.
+   *
+   * @default false
+   */
+  forceDisableListFilter?: boolean
   /**
    * Used to prevent unnecessary sanitization of fields that are not top-level.
    */
@@ -72,6 +80,7 @@ export const sanitizeFields = async ({
   config,
   existingFieldNames = new Set(),
   fields,
+  forceDisableListFilter: _forceDisableListFilter = false,
   isTopLevelField = true,
   joinPath = '',
   joins,
@@ -259,6 +268,14 @@ export const sanitizeFields = async ({
       field.admin = {}
     }
 
+    let forceDisableListFilter = _forceDisableListFilter
+    if (('access' in field && typeof field.access?.read === 'function') || forceDisableListFilter) {
+      if (fieldAffectsData) {
+        field.admin.disableListFilter = true
+      }
+      forceDisableListFilter = true
+    }
+
     // Make sure that the richText field has an editor
     if (field.type === 'richText') {
       const sanitizeRichText = async (_config: SanitizedConfig) => {
@@ -322,6 +339,7 @@ export const sanitizeFields = async ({
           config,
           existingFieldNames: new Set(),
           fields: block.fields,
+          forceDisableListFilter,
           isTopLevelField: false,
           parentIsLocalized: (parentIsLocalized || field.localized)!,
           requireFieldLevelRichTextEditor,
@@ -337,6 +355,7 @@ export const sanitizeFields = async ({
         config,
         existingFieldNames: fieldAffectsData ? new Set() : existingFieldNames,
         fields: field.fields,
+        forceDisableListFilter,
         isTopLevelField: isTopLevelField && !fieldAffectsData,
         joinPath: fieldAffectsData ? `${joinPath ? joinPath + '.' : ''}${field.name}` : joinPath,
         joins,
@@ -373,6 +392,7 @@ export const sanitizeFields = async ({
           config,
           existingFieldNames: isNamedTab ? new Set() : existingFieldNames,
           fields: tab.fields,
+          forceDisableListFilter,
           isTopLevelField: isTopLevelField && !isNamedTab,
           joinPath: isNamedTab ? `${joinPath ? joinPath + '.' : ''}${tab.name}` : joinPath,
           joins,

test/admin/collections/Posts.ts

@@ -293,6 +293,32 @@ export const Posts: CollectionConfig = {
       name: 'file',
       type: 'text',
     },
+    {
+      name: 'shouldDisableListFilter',
+      type: 'text',
+      admin: {
+        disableListFilter: false,
+      },
+      access: {
+        read: ({ req }) => Boolean(req.user),
+      },
+    },
+    {
+      name: 'groupWithReadAccessFunction',
+      type: 'group',
+      access: {
+        read: ({ req }) => Boolean(req.user),
+      },
+      fields: [
+        {
+          name: 'shouldDisableNestedListFilter',
+          type: 'text',
+          admin: {
+            disableListFilter: false,
+          },
+        },
+      ],
+    },
   ],
   labels: {
     plural: slugPluralLabel,

test/admin/e2e/list-view/e2e.spec.ts

@@ -749,6 +749,27 @@ describe('List View', () => {
       ).toBeHidden()
     })
 
+    test('should not show field filter for fields with read access functions', async () => {
+      await page.goto(postsUrl.list)
+      await openListFilters(page, {})
+      await page.locator('.where-builder__add-first-filter').click()
+
+      const initialField = page.locator('.condition__field')
+      await initialField.click()
+
+      await expect(
+        initialField.locator('.rs__option', {
+          hasText: 'Should Disable List Filter',
+        }),
+      ).toBeHidden()
+
+      await expect(
+        initialField.locator('.rs__option', {
+          hasText: 'Group With Read Access Function',
+        }),
+      ).toBeHidden()
+    })
+
     test('should simply disable field filter when admin.disableListFilter is true but still exists in the query', async () => {
       await page.goto(
         `${postsUrl.list}${qs.stringify(