tabshift/payloadcms
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(richtext-slate, ui): use PointerEvents to show tooltips on enabled / disabled buttons (#9006)

Browse Source 
Fixes #9005

Note: I did not replace all instances of `onMouseEnter`, just the ones
that can be disabled and have `tooltip` set.
This commit is contained in:
Timothy Choi
2024-11-06 18:43:06 +01:00
committed by GitHub
parent 4b4ecb386d
commit d42529055a
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/richtext-slate/src/field/elements/Button.tsx
View File

@@ -54,8 +54,8 @@ export const ElementButton: React.FC<ButtonProps> = (props) => {
.filter(Boolean) .filter(Boolean)
.join(' ')} .join(' ')}
onClick={onClick || defaultOnClick} onClick={onClick || defaultOnClick}
onMouseEnter={() => setShowTooltip(true)} onPointerEnter={() => setShowTooltip(true)}
onMouseLeave={() => setShowTooltip(false)} onPointerLeave={() => setShowTooltip(false)}
> >
{tooltip && <Tooltip show={showTooltip}>{tooltip}</Tooltip>} {tooltip && <Tooltip show={showTooltip}>{tooltip}</Tooltip>}
{children} {children}

4
packages/ui/src/elements/Button/index.tsx
View File

@@ -114,8 +114,8 @@ export const Button = forwardRef<HTMLAnchorElement | HTMLButtonElement, Props>((
className: !SubMenuPopupContent ? [classes, styleClasses].join(' ') : classes, className: !SubMenuPopupContent ? [classes, styleClasses].join(' ') : classes,
disabled, disabled,
onClick: !disabled ? handleClick : undefined, onClick: !disabled ? handleClick : undefined,
onMouseEnter: tooltip ? () => setShowTooltip(true) : undefined, onPointerEnter: tooltip ? () => setShowTooltip(true) : undefined,
onMouseLeave: tooltip ? () => setShowTooltip(false) : undefined, onPointerLeave: tooltip ? () => setShowTooltip(false) : undefined,
rel: newTab ? 'noopener noreferrer' : undefined, rel: newTab ? 'noopener noreferrer' : undefined,
target: newTab ? '_blank' : undefined, target: newTab ? '_blank' : undefined,
} }