From d42529055a3644b26840e3b276a516a666d6e6fd Mon Sep 17 00:00:00 2001 From: Timothy Choi Date: Wed, 6 Nov 2024 18:43:06 +0100 Subject: [PATCH] fix(richtext-slate, ui): use `PointerEvents` to show tooltips on enabled / disabled buttons (#9006) Fixes #9005 Note: I did not replace all instances of `onMouseEnter`, just the ones that can be disabled and have `tooltip` set. --- packages/richtext-slate/src/field/elements/Button.tsx | 4 ++-- packages/ui/src/elements/Button/index.tsx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/richtext-slate/src/field/elements/Button.tsx b/packages/richtext-slate/src/field/elements/Button.tsx index cb931302b..2245df295 100644 --- a/packages/richtext-slate/src/field/elements/Button.tsx +++ b/packages/richtext-slate/src/field/elements/Button.tsx @@ -54,8 +54,8 @@ export const ElementButton: React.FC = (props) => { .filter(Boolean) .join(' ')} onClick={onClick || defaultOnClick} - onMouseEnter={() => setShowTooltip(true)} - onMouseLeave={() => setShowTooltip(false)} + onPointerEnter={() => setShowTooltip(true)} + onPointerLeave={() => setShowTooltip(false)} > {tooltip && {tooltip}} {children} diff --git a/packages/ui/src/elements/Button/index.tsx b/packages/ui/src/elements/Button/index.tsx index 1cd4364d2..de920e67d 100644 --- a/packages/ui/src/elements/Button/index.tsx +++ b/packages/ui/src/elements/Button/index.tsx @@ -114,8 +114,8 @@ export const Button = forwardRef(( className: !SubMenuPopupContent ? [classes, styleClasses].join(' ') : classes, disabled, onClick: !disabled ? handleClick : undefined, - onMouseEnter: tooltip ? () => setShowTooltip(true) : undefined, - onMouseLeave: tooltip ? () => setShowTooltip(false) : undefined, + onPointerEnter: tooltip ? () => setShowTooltip(true) : undefined, + onPointerLeave: tooltip ? () => setShowTooltip(false) : undefined, rel: newTab ? 'noopener noreferrer' : undefined, target: newTab ? '_blank' : undefined, }