tabshift/pocketbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

removed unnecessery error return

Browse Source
This commit is contained in:
Gani Georgiev
2026-04-02 21:00:16 +03:00
parent e49b64b114
commit e9118fa6b6
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
apis/record_auth_with_oauth2.go
View File

@@ -418,7 +418,7 @@ func sendOAuth2RecordCreateRequest(txApp core.App, e *core.RecordAuthWithOAuth2R
// so if you plan using with untrusted user URL, consider performing additional whitelist checks. // so if you plan using with untrusted user URL, consider performing additional whitelist checks.
// //
// @todo Evaluate with the refactoring if worth exporting(+tests) and moving under the security package. // @todo Evaluate with the refactoring if worth exporting(+tests) and moving under the security package.
func safeHTTPClient() (*http.Client, error) { func safeHTTPClient() *http.Client {
dialer := &net.Dialer{ dialer := &net.Dialer{
// the same options as in http.DefaultTransport.DialContext // the same options as in http.DefaultTransport.DialContext
Timeout: 30 * time.Second, Timeout: 30 * time.Second,
@@ -447,7 +447,7 @@ func safeHTTPClient() (*http.Client, error) {
}, },
} }
client := &http.Client{ return &http.Client{
Timeout: 180 * time.Second, // can be still cancelled with the request context Timeout: 180 * time.Second, // can be still cancelled with the request context
Transport: &http.Transport{ Transport: &http.Transport{
DialContext: dialer.DialContext, DialContext: dialer.DialContext,
@@ -459,8 +459,6 @@ func safeHTTPClient() (*http.Client, error) {
ExpectContinueTimeout: 1 * time.Second, ExpectContinueTimeout: 1 * time.Second,
}, },
} }
return client, nil
} }
// safeFileFromURL downloads the file from the specified url (using safeHTTPClient) // safeFileFromURL downloads the file from the specified url (using safeHTTPClient)
@@ -473,10 +471,7 @@ func safeFileFromURL(ctx context.Context, url string) (*filesystem.File, error)
return nil, err return nil, err
} }
client, err := safeHTTPClient() client := safeHTTPClient()
if err != nil {
return nil, err
}
res, err := client.Do(req) res, err := client.Do(req)
if err != nil { if err != nil {