[#114] simplified some code by returning early and added cap for slices

2022-07-15 00:26:08 +08:00
parent 03a7bafa66
commit a16b0c9004
11 changed files with 124 additions and 147 deletions
--- a/forms/validators/record_data.go
+++ b/forms/validators/record_data.go
@@ -318,12 +318,10 @@ func (validator *RecordDataValidator) checkFileValue(field *schema.SchemaField,
 	}

 	// extract the uploaded files
-	files := []*rest.UploadedFile{}
-	if len(validator.uploadedFiles) > 0 {
-		for _, file := range validator.uploadedFiles {
-			if list.ExistInSlice(file.Name(), names) {
-				files = append(files, file)
-			}
+	files := make([]*rest.UploadedFile, 0, len(validator.uploadedFiles))
+	for _, file := range validator.uploadedFiles {
+		if list.ExistInSlice(file.Name(), names) {
+			files = append(files, file)
 		}
 	}