restructered some of the internals and added basic js app hooks support

plugins/jsvm/migrations.go

@@ -2,10 +2,9 @@ package jsvm
 
 import (
 	"fmt"
-	"os"
 	"path/filepath"
-	"strings"
 
+	"github.com/dop251/goja"
 	"github.com/dop251/goja_nodejs/console"
 	"github.com/dop251/goja_nodejs/process"
 	"github.com/dop251/goja_nodejs/require"
@@ -14,52 +13,36 @@ import (
 	m "github.com/pocketbase/pocketbase/migrations"
 )
 
-// MigrationsOptions defines optional struct to customize the default migrations loader behavior.
-type MigrationsOptions struct {
+// MigrationsConfig defines the config options of the JS migrations loader plugin.
+type MigrationsConfig struct {
 	// Dir specifies the directory with the JS migrations.
 	//
 	// If not set it fallbacks to a relative "pb_data/../pb_migrations" directory.
 	Dir string
 }
 
-// migrations is the migrations loader plugin definition.
-// Usually it is instantiated via RegisterMigrations or MustRegisterMigrations.
-type migrations struct {
-	app     core.App
-	options *MigrationsOptions
-}
-
-// MustRegisterMigrations registers the migrations loader plugin to
+// MustRegisterMigrations registers the JS migrations loader plugin to
 // the provided app instance and panics if it fails.
 //
-// Internally it calls RegisterMigrations(app, options).
+// Example usage:
 //
-// If options is nil, by default the js files from pb_data/migrations are loaded.
-// Set custom options.Dir if you want to change it to some other directory.
-func MustRegisterMigrations(app core.App, options *MigrationsOptions) {
-	if err := RegisterMigrations(app, options); err != nil {
+//	jsvm.MustRegisterMigrations(app, jsvm.MigrationsConfig{})
+func MustRegisterMigrations(app core.App, config MigrationsConfig) {
+	if err := RegisterMigrations(app, config); err != nil {
 		panic(err)
 	}
 }
 
-// RegisterMigrations registers the plugin to the provided app instance.
-//
-// If options is nil, by default the js files from pb_data/migrations are loaded.
-// Set custom options.Dir if you want to change it to some other directory.
-func RegisterMigrations(app core.App, options *MigrationsOptions) error {
-	l := &migrations{app: app}
+// RegisterMigrations registers the JS migrations loader hooks plugin
+// to the provided app instance.
+func RegisterMigrations(app core.App, config MigrationsConfig) error {
+	l := &migrations{app: app, config: config}
 
-	if options != nil {
-		l.options = options
-	} else {
-		l.options = &MigrationsOptions{}
+	if l.config.Dir == "" {
+		l.config.Dir = filepath.Join(app.DataDir(), "../pb_migrations")
 	}
 
-	if l.options.Dir == "" {
-		l.options.Dir = filepath.Join(app.DataDir(), "../pb_migrations")
-	}
-
-	files, err := readDirFiles(l.options.Dir)
+	files, err := filesContent(l.config.Dir, `^.*\.js$`)
 	if err != nil {
 		return err
 	}
@@ -67,10 +50,13 @@ func RegisterMigrations(app core.App, options *MigrationsOptions) error {
 	registry := new(require.Registry) // this can be shared by multiple runtimes
 
 	for file, content := range files {
-		vm := NewBaseVM()
+		vm := goja.New()
 		registry.Enable(vm)
 		console.Enable(vm)
 		process.Enable(vm)
+		dbxBinds(vm)
+		tokensBinds(vm)
+		securityBinds(vm)
 
 		vm.Set("migrate", func(up, down func(db dbx.Builder) error) {
 			m.AppMigrations.Register(up, down, file)
@@ -85,30 +71,7 @@ func RegisterMigrations(app core.App, options *MigrationsOptions) error {
 	return nil
 }
 
-// readDirFiles returns a map with all directory files and their content.
-//
-// If directory with dirPath is missing, it returns an empty map and no error.
-func readDirFiles(dirPath string) (map[string][]byte, error) {
-	files, err := os.ReadDir(dirPath)
-	if err != nil {
-		if os.IsNotExist(err) {
-			return map[string][]byte{}, nil
-		}
-		return nil, err
-	}
-
-	result := map[string][]byte{}
-
-	for _, f := range files {
-		if f.IsDir() || !strings.HasSuffix(f.Name(), ".js") {
-			continue // not a .js file
-		}
-		raw, err := os.ReadFile(filepath.Join(dirPath, f.Name()))
-		if err != nil {
-			return nil, err
-		}
-		result[f.Name()] = raw
-	}
-
-	return result, nil
+type migrations struct {
+	app    core.App
+	config MigrationsConfig
 }