fixed arg validation
This commit is contained in:
@@ -53,7 +53,7 @@ func newExcerptModifier(args ...string) (*excerptModifier, error) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
max := cast.ToInt(args[0])
|
max := cast.ToInt(args[0])
|
||||||
if max == 0 {
|
if max <= 0 {
|
||||||
return nil, errors.New("max argument must be > 0")
|
return nil, errors.New("max argument must be > 0")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -28,6 +28,16 @@ func TestNewExcerptModifier(t *testing.T) {
|
|||||||
[]string{"something"}, // should fallback to 0 which is not allowed
|
[]string{"something"}, // should fallback to 0 which is not allowed
|
||||||
true,
|
true,
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
"negative max argument",
|
||||||
|
[]string{"-1"},
|
||||||
|
true,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"zero max argument",
|
||||||
|
[]string{"0"},
|
||||||
|
true,
|
||||||
|
},
|
||||||
{
|
{
|
||||||
"numeric max argument",
|
"numeric max argument",
|
||||||
[]string{"12"},
|
[]string{"12"},
|
||||||
|
|||||||
Reference in New Issue
Block a user