61ee8fadca
Fixes #12975. When editing autosave-enabled documents through the join field, the document drawer closes unexpectedly on every autosave interval, making it nearly impossible to use. This is because as of #12842, the underlying relationship table re-renders on every autosave event, remounting the drawer each time. The fix is to lift the drawer out of table's rendering tree and into the join field itself. This way all rows share the same drawer, whose rendering lifecycle has been completely decoupled from the table's state. Note: this is very similar to how relationship fields achieve similar functionality. This PR also adds jsdocs to the `useDocumentDrawer` hook and strengthens its types. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1210906078627353
36 lines
972 B
TypeScript
36 lines
972 B
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
|
|
import { expect } from '@playwright/test'
|
|
import { wait } from 'payload/shared'
|
|
import { POLL_TOPASS_TIMEOUT } from 'playwright.config.js'
|
|
|
|
export async function waitForAutoSaveToRunAndComplete(
|
|
page: Locator | Page,
|
|
expectation: 'error' | 'success' = 'success',
|
|
) {
|
|
await expect(async () => {
|
|
await expect(page.locator('.autosave:has-text("Saving...")')).toBeVisible()
|
|
}).toPass({
|
|
timeout: POLL_TOPASS_TIMEOUT,
|
|
intervals: [50],
|
|
})
|
|
|
|
await wait(500)
|
|
|
|
if (expectation === 'success') {
|
|
await expect(async () => {
|
|
await expect(
|
|
page.locator('.autosave:has-text("Last saved less than a minute ago")'),
|
|
).toBeVisible()
|
|
}).toPass({
|
|
timeout: POLL_TOPASS_TIMEOUT,
|
|
})
|
|
} else {
|
|
await expect(async () => {
|
|
await expect(page.locator('.payload-toast-container .toast-error')).toBeVisible()
|
|
}).toPass({
|
|
timeout: POLL_TOPASS_TIMEOUT,
|
|
})
|
|
}
|
|
}
|