94f5e790f6
Currently, an optimized DB update (simple data => no delete-and-create-row) does the following: 1. sql UPDATE 2. sql SELECT This PR reduces this further to one single DB call for simple collections: 1. sql UPDATE with RETURNING() This only works for simple collections that do not have any fields that need to be fetched from other tables. If a collection has fields like relationship or blocks, we'll need that separate SELECT call to join in the other tables. In 4.0, we can remove all "complex" fields from the jobs collection and replace them with a JSON field to make use of this optimization --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1210803039809814
92 lines
2.5 KiB
TypeScript
92 lines
2.5 KiB
TypeScript
import type { Payload } from 'payload'
|
|
|
|
/* eslint-disable jest/require-top-level-describe */
|
|
import assert from 'assert'
|
|
import path from 'path'
|
|
import { fileURLToPath } from 'url'
|
|
|
|
import { initPayloadInt } from '../helpers/initPayloadInt.js'
|
|
|
|
const filename = fileURLToPath(import.meta.url)
|
|
const dirname = path.dirname(filename)
|
|
|
|
const describePostgres = process.env.PAYLOAD_DATABASE?.startsWith('postgres')
|
|
? describe
|
|
: describe.skip
|
|
|
|
let payload: Payload
|
|
|
|
describePostgres('database - postgres logs', () => {
|
|
beforeAll(async () => {
|
|
const initialized = await initPayloadInt(
|
|
dirname,
|
|
undefined,
|
|
undefined,
|
|
'config.postgreslogs.ts',
|
|
)
|
|
assert(initialized.payload)
|
|
assert(initialized.restClient)
|
|
;({ payload } = initialized)
|
|
})
|
|
|
|
afterAll(async () => {
|
|
await payload.destroy()
|
|
})
|
|
|
|
it('ensure simple update uses optimized upsertRow with returning()', async () => {
|
|
const doc = await payload.create({
|
|
collection: 'simple',
|
|
data: {
|
|
text: 'Some title',
|
|
number: 5,
|
|
},
|
|
})
|
|
|
|
// Count every console log
|
|
const consoleCount = jest.spyOn(console, 'log').mockImplementation(() => {})
|
|
|
|
const result: any = await payload.db.updateOne({
|
|
collection: 'simple',
|
|
id: doc.id,
|
|
data: {
|
|
text: 'Updated Title',
|
|
number: 5,
|
|
},
|
|
})
|
|
|
|
expect(result.text).toEqual('Updated Title')
|
|
expect(result.number).toEqual(5) // Ensure the update did not reset the number field
|
|
|
|
expect(consoleCount).toHaveBeenCalledTimes(1) // Should be 1 single sql call if the optimization is used. If not, this would be 2 calls
|
|
consoleCount.mockRestore()
|
|
})
|
|
|
|
it('ensure simple update of complex collection uses optimized upsertRow without returning()', async () => {
|
|
const doc = await payload.create({
|
|
collection: 'posts',
|
|
data: {
|
|
title: 'Some title',
|
|
number: 5,
|
|
},
|
|
})
|
|
|
|
// Count every console log
|
|
const consoleCount = jest.spyOn(console, 'log').mockImplementation(() => {})
|
|
|
|
const result: any = await payload.db.updateOne({
|
|
collection: 'posts',
|
|
id: doc.id,
|
|
data: {
|
|
title: 'Updated Title',
|
|
number: 5,
|
|
},
|
|
})
|
|
|
|
expect(result.title).toEqual('Updated Title')
|
|
expect(result.number).toEqual(5) // Ensure the update did not reset the number field
|
|
|
|
expect(consoleCount).toHaveBeenCalledTimes(2) // Should be 2 sql call if the optimization is used (update + find). If not, this would be 5 calls
|
|
consoleCount.mockRestore()
|
|
})
|
|
})
|