tabshift/payloadcms
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
Files
605c993bb70d5171e2a7d0c322e470656863ea89
payloadcms/test
History
Said Akhrarov 605c993bb7 fix(drizzle): skip column if undefined in findMany (#12902) 
<!--

Thank you for the PR! Please go through the checklist below and make
sure you've completed all the steps.

Please review the
[CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md)
document in this repository if you haven't already.

The following items will ensure that your PR is handled as smoothly as
possible:

- PR Title must follow conventional commits format. For example, `feat:
my new feature`, `fix(plugin-seo): my fix`.
- Minimal description explained as if explained to someone not
immediately familiar with the code.
- Provide before/after screenshots or code diffs if applicable.
- Link any related issues/discussions from GitHub or Discord.
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Fixes #

-->
### What?
This PR fixes an issue where sorting on a traditional virtual field with
`virtual: true` while using a drizzle-based db adapter would cause a
runtime error.

### Why?
To skip attempting to sort virtual fields which are not linked to a
relationship/upload and prevent a runtime error from surfacing.

### How?
Skipping the deletion of the property from the `selectFields` object if
the column is false-y.

Fixes #12886

Before:


[sort-virtualfield-drizzle-error.mp4](https://private-user-images.githubusercontent.com/78685728/457602747-b8661e47-a1a8-4453-b2ec-b7e7199b9846.mp4?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTA2OTU0NzksIm5iZiI6MTc1MDY5NTE3OSwicGF0aCI6Ii83ODY4NTcyOC80NTc2MDI3NDctYjg2NjFlNDctYTFhOC00NDUzLWIyZWMtYjdlNzE5OWI5ODQ2Lm1wND9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjIzVDE2MTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE3NmMzOWI5YjNiNzEwYzk3ZWUyNDllYTBjMzZkNzkzMjhjNzc5YzJhNDlkOTBiNDk5MDFhMTdmNDA4NjJhZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.N1GJsiI_gZ8M54VHCAmiPEhcJGqRw3Ucy-VeM5R7UFE)

After: 


[virtualfields-sort-Posts---Payload.webm](https://github.com/user-attachments/assets/f5a15d98-4a40-4817-bc6a-415f3ec27484)

<details>

<summary>Collection config used above</summary>

```ts
export const PostsCollection: CollectionConfig = {
  slug: postsSlug,
  admin: {
    useAsTitle: 'title',
    defaultColumns: ['title', 'exampleField'],
  },
  fields: [
    {
      name: 'title',
      type: 'text',
    },
    {
      name: 'exampleField',
      type: 'text',
      virtual: true,
      admin: {
        readOnly: true,
      },
      hooks: {
        afterRead: [({ data }) => data?.title],
      },
    },
    {
      type: 'relationship',
      name: 'category',
      relationTo: 'categories',
    },
    {
      name: 'categoryTitle',
      type: 'text',
      virtual: 'category.title',
    },
  ],
}
```

</details>

---------

Co-authored-by: Sasha <64744993+r1tsuu@users.noreply.github.com>
2025-06-26 19:52:29 +00:00
..
_community
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
access-control
fix(ui): updates auth fields UI to reflect access control (#12745)
2025-06-25 14:55:07 +01:00
admin
feat: collection-level disableBulkEdit (#12850)
2025-06-19 09:18:29 +00:00
admin-bar
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
admin-root
fix(ui): unreachable custom views when admin route set to '/' (#12812)
2025-06-26 09:34:08 -04:00
app
feat: deprecates getPayloadHMR in favor of simpler getPayload (#9249)
2024-11-16 15:30:05 -05:00
array-update
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
auth
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
auth-basic
chore: run dev:generate-types (#11994)
2025-04-08 17:25:29 -03:00
benchmark-blocks
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
bulk-edit
fix(ui): toggle list selections off on successful bulk action (#12861)
2025-06-25 17:06:44 -04:00
collections-graphql
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
collections-rest
feat: collection-level disableBulkEdit (#12850)
2025-06-19 09:18:29 +00:00
config
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
create-payload-app
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
custom-graphql
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
database
fix(drizzle): skip column if undefined in findMany (#12902)
2025-06-26 19:52:29 +00:00
dataloader
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
email
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
email-nodemailer
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
email-resend
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
endpoints
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
field-error-states
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
field-perf
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
fields
fix(ui): custom row labels on arrays should not be removed on field duplication (#12895)
2025-06-25 09:44:00 -04:00
fields-relationship
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
folders
feat(ui): moves folder rendering from the client to the server (#12710)
2025-06-10 11:56:28 -04:00
folders-browse-by-disabled
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
form-state
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
globals
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
graphql
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
graphql-schema-gen
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
helpers
chore: fix jest global teardown incorrectly always returning process exit status 0 (#12907)
2025-06-25 17:43:57 -07:00
hooks
feat: expose data argument in afterChange hook for collections and globals (#12756)
2025-06-11 06:23:22 -07:00
i18n
fix(translations): improve Spanish translations (#12555)
2025-05-28 16:50:47 -03:00
import-test
feat: adds jobs queue (#8228)
2024-10-30 17:56:50 +00:00
joins
feat(next): version view overhaul (#12027)
2025-06-16 07:58:03 -04:00
lexical
fix(richtext-lexical): consistent html converter inline padding (#12848)
2025-06-18 21:43:42 -07:00
lexical-mdx
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
live-preview
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
loader
feat!: beta-next (#7620)
2024-08-13 12:54:33 -04:00
localization
fix(db-postgres): reordering of enum values, bump drizzle-kit@0.31.0 and drizzle-orm@0.43.1 (#12256)
2025-06-16 16:03:18 -04:00
localization-rtl
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
locked-documents
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
login-with-username
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
migrations-cli
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
nested-fields
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
payload-cloud
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-cloud-storage
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-form-builder
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-import-export
fix(plugin-import-export): duplicated rows and headers in CSV export when streaming paginated results (#12941)
2025-06-26 06:09:17 -07:00
plugin-multi-tenant
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-nested-docs
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-redirects
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-search
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-sentry
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-seo
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugin-stripe
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
plugins
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
query-presets
feat(next): version view overhaul (#12027)
2025-06-16 07:58:03 -04:00
queues
refactor: simplify job queue error handling (#12845)
2025-06-17 22:24:53 +00:00
relationships
fix(db-postgres): querying on hasMany: true select field in a relationship (#12916)
2025-06-24 21:25:48 +03:00
scripts
feat(next): root admin (#7276)
2024-07-23 13:44:44 -04:00
select
docs: improve jobs autorun docs, adds e2e test (#12196)
2025-06-05 09:19:19 -07:00
server-functions
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
sort
fix: uses valid fractional index for test (#12942)
2025-06-26 06:40:18 -04:00
storage-azure
fix(storage-azure): return error status 404 when file is not found instead of 500 (#11734)
2025-06-11 07:49:34 -07:00
storage-gcs
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
storage-s3
fix(storage-s3): return error status 404 when file is not found instead of 500 (#11733)
2025-06-11 12:04:25 +00:00
storage-uploadthing
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
storage-vercel-blob
chore: fix all lint errors and add mechanisms to prevent them from appearing again (#12401)
2025-05-19 12:36:40 -03:00
types
fix: remove unsupported path property from default document view configs (#12774)
2025-06-12 09:01:20 -04:00
uploads
fix: get external resource blocked (#12927)
2025-06-26 15:24:39 -04:00
versions
fix(next): prevent errors in globals version view (#12920)
2025-06-24 13:18:25 -04:00
.prettierignore
chore: regenerate all types in test dir, and add to eslint & prettier ignores
2024-07-11 15:59:38 -04:00
.swcrc
chore: swcrc syntax fix (#6505)
2024-05-25 15:45:05 +00:00
buildConfigWithDefaults.ts
chore: fix various e2e test setup issues (#12670)
2025-06-04 17:34:37 -03:00
credentials.ts
chore: hoists tests out of payload package
2023-09-01 14:45:41 -04:00
CustomDashboard.tsx
chore: safely uses deepMerge
2024-03-07 11:33:46 -05:00
dev.ts
chore: enable turbopack by default in monorepo (#12684)
2025-06-05 22:01:55 -03:00
docker-compose.yml
fix(plugin-cloud-storage): actually deprecate adapters (#9640)
2024-12-31 09:14:56 -05:00
eslint.config.js
chore: add eslint rule to ignore default exports in test suite configs (#12655)
2025-06-17 09:10:42 -04:00
generateDatabaseAdapter.ts
feat(db-postgres): support read replicas (#12728)
2025-06-09 19:09:52 +00:00
generateDatabaseSchema.ts
feat(db-postgres, db-sqlite): drizzle schema generation (#9953)
2024-12-19 11:08:17 -05:00
generateGraphQLSchema.ts
feat!: beta-next (#7620)
2024-08-13 12:54:33 -04:00
generateImportMap.ts
feat: payload admin bar (#3684)
2025-03-05 19:14:35 +00:00
generateTypes.ts
chore: gitignore test/databaseAdapter (#8235)
2024-09-16 17:02:08 +00:00
helpers.ts
feat: show fields inside groups as separate columns in the list view (#7355)
2025-05-21 16:25:34 -04:00
initDevAndTest.ts
chore: gitignore test/databaseAdapter (#8235)
2024-09-16 17:02:08 +00:00
jest-spec-reporter.cjs
feat!: on demand rsc (#8364)
2024-11-11 13:59:05 -05:00
jest.config.js
chore: use custom jest reporter to achieve sane jest logs (#8607)
2024-10-11 18:54:39 +00:00
jest.setup.js
fix: localized fields within block references were not handled properly if any parent is localized (#11207)
2025-02-17 19:50:32 +00:00
jestreporter.cjs
chore: use custom jest reporter to achieve sane jest logs (#8607)
2024-10-11 18:54:39 +00:00
next-env.d.ts
build: fix tsconfig monorepo setup (#10028)
2024-12-17 14:49:29 -05:00
next.config.mjs
perf: 50% faster compilation speed by skipping bundling of server-only packages during dev (#11594)
2025-03-11 09:45:13 -06:00
package.json
ci: revert bump pnpm to v10 (#12840) (#12906)
2025-06-23 15:10:51 -04:00
playwright.bail.config.ts
chore: hide test flakes, improve playwright CI logs, significantly reduce playwright timeouts, add back test retries, cache playwright browsers in CI, disable CI telemetry, improve test throttle utility (#6155)
2024-05-01 17:35:41 -04:00
playwright.config.ts
chore: fix flaky lexical test (#11035)
2025-02-07 03:24:49 +00:00
runE2E.ts
chore: enable turbopack by default in monorepo (#12684)
2025-06-05 22:01:55 -03:00
runInit.ts
chore: upgrade to pnpm v9, regenerate lockfile (#7369)
2024-08-14 08:57:04 -04:00
runInitSeparateProcess.ts
chore: upgrade to pnpm v9, regenerate lockfile (#7369)
2024-08-14 08:57:04 -04:00
safelyRunScript.ts
chore: when dev server restarts, ensure exiting the parent process kills child process (#8703)
2024-10-14 20:02:26 +00:00
setupProd.ts
feat: payload admin bar (#3684)
2025-03-05 19:14:35 +00:00
test.env
chore: bump node version in monorepo and add new flag for node 23.6+ (#12328)
2025-05-12 09:41:18 -04:00
testEmailAdapter.ts
feat!: prebundle payload, ui, richtext-lexical (#6579)
2024-06-17 14:25:36 -04:00
testHooks.ts
perf: deduplicate blocks used in multiple places using new config.blocks property (#10905)
2025-02-14 00:08:20 +00:00
tsconfig.eslint.json
chore: run lint & prettier on everything
2024-03-14 23:53:47 -04:00
tsconfig.json
chore: make TypeScript strict in test folder. Simplify tsconfig (#10582)
2025-01-14 20:00:00 -03:00
tsconfig.typecheck.json
feat: payload admin bar (#3684)
2025-03-05 19:14:35 +00:00