tabshift/payloadcms
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(ui): saving empty code editor throw error (#14019)

Browse Source 
Fixes https://github.com/payloadcms/payload/issues/14006

When attempting to save an empty code editor an error would throw
because `value` was undefined.
This commit is contained in:
Jarrod Flesch
2025-10-02 17:31:45 -04:00
committed by GitHub
parent ece5a95f64
commit bffb9ef8b9
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/ui/src/elements/CodeEditor/CodeEditor.tsx
View File

@@ -47,7 +47,11 @@ const CodeEditor: React.FC<Props> = (props) => {
React.useEffect(() => { React.useEffect(() => {
if (recalculatedHeightAt && recalculatedHeightAt > prevCalculatedHeightAt.current) { if (recalculatedHeightAt && recalculatedHeightAt > prevCalculatedHeightAt.current) {
setDynamicHeight(Math.max(MIN_HEIGHT, value.split('\n').length * 18 + 2 + paddingFromProps)) setDynamicHeight(
value
? Math.max(MIN_HEIGHT, value.split('\n').length * 18 + 2 + paddingFromProps)
: MIN_HEIGHT,
)
prevCalculatedHeightAt.current = recalculatedHeightAt prevCalculatedHeightAt.current = recalculatedHeightAt
} }
}, [value, MIN_HEIGHT, paddingFromProps, recalculatedHeightAt]) }, [value, MIN_HEIGHT, paddingFromProps, recalculatedHeightAt])
@@ -81,7 +85,11 @@ const CodeEditor: React.FC<Props> = (props) => {
height={maxHeight ? Math.min(dynamicHeight, maxHeight) : dynamicHeight} height={maxHeight ? Math.min(dynamicHeight, maxHeight) : dynamicHeight}
onChange={(value, ev) => { onChange={(value, ev) => {
rest.onChange?.(value, ev) rest.onChange?.(value, ev)
setDynamicHeight(Math.max(MIN_HEIGHT, value.split('\n').length * 18 + 2 + paddingFromProps)) setDynamicHeight(
value
? Math.max(MIN_HEIGHT, value.split('\n').length * 18 + 2 + paddingFromProps)
: MIN_HEIGHT,
)
}} }}
onMount={(editor, monaco) => { onMount={(editor, monaco) => {
rest.onMount?.(editor, monaco) rest.onMount?.(editor, monaco)