From 9c2585ba86c94361528ab259db26677bf8e605a1 Mon Sep 17 00:00:00 2001 From: Elliot DeNolf Date: Sun, 28 Apr 2024 14:49:48 -0400 Subject: [PATCH] chore(eslint): no-relative-monorepo-imports on package dir, other cleanup --- .eslintrc.cjs | 1 + .../customRules/no-jsx-import-statements.js | 4 ++++ .../customRules/no-relative-monorepo-imports.js | 6 ++++++ test/.eslintrc.cjs | 3 --- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.eslintrc.cjs b/.eslintrc.cjs index 04919a5a1..f28ba3d8d 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -8,6 +8,7 @@ module.exports = { plugins: ['payload'], rules: { 'payload/no-jsx-import-statements': 'warn', + 'payload/no-relative-monorepo-imports': 'error', }, }, { diff --git a/packages/eslint-plugin-payload/customRules/no-jsx-import-statements.js b/packages/eslint-plugin-payload/customRules/no-jsx-import-statements.js index c24f4c6cf..a8d43a679 100644 --- a/packages/eslint-plugin-payload/customRules/no-jsx-import-statements.js +++ b/packages/eslint-plugin-payload/customRules/no-jsx-import-statements.js @@ -1,3 +1,7 @@ +/** + * Disallows imports from .jsx extensions. Auto-fixes to .js. + */ + /** @type {import('eslint').Rule.RuleModule} */ module.exports = { meta: { diff --git a/packages/eslint-plugin-payload/customRules/no-relative-monorepo-imports.js b/packages/eslint-plugin-payload/customRules/no-relative-monorepo-imports.js index 92d6f5dbc..0cfdf09e4 100644 --- a/packages/eslint-plugin-payload/customRules/no-relative-monorepo-imports.js +++ b/packages/eslint-plugin-payload/customRules/no-relative-monorepo-imports.js @@ -1,3 +1,9 @@ +/** + * Disallows imports from relative monorepo package paths. + * + * ie. `import { mongooseAdapter } from '../../../packages/mongoose-adapter/src'` + */ + /** @type {import('eslint').Rule.RuleModule} */ module.exports = { meta: { diff --git a/test/.eslintrc.cjs b/test/.eslintrc.cjs index 80ee19faa..5a7565683 100644 --- a/test/.eslintrc.cjs +++ b/test/.eslintrc.cjs @@ -43,10 +43,7 @@ module.exports = { { files: ['**/*.int.spec.ts', '**/int.spec.ts'], rules: { - 'payload/no-relative-monorepo-imports': 'error', '@typescript-eslint/no-explicit-any': 'off', - '@typescript-eslint/no-unsafe-assignment': 'off', - '@typescript-eslint/no-use-before-define': 'off', 'jest/prefer-strict-equal': 'off', }, },