fix(richtext-lexical): user-defined html converters not taking precedence, and shared default html converters doubling in size after every field initialization

This commit is contained in:
Alessio Gravili
2024-05-29 00:14:58 -04:00
parent a2e9bcd333
commit 2c283bcc08
2 changed files with 31 additions and 4 deletions

View File

@@ -28,12 +28,12 @@ export const consolidateHTMLConverters = ({
editorConfig, editorConfig,
}: { }: {
editorConfig: SanitizedServerEditorConfig editorConfig: SanitizedServerEditorConfig
}) => { }): HTMLConverter[] => {
const htmlConverterFeature = editorConfig.resolvedFeatureMap.get('htmlConverter') const htmlConverterFeature = editorConfig.resolvedFeatureMap.get('htmlConverter')
const htmlConverterFeatureProps: HTMLConverterFeatureProps = const htmlConverterFeatureProps: HTMLConverterFeatureProps =
htmlConverterFeature?.serverFeatureProps htmlConverterFeature?.serverFeatureProps
const defaultConvertersWithConvertersFromFeatures = defaultHTMLConverters const defaultConvertersWithConvertersFromFeatures = [...defaultHTMLConverters]
for (const converter of editorConfig.features.converters.html) { for (const converter of editorConfig.features.converters.html) {
defaultConvertersWithConvertersFromFeatures.push(converter) defaultConvertersWithConvertersFromFeatures.push(converter)
@@ -48,7 +48,33 @@ export const consolidateHTMLConverters = ({
: (htmlConverterFeatureProps?.converters as HTMLConverter[]) || : (htmlConverterFeatureProps?.converters as HTMLConverter[]) ||
defaultConvertersWithConvertersFromFeatures defaultConvertersWithConvertersFromFeatures
return finalConverters // filter converters by nodeTypes. The last converter in the list wins. If there are multiple converters for the same nodeType, the last one will be used and the node types will be removed from
// previous converters. If previous converters do not have any nodeTypes left, they will be removed from the list.
// This guarantees that user-added converters which are added after the default ones will always have precedence
const foundNodeTypes: string[] = []
const filteredConverters: HTMLConverter[] = []
for (const converter of finalConverters.reverse()) {
if (!converter.nodeTypes?.length) {
continue
}
const newConverter: HTMLConverter = {
converter: converter.converter,
nodeTypes: [...converter.nodeTypes],
}
newConverter.nodeTypes = newConverter.nodeTypes.filter((nodeType) => {
if (foundNodeTypes.includes(nodeType)) {
return false
}
foundNodeTypes.push(nodeType)
return true
})
if (newConverter.nodeTypes.length) {
filteredConverters.push(newConverter)
}
}
return filteredConverters
} }
export const lexicalHTML: ( export const lexicalHTML: (

View File

@@ -169,13 +169,14 @@ export const LinkFeature: FeatureProviderProviderServer<LinkFeatureServerProps,
}) })
const rel: string = node.fields.newTab ? ' rel="noopener noreferrer"' : '' const rel: string = node.fields.newTab ? ' rel="noopener noreferrer"' : ''
const target: string = node.fields.newTab ? ' target="_blank"' : ''
const href: string = const href: string =
node.fields.linkType === 'custom' node.fields.linkType === 'custom'
? node.fields.url ? node.fields.url
: (node.fields.doc?.value as string) : (node.fields.doc?.value as string)
return `<a href="${href}"${rel}>${childrenText}</a>` return `<a href="${href}"${target}${rel}>${childrenText}</a>`
}, },
nodeTypes: [LinkNode.getType()], nodeTypes: [LinkNode.getType()],
}, },