tabshift/payloadcms
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(ui): error in filtered relationship field component while scrolling, if the select option label is a number (#9117)

Browse Source 
1. Open fields test suite
2. Type in relationship field, that has a relation to the numbers
collection
3. Scroll

You will get an error, as the label for the entry corresponding to the
numbers collection is of type number, and it attempts to use the
.toString() method on it
This commit is contained in:
Alessio Gravili
2024-11-11 20:37:53 -07:00
committed by GitHub
parent 9c559d7304
commit 2ad991759f
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/ui/src/fields/Relationship/index.tsx
View File

@@ -537,17 +537,19 @@ const RelationshipFieldComponent: RelationshipFieldClientComponent = (props) =>
const r = wordBoundariesRegex(searchFilter || '')
// breaking the labels to search into smaller parts increases performance
const breakApartThreshold = 250
let string = item.label
let labelString = String(item.label)
// strings less than breakApartThreshold length won't be chunked
while (string.length > breakApartThreshold) {
while (labelString.length > breakApartThreshold) {
// slicing by the next space after the length of the search input prevents slicing the string up by partial words
const indexOfSpace = string.indexOf(' ', searchFilter.length)
if (r.test(string.slice(0, indexOfSpace === -1 ? searchFilter.length : indexOfSpace + 1))) {
const indexOfSpace = labelString.indexOf(' ', searchFilter.length)
if (
r.test(labelString.slice(0, indexOfSpace === -1 ? searchFilter.length : indexOfSpace + 1))
) {
return true
}
string = string.slice(indexOfSpace === -1 ? searchFilter.length : indexOfSpace + 1)
labelString = labelString.slice(indexOfSpace === -1 ? searchFilter.length : indexOfSpace + 1)
}
return r.test(string.slice(-breakApartThreshold))
return r.test(labelString.slice(-breakApartThreshold))
}, [])
const onDocumentDrawerOpen = useCallback<