From 09f17f44508539cfcb8722f7f462ef40d9ed54fd Mon Sep 17 00:00:00 2001 From: Alessio Gravili Date: Sun, 12 Nov 2023 22:28:05 +0100 Subject: [PATCH] fix(richtext-lexical): Blocks: z-index issue, e.g. select field dropdown in blocks hidden behind blocks below, or slash menu inside nested editor hidden behind blocks below --- .../richtext-lexical/src/field/lexical/ui/ContentEditable.scss | 1 - test/fields/collections/Lexical/blocks.ts | 1 + test/fields/lexical.e2e.spec.ts | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/richtext-lexical/src/field/lexical/ui/ContentEditable.scss b/packages/richtext-lexical/src/field/lexical/ui/ContentEditable.scss index 65bf13fd7..a563e34bd 100644 --- a/packages/richtext-lexical/src/field/lexical/ui/ContentEditable.scss +++ b/packages/richtext-lexical/src/field/lexical/ui/ContentEditable.scss @@ -15,7 +15,6 @@ & > * { transition: transform 0.2s ease-in-out; // will-change: transform; // breaks cursor rendering for empty paragraph blocks in safari, and creates other issues - position: relative; // makes sure that z-index properties work - for example for the Blocks feature } } diff --git a/test/fields/collections/Lexical/blocks.ts b/test/fields/collections/Lexical/blocks.ts index 6b04794cd..a0e713863 100644 --- a/test/fields/collections/Lexical/blocks.ts +++ b/test/fields/collections/Lexical/blocks.ts @@ -113,6 +113,7 @@ export const SubBlockBlock: Block = { }, ], }, + SelectFieldBlock, ], }, ], diff --git a/test/fields/lexical.e2e.spec.ts b/test/fields/lexical.e2e.spec.ts index be09a4b60..6489bbc1b 100644 --- a/test/fields/lexical.e2e.spec.ts +++ b/test/fields/lexical.e2e.spec.ts @@ -300,7 +300,7 @@ describe('lexical', () => { const textNode1: SerializedTextNode = paragraphNodeInBlockNodeRichText.children[0] const boldNode: SerializedTextNode = paragraphNodeInBlockNodeRichText.children[1] - expect(textNode1.text).toBe('Some text below ') + expect(textNode1.text).toBe('Some text below r') expect(textNode1.format).toBe(0) expect(boldNode.text).toBe('elationship node 1')