Files
payload/test/plugin-seo/e2e.spec.ts
Jacob Fletcher c96fa613bc feat!: on demand rsc (#8364)
Currently, Payload renders all custom components on initial compile of
the admin panel. This is problematic for two key reasons:
1. Custom components do not receive contextual data, i.e. fields do not
receive their field data, edit views do not receive their document data,
etc.
2. Components are unnecessarily rendered before they are used

This was initially required to support React Server Components within
the Payload Admin Panel for two key reasons:
1. Fields can be dynamically rendered within arrays, blocks, etc.
2. Documents can be recursively rendered within a "drawer" UI, i.e.
relationship fields
3. Payload supports server/client component composition 

In order to achieve this, components need to be rendered on the server
and passed as "slots" to the client. Currently, the pattern for this is
to render custom server components in the "client config". Then when a
view or field is needed to be rendered, we first check the client config
for a "pre-rendered" component, otherwise render our client-side
fallback component.

But for the reasons listed above, this pattern doesn't exactly make
custom server components very useful within the Payload Admin Panel,
which is where this PR comes in. Now, instead of pre-rendering all
components on initial compile, we're able to render custom components
_on demand_, only as they are needed.

To achieve this, we've established [this
pattern](https://github.com/payloadcms/payload/pull/8481) of React
Server Functions in the Payload Admin Panel. With Server Functions, we
can iterate the Payload Config and return JSX through React's
`text/x-component` content-type. This means we're able to pass
contextual props to custom components, such as data for fields and
views.

## Breaking Changes

1. Add the following to your root layout file, typically located at
`(app)/(payload)/layout.tsx`:

    ```diff
    /* THIS FILE WAS GENERATED AUTOMATICALLY BY PAYLOAD. */
    /* DO NOT MODIFY IT BECAUSE IT COULD BE REWRITTEN AT ANY TIME. */
    + import type { ServerFunctionClient } from 'payload'

    import config from '@payload-config'
    import { RootLayout } from '@payloadcms/next/layouts'
    import { handleServerFunctions } from '@payloadcms/next/utilities'
    import React from 'react'

    import { importMap } from './admin/importMap.js'
    import './custom.scss'

    type Args = {
      children: React.ReactNode
    }

+ const serverFunctions: ServerFunctionClient = async function (args) {
    +  'use server'
    +  return handleServerFunctions({
    +    ...args,
    +    config,
    +    importMap,
    +  })
    + }

    const Layout = ({ children }: Args) => (
      <RootLayout
        config={config}
        importMap={importMap}
    +  serverFunctions={serverFunctions}
      >
        {children}
      </RootLayout>
    )

    export default Layout
    ```

2. If you were previously posting to the `/api/form-state` endpoint, it
no longer exists. Instead, you'll need to invoke the `form-state` Server
Function, which can be done through the _new_ `getFormState` utility:

    ```diff
    - import { getFormState } from '@payloadcms/ui'
    - const { state } = await getFormState({
    -   apiRoute: '',
    -   body: {
    -     // ...
    -   },
    -   serverURL: ''
    - })

    + const { getFormState } = useServerFunctions()
    +
    + const { state } = await getFormState({
    +   // ...
    + })
    ```

## Breaking Changes

```diff
- useFieldProps()
- useCellProps()
```

More details coming soon.

---------

Co-authored-by: Alessio Gravili <alessio@gravili.de>
Co-authored-by: Jarrod Flesch <jarrodmflesch@gmail.com>
Co-authored-by: James <james@trbl.design>
2024-11-11 13:59:05 -05:00

170 lines
6.1 KiB
TypeScript

import type { Page } from '@playwright/test'
import { expect, test } from '@playwright/test'
import path from 'path'
import { getFileByPath } from 'payload'
import { wait } from 'payload/shared'
import { fileURLToPath } from 'url'
import type { Config, Page as PayloadPage } from './payload-types.js'
import { ensureCompilationIsDone, initPageConsoleErrorCatch } from '../helpers.js'
import { AdminUrlUtil } from '../helpers/adminUrlUtil.js'
import { initPayloadE2ENoConfig } from '../helpers/initPayloadE2ENoConfig.js'
import { TEST_TIMEOUT_LONG } from '../playwright.config.js'
import { mediaSlug } from './shared.js'
const filename = fileURLToPath(import.meta.url)
const dirname = path.dirname(filename)
const { beforeAll, describe } = test
let url: AdminUrlUtil
let page: Page
let id: string
describe('SEO Plugin', () => {
beforeAll(async ({ browser }, testInfo) => {
testInfo.setTimeout(TEST_TIMEOUT_LONG)
const { serverURL, payload } = await initPayloadE2ENoConfig<Config>({ dirname })
url = new AdminUrlUtil(serverURL, 'pages')
const context = await browser.newContext()
page = await context.newPage()
initPageConsoleErrorCatch(page)
await ensureCompilationIsDone({ page, serverURL })
const filePath = path.resolve(dirname, './image-1.jpg')
const file = await getFileByPath(filePath)
const mediaDoc = await payload.create({
collection: mediaSlug,
data: {},
file,
})
const createdPage = (await payload.create({
collection: 'pages',
data: {
slug: 'test-page',
meta: {
description: 'This is a test meta description',
image: mediaDoc.id,
ogTitle: 'This is a custom og:title field',
title: 'This is a test meta title',
},
title: 'Test Page',
},
})) as unknown as PayloadPage
id = createdPage.id
})
describe('Core functionality', () => {
test('Config tab should be merged in correctly', async () => {
await page.goto(url.edit(id))
const contentTabsClass = '.tabs-field__tabs .tabs-field__tab-button'
const firstTab = page.locator(contentTabsClass).nth(0)
await expect(firstTab).toContainText('General')
})
test('Should auto-generate meta title when button is clicked in tabs', async () => {
const contentTabsClass = '.tabs-field__tabs .tabs-field__tab-button'
const autoGenerateButtonClass = '.group-field__wrap .render-fields div:nth-of-type(1) button'
const metaTitleClass = '#field-meta__title'
const secondTab = page.locator(contentTabsClass).nth(1)
await secondTab.click()
const metaTitle = page.locator(metaTitleClass)
await expect(metaTitle).toHaveValue('This is a test meta title')
const autoGenButton = page.locator(autoGenerateButtonClass).nth(0)
await expect(autoGenButton).toContainText('Auto-generate')
await autoGenButton.click()
await expect(metaTitle).toHaveValue('Website.com — Test Page')
})
// todo: Re-enable this test once required attributes are fixed
/* test('Title should be required as per custom override', async () => {
const metaTitleClass = '#field-title'
const metaTitle = page.locator(metaTitleClass).nth(0)
await expect(metaTitle).toHaveAttribute('required', '')
}) */
test('Indicator should be orangered and characters counted', async () => {
const indicatorClass =
'#field-meta > div > div.render-fields.render-fields--margins-small > div:nth-child(2) > div:nth-child(3) > div > div:nth-child(3) > div'
const indicatorLabelClass =
'#field-meta > div > div.render-fields.render-fields--margins-small > div:nth-child(2) > div:nth-child(3) > div > div:nth-child(2)'
const indicator = page.locator(indicatorClass)
const indicatorLabel = page.locator(indicatorLabelClass)
await expect(indicatorLabel).toContainText('23/50-60 chars, 27 to go')
await expect(indicator).toHaveCSS('background-color', 'rgb(255, 69, 0)')
})
test('Should generate a search result preview based on content', async () => {
await page.goto(url.edit(id))
const contentTabsClass = '.tabs-field__tabs .tabs-field__tab-button'
const autoGenerateButtonClass = '.group-field__wrap .render-fields div:nth-of-type(1) button'
const metaDescriptionClass = '#field-meta__description'
const previewClass =
'#field-meta > div > div.render-fields.render-fields--margins-small > div:nth-child(5)'
const secondTab = page.locator(contentTabsClass).nth(1)
await secondTab.click()
const metaDescription = page.locator(metaDescriptionClass)
await metaDescription.fill('My new amazing SEO description')
const preview = page.locator(previewClass)
await expect(preview).toContainText('https://yoursite.com/en/')
await expect(preview).toContainText('This is a test meta title')
await expect(preview).toContainText('My new amazing SEO description')
})
})
describe('i18n', () => {
test('support for another language', async () => {
await page.goto(url.edit(id))
const contentTabsClass = '.tabs-field__tabs .tabs-field__tab-button'
const autoGenerateButtonClass = '.group-field__wrap .render-fields div:nth-of-type(1) button'
const secondTab = page.locator(contentTabsClass).nth(1)
await secondTab.click()
const autoGenButton = page.locator(autoGenerateButtonClass).nth(0)
await expect(autoGenButton).toContainText('Auto-generate')
// Go to account page
await page.goto(url.account)
const languageField = page.locator('.payload-settings__language .react-select')
const options = page.locator('.rs__option')
// Change language to Spanish
await languageField.click()
await wait(200)
await options.locator('text=Español').click()
await expect(languageField).toContainText('Español')
await wait(600)
// Navigate back to the page
await page.goto(url.edit(id))
await wait(600)
await secondTab.click()
await wait(600)
await expect(autoGenButton).toContainText('Auto-génerar')
})
})
})