improves error structure

This commit is contained in:
James
2020-01-21 16:53:26 -05:00
parent 1ab5199316
commit d6db1dda55
3 changed files with 20 additions and 16 deletions

View File

@@ -0,0 +1,18 @@
const formatErrorResponse = (incoming, source) => {
switch (source) {
case 'mongoose':
return {
errors: Object.keys(incoming.errors).reduce((acc, key) => {
acc.push({
message: incoming.errors[key].message,
});
return acc;
}, []),
};
default:
return incoming;
}
};
module.exports = formatErrorResponse;

View File

@@ -1,14 +0,0 @@
const errorFormatter = (incoming, source) => {
switch (source) {
case 'mongoose':
return Object.keys(incoming.errors).reduce((acc, key) => {
acc.push(incoming.errors[key].message);
return acc;
}, []);
default:
return incoming;
}
};
module.exports = errorFormatter;

View File

@@ -1,11 +1,11 @@
const httpStatus = require('http-status');
const errorFormatter = require('../../errors/formatter');
const formatErrorResponse = require('../../errors/formatResponse');
const create = (req, res) => {
req.model.create(req.body, (err, result) => {
if (err) {
res.status(httpStatus.INTERNAL_SERVER_ERROR)
.json(errorFormatter(err, 'mongoose'));
.json(formatErrorResponse(err, 'mongoose'));
return;
}