tabshift/payload
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ui): url encode imageCacheTag for media on dashboard (#11164)

Browse Source 
### What?
URL encodes the imageCacheTag query param used to render Media on the
Admin Dashboard

### Why?
The format of the timestamp used as the `imageCacheTag` is causing an
`InvalidQueryStringException` when hosting with Cloudfront + Lambda
(SST/OpenNext)
[See issue](https://github.com/payloadcms/payload/issues/11163)

### How?
Uses `encodeURIComponent` on instances where the `imageCacheTag` is
being formatted for the request URL. (In EditUpload, Thumbnail, and
PreviewSizes)

Fixes #11163

---------

Co-authored-by: Jarrod Flesch <jarrodmflesch@gmail.com>
This commit is contained in:
lucasbajoua
2025-02-13 13:42:52 -08:00
committed by GitHub
parent 7f124cfe93
commit d47c980509
4 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/uploads/e2e.spec.ts
View File

@@ -22,20 +22,20 @@ import { RESTClient } from '../helpers/rest.js'
import { TEST_TIMEOUT_LONG } from '../playwright.config.js'
import {
adminThumbnailFunctionSlug,
adminThumbnailWithSearchQueries,
mediaWithoutCacheTagsSlug,
adminThumbnailSizeSlug,
adminThumbnailWithSearchQueries,
animatedTypeMedia,
audioSlug,
customFileNameMediaSlug,
customUploadFieldSlug,
focalOnlySlug,
mediaSlug,
mediaWithoutCacheTagsSlug,
relationPreviewSlug,
relationSlug,
withMetadataSlug,
withOnlyJPEGMetadataSlug,
withoutMetadataSlug,
customUploadFieldSlug,
} from './shared.js'
import { startMockCorsServer } from './startMockCorsServer.js'
const filename = fileURLToPath(import.meta.url)
@@ -500,9 +500,9 @@ describe('Uploads', () => {
/**
* Regex matcher for date cache tags.
*
* @example it will match `?2022-01-01T00:00:00.000Z`
* @example it will match `?2022-01-01T00%3A00%3A00.000Z` (`?2022-01-01T00:00:00.000Z` encoded)
*/
const cacheTagPattern = /\?\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}Z/
const cacheTagPattern = /\?\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}\.\d{3}Z/
expect(src).not.toMatch(cacheTagPattern)
})
@@ -530,9 +530,9 @@ describe('Uploads', () => {
/**
* Regex matcher for date cache tags.
*
* @example it will match `?2022-01-01T00:00:00.000Z`
* @example it will match `?2022-01-01T00%3A00%3A00.000Z` (`?2022-01-01T00:00:00.000Z` encoded)
*/
const cacheTagPattern = /\?\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}Z/
const cacheTagPattern = /\?\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}\.\d{3}Z/
expect(src).toMatch(cacheTagPattern)
})
@@ -857,7 +857,7 @@ describe('Uploads', () => {
})
describe('remote url fetching', () => {
beforeAll(async () => {
beforeAll(() => {
mockCorsServer = startMockCorsServer()
})