From d047f01bfad2dffbd634720fe6d0d24005c11db6 Mon Sep 17 00:00:00 2001
From: Dan Ribbens <DanRibbens@users.noreply.github.com>
Date: Tue, 3 Dec 2024 13:02:44 -0500
Subject: [PATCH] fix: copy data from locale transaction error (#9673)

### What?
Write conflict errors can arise when collections have hooks.

### Why?
The copyDataFromLocale local API calls to update were not passsing req
so changes could be made on different transcations.

### How?
Fixed the error by passing `req` and also introduced some perf
optimizations using `depth` and disabling `joins` since that data isn't
needed for this operation.
---
 packages/ui/src/utilities/copyDataFromLocale.ts | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/packages/ui/src/utilities/copyDataFromLocale.ts b/packages/ui/src/utilities/copyDataFromLocale.ts
index af9be951fc..9ca0628899 100644
--- a/packages/ui/src/utilities/copyDataFromLocale.ts
+++ b/packages/ui/src/utilities/copyDataFromLocale.ts
@@ -133,8 +133,7 @@ export const copyDataFromLocaleHandler = async (args: CopyDataFromLocaleArgs) =>
   const { req } = args
 
   try {
-    const res = await copyDataFromLocale(args)
-    return res
+    return await copyDataFromLocale(args)
   } catch (err) {
     req.payload.logger.error({
       err,
@@ -161,6 +160,7 @@ export const copyDataFromLocale = async (args: CopyDataFromLocaleArgs) => {
       payload: { collections, globals },
       user,
     },
+    req,
     toLocale,
   } = args
 
@@ -189,6 +189,7 @@ export const copyDataFromLocale = async (args: CopyDataFromLocaleArgs) => {
     globalSlug
       ? payload.findGlobal({
           slug: globalSlug,
+          depth: 0,
           locale: fromLocale,
           overrideAccess: false,
           user,
@@ -197,6 +198,8 @@ export const copyDataFromLocale = async (args: CopyDataFromLocaleArgs) => {
       : payload.findByID({
           id: docID,
           collection: collectionSlug,
+          depth: 0,
+          joins: false,
           locale: fromLocale,
           overrideAccess: false,
           user,
@@ -205,6 +208,7 @@ export const copyDataFromLocale = async (args: CopyDataFromLocaleArgs) => {
     globalSlug
       ? payload.findGlobal({
           slug: globalSlug,
+          depth: 0,
           locale: toLocale,
           overrideAccess: false,
           user,
@@ -213,6 +217,8 @@ export const copyDataFromLocale = async (args: CopyDataFromLocaleArgs) => {
       : payload.findByID({
           id: docID,
           collection: collectionSlug,
+          depth: 0,
+          joins: false,
           locale: toLocale,
           overrideAccess: false,
           user,
@@ -228,7 +234,7 @@ export const copyDataFromLocale = async (args: CopyDataFromLocaleArgs) => {
     throw new Error(`Error fetching data from locale "${toLocale}"`)
   }
 
-  const newToLocaleData = globalSlug
+  return globalSlug
     ? await payload.updateGlobal({
         slug: globalSlug,
         data: overrideData
@@ -236,6 +242,7 @@ export const copyDataFromLocale = async (args: CopyDataFromLocaleArgs) => {
           : mergeData(fromLocaleData.value, toLocaleData.value, globals[globalSlug].config.fields),
         locale: toLocale,
         overrideAccess: false,
+        req,
         user,
       })
     : await payload.update({
@@ -250,8 +257,7 @@ export const copyDataFromLocale = async (args: CopyDataFromLocaleArgs) => {
             ),
         locale: toLocale,
         overrideAccess: false,
+        req,
         user,
       })
-
-  return newToLocaleData
 }