feat!: on demand rsc (#8364)
Currently, Payload renders all custom components on initial compile of the admin panel. This is problematic for two key reasons: 1. Custom components do not receive contextual data, i.e. fields do not receive their field data, edit views do not receive their document data, etc. 2. Components are unnecessarily rendered before they are used This was initially required to support React Server Components within the Payload Admin Panel for two key reasons: 1. Fields can be dynamically rendered within arrays, blocks, etc. 2. Documents can be recursively rendered within a "drawer" UI, i.e. relationship fields 3. Payload supports server/client component composition In order to achieve this, components need to be rendered on the server and passed as "slots" to the client. Currently, the pattern for this is to render custom server components in the "client config". Then when a view or field is needed to be rendered, we first check the client config for a "pre-rendered" component, otherwise render our client-side fallback component. But for the reasons listed above, this pattern doesn't exactly make custom server components very useful within the Payload Admin Panel, which is where this PR comes in. Now, instead of pre-rendering all components on initial compile, we're able to render custom components _on demand_, only as they are needed. To achieve this, we've established [this pattern](https://github.com/payloadcms/payload/pull/8481) of React Server Functions in the Payload Admin Panel. With Server Functions, we can iterate the Payload Config and return JSX through React's `text/x-component` content-type. This means we're able to pass contextual props to custom components, such as data for fields and views. ## Breaking Changes 1. Add the following to your root layout file, typically located at `(app)/(payload)/layout.tsx`: ```diff /* THIS FILE WAS GENERATED AUTOMATICALLY BY PAYLOAD. */ /* DO NOT MODIFY IT BECAUSE IT COULD BE REWRITTEN AT ANY TIME. */ + import type { ServerFunctionClient } from 'payload' import config from '@payload-config' import { RootLayout } from '@payloadcms/next/layouts' import { handleServerFunctions } from '@payloadcms/next/utilities' import React from 'react' import { importMap } from './admin/importMap.js' import './custom.scss' type Args = { children: React.ReactNode } + const serverFunctions: ServerFunctionClient = async function (args) { + 'use server' + return handleServerFunctions({ + ...args, + config, + importMap, + }) + } const Layout = ({ children }: Args) => ( <RootLayout config={config} importMap={importMap} + serverFunctions={serverFunctions} > {children} </RootLayout> ) export default Layout ``` 2. If you were previously posting to the `/api/form-state` endpoint, it no longer exists. Instead, you'll need to invoke the `form-state` Server Function, which can be done through the _new_ `getFormState` utility: ```diff - import { getFormState } from '@payloadcms/ui' - const { state } = await getFormState({ - apiRoute: '', - body: { - // ... - }, - serverURL: '' - }) + const { getFormState } = useServerFunctions() + + const { state } = await getFormState({ + // ... + }) ``` ## Breaking Changes ```diff - useFieldProps() - useCellProps() ``` More details coming soon. --------- Co-authored-by: Alessio Gravili <alessio@gravili.de> Co-authored-by: Jarrod Flesch <jarrodmflesch@gmail.com> Co-authored-by: James <james@trbl.design>
This commit is contained in:
@@ -46,6 +46,11 @@ const networkConditions = {
|
||||
latency: 1000,
|
||||
upload: ((3 * 1000 * 1000) / 8) * 0.8,
|
||||
},
|
||||
'Fast 4G': {
|
||||
download: ((20 * 1000 * 1000) / 8) * 0.8,
|
||||
latency: 1000,
|
||||
upload: ((10 * 1000 * 1000) / 8) * 0.8,
|
||||
},
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -58,9 +63,11 @@ export async function ensureCompilationIsDone({
|
||||
customRoutes,
|
||||
page,
|
||||
serverURL,
|
||||
noAutoLogin,
|
||||
}: {
|
||||
customAdminRoutes?: Config['admin']['routes']
|
||||
customRoutes?: Config['routes']
|
||||
noAutoLogin?: boolean
|
||||
page: Page
|
||||
serverURL: string
|
||||
}): Promise<void> {
|
||||
@@ -70,9 +77,37 @@ export async function ensureCompilationIsDone({
|
||||
|
||||
const adminURL = `${serverURL}${adminRoute}`
|
||||
|
||||
await page.goto(adminURL)
|
||||
await page.waitForURL(adminURL)
|
||||
const maxAttempts = 50
|
||||
let attempt = 1
|
||||
|
||||
while (attempt <= maxAttempts) {
|
||||
try {
|
||||
console.log(`Checking if compilation is done (attempt ${attempt}/${maxAttempts})...`)
|
||||
|
||||
await page.goto(adminURL)
|
||||
await page.waitForURL(
|
||||
noAutoLogin ? `${adminURL + (adminURL.endsWith('/') ? '' : '/')}login` : adminURL,
|
||||
)
|
||||
|
||||
console.log('Successfully compiled')
|
||||
return
|
||||
} catch (error) {
|
||||
console.error(`Compilation not done yet`)
|
||||
|
||||
if (attempt === maxAttempts) {
|
||||
console.error('Max retry attempts reached. Giving up.')
|
||||
throw error
|
||||
}
|
||||
|
||||
console.log('Retrying in 3 seconds...')
|
||||
await wait(3000)
|
||||
attempt++
|
||||
}
|
||||
}
|
||||
|
||||
if (noAutoLogin) {
|
||||
return
|
||||
}
|
||||
await expect(() => expect(page.locator('.template-default')).toBeVisible()).toPass({
|
||||
timeout: POLL_TOPASS_TIMEOUT,
|
||||
})
|
||||
@@ -89,7 +124,7 @@ export async function throttleTest({
|
||||
page,
|
||||
}: {
|
||||
context: BrowserContext
|
||||
delay: 'Fast 3G' | 'Slow 3G' | 'Slow 4G'
|
||||
delay: keyof typeof networkConditions
|
||||
page: Page
|
||||
}) {
|
||||
const cdpSession = await context.newCDPSession(page)
|
||||
@@ -311,7 +346,9 @@ export function initPageConsoleErrorCatch(page: Page) {
|
||||
!msg.text().includes('Failed to fetch RSC payload for') &&
|
||||
!msg.text().includes('Error: NEXT_NOT_FOUND') &&
|
||||
!msg.text().includes('Error: NEXT_REDIRECT') &&
|
||||
!msg.text().includes('Error getting document data')
|
||||
!msg.text().includes('Error getting document data') &&
|
||||
!msg.text().includes('Failed trying to load default language strings') &&
|
||||
!msg.text().includes('TypeError: Failed to fetch') // This happens when server actions are aborted
|
||||
) {
|
||||
// "Failed to fetch RSC payload for" happens seemingly randomly. There are lots of issues in the next.js repository for this. Causes e2e tests to fail and flake. Will ignore for now
|
||||
// the the server responded with a status of error happens frequently. Will ignore it for now.
|
||||
|
||||
Reference in New Issue
Block a user