fix: modal overflow caused by unused button tooltips (#2676)

This commit is contained in:
Jacob Fletcher
2023-05-17 17:13:04 -04:00
committed by GitHub
parent 28e481c2e2
commit c1e92ad27d
5 changed files with 40 additions and 24 deletions

View File

@@ -28,12 +28,14 @@ const ButtonContents = ({ children, icon, tooltip, showTooltip }) => {
return (
<Fragment>
<Tooltip
className={`${baseClass}__tooltip`}
show={showTooltip}
>
{tooltip}
</Tooltip>
{tooltip && (
<Tooltip
className={`${baseClass}__tooltip`}
show={showTooltip}
>
{tooltip}
</Tooltip>
)}
<span className={`${baseClass}__content`}>
{children && (
<span className={`${baseClass}__label`}>

View File

@@ -16,6 +16,12 @@
}
.btn {
margin-right: $baseline;
margin: 0;
}
&__actions {
display: flex;
flex-wrap: wrap;
gap: $baseline;
}
}

View File

@@ -109,20 +109,22 @@ const DeleteDocument: React.FC<Props> = (props) => {
</strong>
</Trans>
</p>
<Button
id="confirm-cancel"
buttonStyle="secondary"
type="button"
onClick={deleting ? undefined : () => toggleModal(modalSlug)}
>
{t('cancel')}
</Button>
<Button
onClick={deleting ? undefined : handleDelete}
id="confirm-delete"
>
{deleting ? t('deleting') : t('confirm')}
</Button>
<div className={`${baseClass}__actions`}>
<Button
id="confirm-cancel"
buttonStyle="secondary"
type="button"
onClick={deleting ? undefined : () => toggleModal(modalSlug)}
>
{t('cancel')}
</Button>
<Button
onClick={deleting ? undefined : handleDelete}
id="confirm-delete"
>
{deleting ? t('deleting') : t('confirm')}
</Button>
</div>
</MinimalTemplate>
</Modal>
</React.Fragment>

View File

@@ -12,6 +12,12 @@
}
.btn {
margin-right: base(1);
margin: 0;
}
&__actions {
display: flex;
flex-wrap: wrap;
gap: $baseline;
}
}

View File

@@ -20,8 +20,8 @@ const StayLoggedInModal: React.FC<Props> = (props) => {
const {
routes: { admin },
admin: {
logoutRoute
}
logoutRoute,
},
} = config;
const { toggleModal } = useModal();
const { t } = useTranslation('authentication');