From a471e259c1c842210fd50e8adfc397fd8f2d3a99 Mon Sep 17 00:00:00 2001
From: James <james@trbl.design>
Date: Mon, 6 Jul 2020 17:00:18 -0400
Subject: [PATCH] improves prop conventions of ListControls

---
 src/client/components/elements/ListControls/index.js   | 10 +++++-----
 .../forms/field-types/Upload/SelectExisting/index.js   |  2 +-
 .../components/views/collections/List/Default.js       |  2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/client/components/elements/ListControls/index.js b/src/client/components/elements/ListControls/index.js
index 1ea4b188f7..6e9ea02680 100644
--- a/src/client/components/elements/ListControls/index.js
+++ b/src/client/components/elements/ListControls/index.js
@@ -14,7 +14,7 @@ const ListControls = (props) => {
   const {
     handleChange,
     collection,
-    disableColumns,
+    enableColumns,
     collection: {
       fields,
       useAsTitle,
@@ -74,7 +74,7 @@ const ListControls = (props) => {
         />
         <div className={`${baseClass}__buttons`}>
           <div className={`${baseClass}__buttons-wrap`}>
-            {!disableColumns && (
+            {enableColumns && (
               <Button
                 className={`${baseClass}__toggle-columns`}
                 buttonStyle={visibleDrawer === 'columns' ? undefined : 'secondary'}
@@ -97,7 +97,7 @@ const ListControls = (props) => {
           </div>
         </div>
       </div>
-      {!disableColumns && (
+      {enableColumns && (
         <AnimateHeight
           className={`${baseClass}__columns`}
           height={visibleDrawer === 'columns' ? 'auto' : 0}
@@ -123,11 +123,11 @@ const ListControls = (props) => {
 };
 
 ListControls.defaultProps = {
-  disableColumns: false,
+  enableColumns: true,
 };
 
 ListControls.propTypes = {
-  disableColumns: PropTypes.bool,
+  enableColumns: PropTypes.bool,
   collection: PropTypes.shape({
     useAsTitle: PropTypes.string,
     fields: PropTypes.arrayOf(PropTypes.shape),
diff --git a/src/client/components/forms/field-types/Upload/SelectExisting/index.js b/src/client/components/forms/field-types/Upload/SelectExisting/index.js
index 13ec419d82..a6e2c0ec2d 100644
--- a/src/client/components/forms/field-types/Upload/SelectExisting/index.js
+++ b/src/client/components/forms/field-types/Upload/SelectExisting/index.js
@@ -74,7 +74,7 @@ const SelectExistingUploadModal = (props) => {
           />
         </header>
         <ListControls
-          disableColumns
+          enableColumns={false}
           handleChange={setListControls}
           collection={{
             ...collection,
diff --git a/src/client/components/views/collections/List/Default.js b/src/client/components/views/collections/List/Default.js
index 7a4fffa066..cf21e8cd54 100644
--- a/src/client/components/views/collections/List/Default.js
+++ b/src/client/components/views/collections/List/Default.js
@@ -69,7 +69,7 @@ const DefaultList = (props) => {
         <ListControls
           handleChange={setListControls}
           collection={collection}
-          disableColumns={Boolean(upload)}
+          enableColumns={!upload}
         />
         {(data.docs && data.docs.length > 0) && (
           <>