tabshift/payload
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1978 from payloadcms/fix/1897

Browse Source 
fix: removes old media when replaced and re-renders on save
This commit is contained in:
James Mikrut
2023-02-07 11:53:05 -05:00
committed by GitHub
parent 922887fe77 e6ed676117
commit 96a90bbca4
10 changed files with 111 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/uploads/e2e.spec.ts
View File

@@ -84,6 +84,10 @@ describe('uploads', () => {
await saveDocAndAssert(page);
});
test('should update file upload', async () => {
await page.goto(mediaURL.edit(mediaDoc.id));
});
test('should show resized images', async () => {
await page.goto(mediaURL.edit(pngDoc.id));

11
test/uploads/int.spec.ts
View File

@@ -7,7 +7,6 @@ import { RESTClient } from '../helpers/rest';
import config, { mediaSlug, relationSlug } from './config';
import payload from '../../src';
import getFileByPath from '../../src/uploads/getFileByPath';
import type { Media } from './payload-types';
const stat = promisify(fs.stat);
@@ -176,9 +175,9 @@ describe('Collections - Uploads', () => {
expect(status).toBe(200);
// Check that previously existing files weren't affected
expect(await fileExists(path.join(__dirname, './media', mediaDoc.filename))).toBe(true);
expect(await fileExists(path.join(__dirname, './media', mediaDoc.sizes.icon.filename))).toBe(true);
// Check that previously existing files were removed
expect(await fileExists(path.join(__dirname, './media', mediaDoc.filename))).toBe(false);
expect(await fileExists(path.join(__dirname, './media', mediaDoc.sizes.icon.filename))).toBe(false);
});
it('should remove extra sizes on update', async () => {
@@ -186,13 +185,13 @@ describe('Collections - Uploads', () => {
const file = await getFileByPath(filePath);
const small = await getFileByPath(path.resolve(__dirname, './small.png'));
const { id } = await payload.create<Media>({
const { id } = await payload.create({
collection: mediaSlug,
data: {},
file,
});
const doc = await payload.update<Media>({
const doc = await payload.update({
collection: mediaSlug,
id,
data: {},