From 90dab3c445d4bdbab0eff286a2b66861d04f2a93 Mon Sep 17 00:00:00 2001 From: Elliot DeNolf Date: Mon, 24 Apr 2023 10:42:29 -0400 Subject: [PATCH] fix: prevent sharp toFormat settings fallthrough by using clone (#2547) --- src/uploads/imageResizer.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/uploads/imageResizer.ts b/src/uploads/imageResizer.ts index e274a770af..d7701bb1b6 100644 --- a/src/uploads/imageResizer.ts +++ b/src/uploads/imageResizer.ts @@ -56,7 +56,7 @@ export default async function resizeAndSave({ const sizesToSave: FileToSave[] = []; const sizeData = {}; - const sharpInstance = sharp(file.tempFilePath || file.data); + const sharpBase = sharp(file.tempFilePath || file.data); const promises = imageSizes .map(async (desiredSize) => { @@ -71,7 +71,7 @@ export default async function resizeAndSave({ }; return; } - let resized = sharpInstance.resize(desiredSize); + let resized = sharpBase.clone().resize(desiredSize); if (desiredSize.formatOptions) { resized = resized.toFormat(desiredSize.formatOptions.format, desiredSize.formatOptions.options);