From 7ac2d0dcff0388cd20ea2cbf9e5e1387f458172d Mon Sep 17 00:00:00 2001 From: Elliot DeNolf Date: Mon, 12 Oct 2020 16:22:40 -0400 Subject: [PATCH] test: remove beforeRead hook, messes with tests --- demo/collections/Media.js | 5 --- .../requestHandlers/collections.spec.js | 38 ++++++++++++------- 2 files changed, 24 insertions(+), 19 deletions(-) diff --git a/demo/collections/Media.js b/demo/collections/Media.js index 0a8c27d40f..7bbb10b41e 100644 --- a/demo/collections/Media.js +++ b/demo/collections/Media.js @@ -43,11 +43,6 @@ module.exports = { type: 'text', required: true, localized: true, - hooks: { - afterRead: [ - ({ value }) => `${value} alt`, - ], - }, }, { name: 'sizes', diff --git a/src/collections/requestHandlers/collections.spec.js b/src/collections/requestHandlers/collections.spec.js index c2c4fbaa42..37de926586 100644 --- a/src/collections/requestHandlers/collections.spec.js +++ b/src/collections/requestHandlers/collections.spec.js @@ -618,20 +618,30 @@ describe('Collections - REST', () => { expect(await fileExists(path.join(mediaDir, 'image-640x480.png'))).toBe(true); // Check api response - expect(data.doc.alt).not.toBeNull(); - expect(data.doc.filename).toBe('image.png'); - expect(data.doc.mimeType).not.toBeNull(); - expect(data.doc.sizes.icon.filesize).not.toBeLessThan(1); - - expect(data.doc.sizes.icon.filename).toBe('image-16x16.png'); - expect(data.doc.sizes.icon.width).toBe(16); - expect(data.doc.sizes.icon.height).toBe(16); - expect(data.doc.sizes.mobile.filename).toBe('image-320x240.png'); - expect(data.doc.sizes.mobile.width).toBe(320); - expect(data.doc.sizes.mobile.height).toBe(240); - expect(data.doc.sizes.tablet.filename).toBe('image-640x480.png'); - expect(data.doc.sizes.tablet.width).toBe(640); - expect(data.doc.sizes.tablet.height).toBe(480); + expect(data).toMatchObject({ + doc: { + alt: 'test media', + filename: 'image.png', + mimeType: 'image/png', + sizes: { + icon: { + filename: 'image-16x16.png', + width: 16, + height: 16, + }, + mobile: { + filename: 'image-320x240.png', + width: 320, + height: 240, + }, + tablet: { + filename: 'image-640x480.png', + width: 640, + height: 480, + }, + }, + }, + }); }); it('update', async () => {