feat(next): version view overhaul (#12027)
#11769 improved the lexical version view diff component. This PR improves the rest of the version view. ## What changed - Column layout when selecting a version: - Previously: Selected version on the left, latest version on the left - Now: Previous version on the left, previous version on the right (mimics behavior of GitHub) - Locale selector now displayed in pill selector, rather than react-select - Smoother, more reliable locale, modifiedOnly and version selection. Now uses clean event callbacks rather than useEffects - React-diff-viewer-continued has been replaced with the html differ we use in lexical - Updated Design for all field diffs - Version columns now have a clearly defined separator line - Fixed collapsibles showing in version view despite having no modified fields if modifiedOnly is true - New, redesigned header ## Screenshots ### Before   ### After    
This commit is contained in:
@@ -84,7 +84,7 @@ describe('Text', () => {
|
||||
const { columnContainer } = await openListColumns(page, {})
|
||||
|
||||
await expect(
|
||||
columnContainer.locator('.column-selector__column', {
|
||||
columnContainer.locator('.pill-selector__pill', {
|
||||
hasText: exactText('Hidden Text Field'),
|
||||
}),
|
||||
).toBeHidden()
|
||||
@@ -110,7 +110,7 @@ describe('Text', () => {
|
||||
const { columnContainer } = await openListColumns(page, {})
|
||||
|
||||
await expect(
|
||||
columnContainer.locator('.column-selector__column', {
|
||||
columnContainer.locator('.pill-selector__pill', {
|
||||
hasText: exactText('Disabled Text Field'),
|
||||
}),
|
||||
).toBeHidden()
|
||||
@@ -138,7 +138,7 @@ describe('Text', () => {
|
||||
const { columnContainer } = await openListColumns(page, {})
|
||||
|
||||
await expect(
|
||||
columnContainer.locator('.column-selector__column', {
|
||||
columnContainer.locator('.pill-selector__pill', {
|
||||
hasText: exactText('Admin Hidden Text Field'),
|
||||
}),
|
||||
).toBeVisible()
|
||||
@@ -184,7 +184,7 @@ describe('Text', () => {
|
||||
await page.goto(url.list)
|
||||
await openListColumns(page, {})
|
||||
await expect(
|
||||
page.locator(`.column-selector .column-selector__column`, {
|
||||
page.locator(`.pill-selector .pill-selector__pill`, {
|
||||
hasText: exactText('Disable List Column Text'),
|
||||
}),
|
||||
).toBeHidden()
|
||||
@@ -200,7 +200,7 @@ describe('Text', () => {
|
||||
await toggleColumn(page, {
|
||||
targetState: 'on',
|
||||
columnLabel: 'Text en',
|
||||
columnName: 'localizedText',
|
||||
columnName: 'i18nText',
|
||||
})
|
||||
|
||||
const textCell = page.locator('.row-1 .cell-i18nText')
|
||||
|
||||
Reference in New Issue
Block a user