fix(ui): incorrectly incrementing version counts if maxPerDoc is set to 0 (#11097)

Fixes https://github.com/payloadcms/payload/issues/9891

We were incorrectly setting max version count to 0 if it was configured
as maxPerDoc `0` due to `Math.min`

packages/ui/src/providers/DocumentInfo/index.tsx

@@ -257,10 +257,19 @@ const DocumentInfo: React.FC<
   )
 
   const incrementVersionCount = useCallback(() => {
+    const newCount = versionCount + 1
     if (collectionConfig && collectionConfig.versions) {
-      setVersionCount(Math.min(versionCount + 1, collectionConfig.versions.maxPerDoc))
+      if (collectionConfig.versions.maxPerDoc > 0) {
+        setVersionCount(Math.min(newCount, collectionConfig.versions.maxPerDoc))
+      } else {
+        setVersionCount(newCount)
+      }
     } else if (globalConfig && globalConfig.versions) {
-      setVersionCount(Math.min(versionCount + 1, globalConfig.versions.max))
+      if (globalConfig.versions.max > 0) {
+        setVersionCount(Math.min(newCount, globalConfig.versions.max))
+      } else {
+        setVersionCount(newCount)
+      }
     }
   }, [collectionConfig, globalConfig, versionCount])
 

test/versions/collections/Drafts.ts

@@ -127,7 +127,7 @@ const DraftPosts: CollectionConfig = {
     drafts: {
       schedulePublish: true,
     },
-    maxPerDoc: 35,
+    maxPerDoc: 0,
   },
 }
 

test/versions/e2e.spec.ts

@@ -436,7 +436,7 @@ describe('Versions', () => {
       await page.locator('#field-description').fill('initial description')
       await saveDocAndAssert(page)
 
-      const updatedAtWrapper = await page.locator(
+      const updatedAtWrapper = page.locator(
         '.doc-controls .doc-controls__content .doc-controls__list-item',
         {
           hasText: 'Last Modified',
@@ -450,9 +450,9 @@ describe('Versions', () => {
       await page.locator('#field-description').fill('changed description')
       await saveDocAndAssert(page)
 
-      const newUpdatedAt = await updatedAtWrapper.locator('.doc-controls__value').textContent()
+      const newUpdatedAt = updatedAtWrapper.locator('.doc-controls__value')
 
-      expect(newUpdatedAt).not.toEqual(initialUpdatedAt)
+      await expect(newUpdatedAt).not.toHaveText(initialUpdatedAt)
     })
 
     test('collection - should update updatedAt on autosave', async () => {
@@ -461,7 +461,7 @@ describe('Versions', () => {
       await waitForAutoSaveToRunAndComplete(page)
       await expect(page.locator('#field-title')).toHaveValue('autosave title')
 
-      const updatedAtWrapper = await page.locator(
+      const updatedAtWrapper = page.locator(
         '.doc-controls .doc-controls__content .doc-controls__list-item',
         {
           hasText: 'Last Modified',
@@ -475,9 +475,9 @@ describe('Versions', () => {
       await page.locator('#field-title').fill('autosave title updated')
       await waitForAutoSaveToRunAndComplete(page)
 
-      const newUpdatedAt = await updatedAtWrapper.locator('.doc-controls__value').textContent()
+      const newUpdatedAt = updatedAtWrapper.locator('.doc-controls__value')
 
-      expect(newUpdatedAt).not.toEqual(initialUpdatedAt)
+      await expect(newUpdatedAt).not.toHaveText(initialUpdatedAt)
     })
 
     test('global - should autosave', async () => {
@@ -646,6 +646,52 @@ describe('Versions', () => {
       await expect(page.locator('.rs__option')).toHaveText('some title')
     })
 
+    test('correctly increments version count', async () => {
+      const createdDoc = await payload.create({
+        collection: draftCollectionSlug,
+        data: {
+          description: 'some description',
+          title: 'some title',
+        },
+        draft: true,
+      })
+
+      await page.goto(url.edit(createdDoc.id))
+
+      const versionsCountSelector = `.doc-tabs__tabs .doc-tab__count`
+      const initialCount = await page.locator(versionsCountSelector).textContent()
+
+      const field = page.locator('#field-description')
+
+      await field.fill('new description 1')
+      await saveDocAndAssert(page, '#action-save-draft')
+
+      let newCount1: null | string
+
+      await expect(async () => {
+        newCount1 = await page.locator(versionsCountSelector).textContent()
+        expect(Number(newCount1)).toBeGreaterThan(Number(initialCount))
+      }).toPass({ timeout: 10000, intervals: [100] })
+
+      await field.fill('new description 2')
+      await saveDocAndAssert(page, '#action-save-draft')
+
+      let newCount2: null | string
+
+      await expect(async () => {
+        newCount2 = await page.locator(versionsCountSelector).textContent()
+        expect(Number(newCount2)).toBeGreaterThan(Number(newCount1))
+      }).toPass({ timeout: 10000, intervals: [100] })
+
+      await field.fill('new description 3')
+      await saveDocAndAssert(page, '#action-save-draft')
+
+      await expect(async () => {
+        const newCount3 = await page.locator(versionsCountSelector).textContent()
+        expect(Number(newCount3)).toBeGreaterThan(Number(newCount2))
+      }).toPass({ timeout: 10000, intervals: [100] })
+    })
+
     test('collection — respects max number of versions', async () => {
       const maxOneCollection = await payload.create({
         collection: draftWithMaxCollectionSlug,