From 126e112ec0806ec1b8fad2eab68c3677a07eec56 Mon Sep 17 00:00:00 2001 From: Dan Ribbens Date: Fri, 27 Dec 2019 17:17:25 -0500 Subject: [PATCH] revert changes meant to fix eslint errors that broke image file resizing --- src/uploads/images/imageResizer.js | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/uploads/images/imageResizer.js b/src/uploads/images/imageResizer.js index e583563b32..db9c15e4b4 100644 --- a/src/uploads/images/imageResizer.js +++ b/src/uploads/images/imageResizer.js @@ -12,31 +12,30 @@ function getOutputImageName(sourceImage, size) { } export async function resizeAndSave(config, uploadConfig, file) { + console.log(uploadConfig); const sourceImage = `${config.staticDir}/${file.name}`; const outputSizes = []; try { const dimensions = await sizeOf(sourceImage); - uploadConfig.imageSizes.map(async (desiredSize) => { + for (const desiredSize of uploadConfig.imageSizes) { if (desiredSize.width > dimensions.width) { - return; + continue; } - const outputImageName = getOutputImageName(sourceImage, desiredSize); - // eslint-disable-next-line no-await-in-loop + let outputImageName = getOutputImageName(sourceImage, desiredSize); await sharp(sourceImage) .resize(desiredSize.width, desiredSize.height, { - position: desiredSize.crop || 'centre', // would it make sense for this to be set by the uploader? + position: desiredSize.crop || 'centre' // would it make sense for this to be set by the uploader? }) .toFile(outputImageName); outputSizes.push({ name: desiredSize.name, height: desiredSize.height, - width: desiredSize.width, + width: desiredSize.width }); - }); + } } catch (e) { console.log('error in resize and save', e.message); } - console.log(outputSizes); return outputSizes; }