From 0c9fb098e017be53bf4de5b381570583ee7a66bb Mon Sep 17 00:00:00 2001 From: Jarrod Flesch Date: Mon, 16 Mar 2020 14:18:49 -0400 Subject: [PATCH] adds logic for preventDefault on Button --- src/client/components/controls/Button/index.js | 6 +++--- src/client/components/forms/Submit/index.js | 5 ++++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/client/components/controls/Button/index.js b/src/client/components/controls/Button/index.js index 8423b0091d..25b027c1dd 100644 --- a/src/client/components/controls/Button/index.js +++ b/src/client/components/controls/Button/index.js @@ -19,8 +19,8 @@ const Button = (props) => { ].filter(Boolean).join(' '); function handleClick(event) { - event.preventDefault(); - onClick(); + if (type !== 'submit' && onClick) event.preventDefault(); + if (onClick) onClick(); } const buttonProps = { @@ -53,8 +53,8 @@ const Button = (props) => { default: return ( diff --git a/src/client/components/forms/Submit/index.js b/src/client/components/forms/Submit/index.js index b91758acbb..84eee982f8 100644 --- a/src/client/components/forms/Submit/index.js +++ b/src/client/components/forms/Submit/index.js @@ -11,7 +11,10 @@ const FormSubmit = ({ children }) => { const formContext = useContext(FormContext); return (
-