From ade4c011d348249e975a1510ae481018834a2ca2 Mon Sep 17 00:00:00 2001 From: Dan Ribbens Date: Mon, 6 Feb 2023 16:43:16 -0500 Subject: [PATCH] fix: webpack css-loader resolve urls --- src/webpack/getDevConfig.ts | 7 ++++++- src/webpack/getProdConfig.ts | 7 ++++++- test/admin/placeholder.png | Bin 0 -> 131 bytes test/admin/styles.scss | 1 + 4 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 test/admin/placeholder.png diff --git a/src/webpack/getDevConfig.ts b/src/webpack/getDevConfig.ts index 04fee35b30..dbc7d754f4 100644 --- a/src/webpack/getDevConfig.ts +++ b/src/webpack/getDevConfig.ts @@ -39,7 +39,12 @@ export default (payloadConfig: SanitizedConfig): Configuration => { sideEffects: true, use: [ require.resolve('style-loader'), - require.resolve('css-loader'), + { + loader: require.resolve('css-loader'), + options: { + url: (url) => (!url.startsWith('/')), + }, + }, { loader: require.resolve('postcss-loader'), options: { diff --git a/src/webpack/getProdConfig.ts b/src/webpack/getProdConfig.ts index 102c7a2fba..215ae19f30 100644 --- a/src/webpack/getProdConfig.ts +++ b/src/webpack/getProdConfig.ts @@ -48,7 +48,12 @@ export default (payloadConfig: SanitizedConfig): Configuration => { sideEffects: true, use: [ MiniCSSExtractPlugin.loader, - require.resolve('css-loader'), + { + loader: require.resolve('css-loader'), + options: { + url: (url) => (!url.startsWith('/')), + }, + }, { loader: require.resolve('postcss-loader'), options: { diff --git a/test/admin/placeholder.png b/test/admin/placeholder.png new file mode 100644 index 0000000000000000000000000000000000000000..988d38ebbb97a0c4567b936f5bd1bd4a2592841a GIT binary patch literal 131 zcmeAS@N?(olHy`uVBq!ia0vp^5+KaM1|%Pp+x`GjjKx9jP7LeL$-D$|SkfJR9T^xl z_H+M9WCij$3p^r=85sBufiR<}hF1enP{Py2F~r0B?LkIHAg@W`|N3=`4h#%2yqppY Uj2D=qzopr00Ju=cmMzZ literal 0 HcmV?d00001 diff --git a/test/admin/styles.scss b/test/admin/styles.scss index 85b0ab6e37..35121b5c56 100644 --- a/test/admin/styles.scss +++ b/test/admin/styles.scss @@ -1,5 +1,6 @@ .nav__controls { font-family: monospace; + background-image: url('/placeholder.png'); } .nav__controls:before { content: 'custom-css';