Revert "fix: issues creating the first user (#5986)"

This reverts commit 0ede95f375.

test/auth/config.ts

@@ -216,31 +216,29 @@ export default buildConfigWithDefaults({
     },
   ],
   onInit: async (payload) => {
-    if (process.env.SKIP_ON_INIT !== 'true') {
-      await payload.create({
-        collection: 'users',
-        data: {
-          custom: 'Hello, world!',
-          email: devUser.email,
-          password: devUser.password,
-        },
-      })
+    await payload.create({
+      collection: 'users',
+      data: {
+        custom: 'Hello, world!',
+        email: devUser.email,
+        password: devUser.password,
+      },
+    })
 
-      await payload.create({
-        collection: 'api-keys',
-        data: {
-          apiKey: uuid(),
-          enableAPIKey: true,
-        },
-      })
+    await payload.create({
+      collection: 'api-keys',
+      data: {
+        apiKey: uuid(),
+        enableAPIKey: true,
+      },
+    })
 
-      await payload.create({
-        collection: 'api-keys',
-        data: {
-          apiKey: uuid(),
-          enableAPIKey: true,
-        },
-      })
-    }
+    await payload.create({
+      collection: 'api-keys',
+      data: {
+        apiKey: uuid(),
+        enableAPIKey: true,
+      },
+    })
   },
 })

test/auth/e2e.spec.ts

@@ -1,16 +1,13 @@
 import type { Page } from '@playwright/test'
 
 import { expect, test } from '@playwright/test'
-import { devUser } from 'credentials.js'
 import path from 'path'
-import { wait } from 'payload/utilities'
 import { fileURLToPath } from 'url'
-import { v4 as uuid } from 'uuid'
 
 import type { PayloadTestSDK } from '../helpers/sdk/index.js'
 import type { Config } from './payload-types.js'
 
-import { initPageConsoleErrorCatch, saveDocAndAssert } from '../helpers.js'
+import { initPageConsoleErrorCatch, login, saveDocAndAssert } from '../helpers.js'
 import { AdminUrlUtil } from '../helpers/adminUrlUtil.js'
 import { initPayloadE2ENoConfig } from '../helpers/initPayloadE2ENoConfig.js'
 import { POLL_TOPASS_TIMEOUT } from '../playwright.config.js'
@@ -21,37 +18,25 @@ const dirname = path.dirname(filename)
 
 let payload: PayloadTestSDK<Config>
 
+/**
+ * TODO: Auth
+ *   create first user
+ *   unlock
+ *   log out
+ */
+
 const { beforeAll, describe } = test
 
 const headers = {
   'Content-Type': 'application/json',
 }
 
-const createFirstUser = async ({ page, serverURL }: { page: Page; serverURL: string }) => {
-  await page.goto(serverURL + '/admin/create-first-user')
-  await page.locator('#field-email').fill(devUser.email)
-  await page.locator('#field-password').fill(devUser.password)
-  await page.locator('#field-confirm-password').fill(devUser.password)
-  await page.locator('#field-custom').fill('Hello, world!')
-
-  await wait(500)
-
-  await page.locator('.form-submit > button').click()
-
-  await expect
-    .poll(() => page.url(), { timeout: POLL_TOPASS_TIMEOUT })
-    .not.toContain('create-first-user')
-}
-
 describe('auth', () => {
   let page: Page
   let url: AdminUrlUtil
   let serverURL: string
   let apiURL: string
 
-  // Allows for testing create-first-user
-  process.env.SKIP_ON_INIT = 'true'
-
   beforeAll(async ({ browser }) => {
     ;({ payload, serverURL } = await initPayloadE2ENoConfig<Config>({ dirname }))
     apiURL = `${serverURL}/api`
@@ -61,22 +46,11 @@ describe('auth', () => {
     page = await context.newPage()
     initPageConsoleErrorCatch(page)
 
-    await createFirstUser({ page, serverURL })
+    //await delayNetwork({ context, page, delay: 'Slow 4G' })
 
-    await payload.create({
-      collection: 'api-keys',
-      data: {
-        apiKey: uuid(),
-        enableAPIKey: true,
-      },
-    })
-
-    await payload.create({
-      collection: 'api-keys',
-      data: {
-        apiKey: uuid(),
-        enableAPIKey: true,
-      },
+    await login({
+      page,
+      serverURL,
     })
   })