fix: wrap fs calls with when, linting

src/commands/registration/appe.js

@@ -7,4 +7,4 @@ module.exports = {
   },
   syntax: '{{cmd}} [path]',
   description: 'Append to a file'
-}
+};

src/commands/registration/auth.js

@@ -16,7 +16,7 @@ module.exports = {
   flags: {
     no_auth: true
   }
-}
+};
 
 function handleTLS() {
   return this.reply(504);

src/commands/registration/cdup.js

@@ -2,10 +2,10 @@ const cwd = require('./cwd').handler;
 
 module.exports = {
   directive: ['CDUP', 'XCUP'],
-  handler: function(args) {
+  handler: function (args) {
     args.command._ = [args.command._[0], '..'];
     return cwd.call(this, args);
   },
   syntax: '{{cmd}}',
   description: 'Change to Parent Directory'
-}
+};

src/commands/registration/cwd.js

@@ -7,7 +7,7 @@ module.exports = {
     if (!this.fs) return this.reply(550, 'File system not instantiated');
     if (!this.fs.chdir) return this.reply(402, 'Not supported by file system');
 
-    return when(this.fs.chdir(command._[1]))
+    return when.try(this.fs.chdir.bind(this.fs), command._[1])
     .then(cwd => {
       const path = cwd ? `"${escapePath(cwd)}"` : undefined;
       return this.reply(250, path);
@@ -19,4 +19,4 @@ module.exports = {
   },
   syntax: '{{cmd}}[path]',
   description: 'Change working directory'
-}
+};

src/commands/registration/dele.js

@@ -6,7 +6,7 @@ module.exports = {
     if (!this.fs) return this.reply(550, 'File system not instantiated');
     if (!this.fs.delete) return this.reply(402, 'Not supported by file system');
 
-    return when(this.fs.delete(command._[1]))
+    return when.try(this.fs.delete.bind(this.fs), command._[1])
     .then(() => {
       return this.reply(250);
     })
@@ -17,4 +17,4 @@ module.exports = {
   },
   syntax: '{{cmd}} [path]',
   description: 'Delete file'
-}
+};

src/commands/registration/feat.js

@@ -18,4 +18,4 @@ module.exports = {
   flags: {
     no_auth: true
   }
-}
+};

src/commands/registration/help.js

@@ -21,4 +21,4 @@ module.exports = {
   flags: {
     no_auth: true
   }
-}
+};

src/commands/registration/list.js

@@ -6,7 +6,7 @@ const getFileStat = require('../../helpers/file-stat');
 // http://cr.yp.to/ftp/list/eplf.html
 module.exports = {
   directive: 'LIST',
-  handler: function ({log, command, previous_command} = {}) {
+  handler: function ({log, command} = {}) {
     if (!this.fs) return this.reply(550, 'File system not instantiated');
     if (!this.fs.list) return this.reply(402, 'Not supported by file system');
 
@@ -19,9 +19,9 @@ module.exports = {
       this.commandSocket.pause();
       dataSocket = socket;
     })
-    .then(() => when(this.fs.list(directory)))
+    .then(() => when.try(this.fs.list.bind(this.fs), directory))
     .then(files => {
-      const getFileMessage = (file) => {
+      const getFileMessage = file => {
         if (simple) return file.name;
         return getFileStat(file, _.get(this, 'server.options.file_format', 'ls'));
       };
@@ -33,7 +33,7 @@ module.exports = {
           message,
           socket: dataSocket
         };
-      })
+      });
       return this.reply(150)
       .then(() => {
         if (fileList.length) return this.reply({}, ...fileList);
@@ -57,4 +57,4 @@ module.exports = {
   },
   syntax: '{{cmd}} [path(optional)]',
   description: 'Returns information of a file or directory if specified, else information of the current working directory is returned'
-}
+};

src/commands/registration/mdtm.js

@@ -7,10 +7,10 @@ module.exports = {
     if (!this.fs) return this.reply(550, 'File system not instantiated');
     if (!this.fs.get) return this.reply(402, 'Not supported by file system');
 
-    return when(this.fs.get(command._[1]))
+    return when.try(this.fs.get.bind(this.fs), command._[1])
     .then(fileStat => {
       const modificationTime = format(fileStat.mtime, 'YYYYMMDDHHmmss.SSS');
-      return this.reply(213, modificationTime)
+      return this.reply(213, modificationTime);
     })
     .catch(err => {
       log.error(err);
@@ -22,4 +22,4 @@ module.exports = {
   flags: {
     feat: 'MDTM'
   }
-}
+};

src/commands/registration/mkd.js

@@ -7,7 +7,7 @@ module.exports = {
     if (!this.fs) return this.reply(550, 'File system not instantiated');
     if (!this.fs.mkdir) return this.reply(402, 'Not supported by file system');
 
-    return when(this.fs.mkdir(command._[1]))
+    return when.try(this.fs.mkdir.bind(this.fs), command._[1])
     .then(dir => {
       const path = dir ? `"${escapePath(dir)}"` : undefined;
       return this.reply(257, path);
@@ -19,4 +19,4 @@ module.exports = {
   },
   syntax: '{{cmd}}[path]',
   description: 'Make directory'
-}
+};

src/commands/registration/mode.js

@@ -8,4 +8,4 @@ module.exports = {
   flags: {
     obsolete: true
   }
-}
+};

src/commands/registration/nlst.js

@@ -7,4 +7,4 @@ module.exports = {
   },
   syntax: '{{cmd}} [path(optional)]',
   description: 'Returns a list of file names in a specified directory'
-}
+};

src/commands/registration/noop.js

@@ -8,4 +8,4 @@ module.exports = {
   flags: {
     no_auth: true
   }
-}
+};

src/commands/registration/opts.js

@@ -5,4 +5,4 @@ module.exports = {
   },
   syntax: '{{cmd}}',
   description: 'Select options for a feature'
-}
+};

src/commands/registration/pass.js

@@ -24,4 +24,4 @@ module.exports = {
   flags: {
     no_auth: true
   }
-}
+};

src/commands/registration/pasv.js

@@ -2,7 +2,7 @@ const PassiveConnector = require('../../connector/passive');
 
 module.exports = {
   directive: 'PASV',
-  handler: function ({command} = {}) {
+  handler: function () {
     this.connector = new PassiveConnector(this);
     return this.connector.setupServer()
     .then(server => {
@@ -17,4 +17,4 @@ module.exports = {
   },
   syntax: '{{cmd}}',
   description: 'Initiate passive mode'
-}
+};

src/commands/registration/port.js

@@ -12,10 +12,10 @@ module.exports = {
     const port = portBytes[0] * 256 + portBytes[1];
 
     return this.connector.setupConnection(ip, port)
-    .then(socket => {
+    .then(() => {
       return this.reply(200);
-    })
+    });
   },
   syntax: '{{cmd}} [x,x,x,x,y,y]',
   description: 'Specifies an address and port to which the server should connect'
-}
+};

src/commands/registration/pwd.js

@@ -3,11 +3,11 @@ const escapePath = require('../../helpers/escape-path');
 
 module.exports = {
   directive: ['PWD', 'XPWD'],
-  handler: function ({log, command} = {}) {
+  handler: function ({log} = {}) {
     if (!this.fs) return this.reply(550, 'File system not instantiated');
     if (!this.fs.currentDirectory) return this.reply(402, 'Not supported by file system');
 
-    return when(this.fs.currentDirectory())
+    return when.try(this.fs.currentDirectory.bind(this.fs))
     .then(cwd => {
       const path = cwd ? `"${escapePath(cwd)}"` : undefined;
       return this.reply(257, path);
@@ -15,8 +15,8 @@ module.exports = {
     .catch(err => {
       log.error(err);
       return this.reply(550, err.message);
-    })
+    });
   },
   syntax: '{{cmd}}',
   description: 'Print current working directory'
-}
+};

src/commands/registration/quit.js

@@ -8,4 +8,4 @@ module.exports = {
   flags: {
     no_auth: true
   }
-}
+};

src/commands/registration/retr.js

@@ -12,7 +12,7 @@ module.exports = {
       this.commandSocket.pause();
       dataSocket = socket;
     })
-    .then(() => when(this.fs.read(command._[1])))
+    .then(() => when.try(this.fs.read.bind(this.fs), command._[1]))
     .then(stream => {
       return when.promise((resolve, reject) => {
         dataSocket.on('error', err => stream.emit('error', err));
@@ -34,8 +34,8 @@ module.exports = {
     .finally(() => {
       this.connector.end();
       this.commandSocket.resume();
-    })
+    });
   },
   syntax: '{{cmd}} [path]',
   description: 'Retrieve a copy of the file'
-}
+};

src/commands/registration/rmd.js

@@ -7,4 +7,4 @@ module.exports = {
   },
   syntax: '{{cmd}} [path]',
   description: 'Remove a directory'
-}
+};

src/commands/registration/rnfr.js

@@ -7,7 +7,7 @@ module.exports = {
     if (!this.fs.get) return this.reply(402, 'Not supported by file system');
 
     const fileName = command._[1];
-    return when(this.fs.get(fileName))
+    return when.try(this.fs.get.bind(this.fs), fileName)
     .then(() => {
       this.renameFrom = fileName;
       return this.reply(350);

src/commands/registration/rnto.js

@@ -11,7 +11,7 @@ module.exports = {
     const from = this.renameFrom;
     const to = command._[1];
 
-    return when(this.fs.rename(from, to))
+    return when.try(this.fs.rename.bind(this.fs), from, to)
     .then(() => {
       return this.reply(250);
     })
@@ -21,8 +21,8 @@ module.exports = {
     })
     .finally(() => {
       delete this.renameFrom;
-    })
+    });
   },
   syntax: '{{cmd}} [name]',
   description: 'Rename to'
-}
+};

src/commands/registration/site/chmod.js

@@ -10,5 +10,5 @@ module.exports = function ({log, command} = {}) {
   .catch(err => {
     log.error(err);
     return this.reply(500);
-  })
+  });
 };

src/commands/registration/site/index.js

@@ -14,10 +14,10 @@ module.exports = {
     const subCommand = {
       _: [subverb, ...subparameters],
       directive: subverb
-    }
+    };
     const handler = registry[subverb].handler.bind(this);
     return when.try(handler, { log: subLog, command: subCommand });
   },
   syntax: '{{cmd}} [subVerb] [subParams]',
   description: 'Sends site specific commands to remote server'
-}
+};

src/commands/registration/size.js

@@ -6,7 +6,7 @@ module.exports = {
     if (!this.fs) return this.reply(550, 'File system not instantiated');
     if (!this.fs.get) return this.reply(402, 'Not supported by file system');
 
-    return when(this.fs.get(command._[1]))
+    return when.try(this.fs.get.bind(this.fs), command._[1])
     .then(fileStat => {
       return this.reply(213, {message: fileStat.size});
     })
@@ -20,4 +20,4 @@ module.exports = {
   flags: {
     feat: 'SIZE'
   }
-}
+};

src/commands/registration/stat.js

@@ -6,15 +6,17 @@ module.exports = {
   directive: 'STAT',
   handler: function (args = {}) {
     const {log, command} = args;
-    const path = command._[1];
+    const path = _.get(command, '_[1]');
     if (path) {
       if (!this.fs) return this.reply(550, 'File system not instantiated');
       if (!this.fs.get) return this.reply(402, 'Not supported by file system');
 
-      return when(this.fs.get(path))
+      return when.try(this.fs.get.bind(this.fs), path)
       .then(stat => {
         if (stat.isDirectory()) {
-          return when(this.fs.list(path))
+          if (!this.fs.list) return this.reply(402, 'Not supported by file system');
+
+          return when.try(this.fs.list.bind(this.fs), path)
           .then(files => {
             const fileList = files.map(file => {
               const message = getFileStat(file, _.get(this, 'server.options.file_format', 'ls'));
@@ -22,21 +24,21 @@ module.exports = {
                 raw: true,
                 message
               };
-            })
+            });
             return this.reply(213, 'Status begin', ...fileList, 'Status end');
-          })
+          });
         } else {
-          return this.reply(212, getFileStat(stat, _.get(this, 'server.options.file_format', 'ls')))
+          return this.reply(212, getFileStat(stat, _.get(this, 'server.options.file_format', 'ls')));
         }
       })
       .catch(err => {
         log.error(err);
         return this.reply(450);
-      })
+      });
     } else {
       return this.reply(211, 'Status OK');
     }
   },
   syntax: '{{cmd}} [path(optional)]',
   description: 'Returns the current status'
-}
+};

src/commands/registration/stor.js

@@ -15,7 +15,7 @@ module.exports = {
       this.commandSocket.pause();
       dataSocket = socket;
     })
-    .then(() => when(this.fs.write(fileName, {append})))
+    .then(() => when.try(this.fs.write.bind(this.fs), fileName, {append}))
     .then(stream => {
       return when.promise((resolve, reject) => {
         stream.on('error', err => dataSocket.emit('error', err));
@@ -41,4 +41,4 @@ module.exports = {
   },
   syntax: '{{cmd}} [path]',
   description: 'Store data as a file at the server site'
-}
+};

src/commands/registration/stou.js

@@ -1,3 +1,5 @@
+const when = require('when');
+
 const stor = require('./stor').handler;
 
 module.exports = {
@@ -7,9 +9,11 @@ module.exports = {
     if (!this.fs.get || !this.fs.getUniqueName) return this.reply(402, 'Not supported by file system');
 
     const fileName = args.command._[1];
-    return this.fs.get(fileName)
+    return when.try(() => {
-    .catch(() => fileName)                // does not exist, name is unique
+      return when.try(this.fs.get.bind(this.fs), fileName)
-    .then(() => this.fs.getUniqueName())  // exists, must create new unique name
+      .then(() => when.try(this.fs.getUniqueName.bind(this.fs)))
+      .catch(() => when.resolve(fileName));
+    })
     .then(name => {
       args.command._[1] = name;
       return stor.call(this, args);

src/commands/registration/stru.js

@@ -8,4 +8,4 @@ module.exports = {
   flags: {
     obsolete: true
   }
-}
+};

src/commands/registration/syst.js

@@ -8,4 +8,4 @@ module.exports = {
   flags: {
     no_auth: true
   }
-}
+};

src/commands/registration/user.js

@@ -2,7 +2,10 @@ module.exports = {
   directive: 'USER',
   handler: function ({log, command} = {}) {
     if (this.username) return this.reply(530, 'Username already set');
+
     this.username = command._[1];
+    if (!this.username) return this.reply(501, 'Must send username requirement');
+
     if (this.server.options.anonymous === true) {
       return this.login(this.username, '@anonymous')
       .then(() => {
@@ -20,4 +23,4 @@ module.exports = {
   flags: {
     no_auth: true
   }
-}
+};

src/commands/registry.js

@@ -1,3 +1,4 @@
+/* eslint no-return-assign: 0 */
 const commands = [
   require('./registration/abor'),
   require('./registration/allo'),