fix: Do not print Optional(...) when rendering arrays (#205)

This commit is contained in:
Ilya Puchka
2018-04-05 01:13:34 +01:00
committed by Kyle Fuller
parent 8fa0bd275c
commit 29e859f1aa
3 changed files with 25 additions and 1 deletions

View File

@@ -21,6 +21,7 @@
- Fixed comparing string variables with string literals, in Swift 4 string literals became `Substring` and thus couldn't be directly compared to strings. - Fixed comparing string variables with string literals, in Swift 4 string literals became `Substring` and thus couldn't be directly compared to strings.
- Integer literals now resolve into Int values, not Float - Integer literals now resolve into Int values, not Float
- Fixed accessing properties of optional properties via reflection - Fixed accessing properties of optional properties via reflection
- No longer render optional values in arrays as `Optional(..)`
## 0.10.1 ## 0.10.1

View File

@@ -78,6 +78,8 @@ public class VariableNode : NodeType {
func stringify(_ result: Any?) -> String { func stringify(_ result: Any?) -> String {
if let result = result as? String { if let result = result as? String {
return result return result
} else if let array = result as? [Any?] {
return unwrap(array).description
} else if let result = result as? CustomStringConvertible { } else if let result = result as? CustomStringConvertible {
return result.description return result.description
} else if let result = result as? NSObject { } else if let result = result as? NSObject {
@@ -86,3 +88,16 @@ func stringify(_ result: Any?) -> String {
return "" return ""
} }
func unwrap(_ array: [Any?]) -> [Any] {
return array.map { (item: Any?) -> Any in
if let item = item {
if let items = item as? [Any?] {
return unwrap(items)
} else {
return item
}
}
else { return item as Any }
}
}

View File

@@ -148,7 +148,7 @@ func testVariable() {
try expect(result) == "Foo" try expect(result) == "Foo"
} }
#endif #endif
$0.it("can resolve a value via reflection") { $0.it("can resolve a value via reflection") {
let variable = Variable("blog.articles.0.author.name") let variable = Variable("blog.articles.0.author.name")
let result = try variable.resolve(context) as? String let result = try variable.resolve(context) as? String
@@ -167,5 +167,13 @@ func testVariable() {
try expect(result) == "Jhon" try expect(result) == "Jhon"
} }
$0.it("does not render Optional") {
var array: [Any?] = [1, nil]
array.append(array)
let context = Context(dictionary: ["values": array])
try expect(VariableNode(variable: "values").render(context)) == "[1, nil, [1, nil]]"
try expect(VariableNode(variable: "values.1").render(context)) == ""
}
} }
} }