Rename roles

Allow roles to be renamed without having to manually stop the old
containers.

If you have config like:

```
servers:
  jobs:
    hosts:
      - vm3
```

And you want to rename `jobs` to `workers`, you can do:

```
servers:
  workers:
    previously:
      - jobs
    hosts:
      - vm3
```

And the deployment will take care of stopping the old "jobs" containers.

Once deployed you can remove the `previously` key.

.github/workflows/ci.yml

@@ -24,15 +24,25 @@ jobs:
     strategy:
       matrix:
         ruby-version:
+          - "2.7"
           - "3.1"
           - "3.2"
           - "3.3"
         gemfile:
           - Gemfile
+          - gemfiles/ruby_2.7.gemfile
           - gemfiles/rails_edge.gemfile
         exclude:
-          - ruby-version: "3.1"
+          - ruby-version: "2.7"
+            gemfile: Gemfile
+          - ruby-version: "2.7"
             gemfile: gemfiles/rails_edge.gemfile
+          - ruby-version: "3.1"
+            gemfile: gemfiles/ruby_2.7.gemfile
+          - ruby-version: "3.2"
+            gemfile: gemfiles/ruby_2.7.gemfile
+          - ruby-version: "3.3"
+            gemfile: gemfiles/ruby_2.7.gemfile
     name: ${{ format('Tests (Ruby {0})', matrix.ruby-version) }}
     runs-on: ubuntu-latest
     continue-on-error: true

Dockerfile

@@ -14,7 +14,7 @@ COPY Gemfile Gemfile.lock kamal.gemspec ./
 COPY lib/kamal/version.rb /kamal/lib/kamal/version.rb
 
 # Install system dependencies
-RUN apk add --no-cache build-base git docker openrc openssh-client-default \
+RUN apk add --no-cache --update build-base git docker openrc openssh-client-default \
     && rc-update add docker boot \
     && gem install bundler --version=2.4.3 \
     && bundle install
@@ -33,7 +33,7 @@ WORKDIR /workdir
 
 # Tell git it's safe to access /workdir/.git even if
 # the directory is owned by a different user
-RUN git config --global --add safe.directory '*'
+RUN git config --global --add safe.directory /workdir
 
 # Set the entrypoint to run the installed binary in /workdir
 # Example:  docker run -it -v "$PWD:/workdir" kamal init

Gemfile.lock

@@ -1,24 +1,24 @@
 PATH
   remote: .
   specs:
-    kamal (2.2.0)
+    kamal (1.5.0)
       activesupport (>= 7.0)
       base64 (~> 0.2)
       bcrypt_pbkdf (~> 1.0)
       concurrent-ruby (~> 1.2)
-      dotenv (~> 3.1)
+      dotenv (~> 2.8)
       ed25519 (~> 1.2)
       net-ssh (~> 7.0)
-      sshkit (>= 1.23.0, < 2.0)
+      sshkit (~> 1.21)
-      thor (~> 1.3)
+      thor (~> 1.2)
       zeitwerk (~> 2.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (7.1.3.4)
+    actionpack (7.1.2)
-      actionview (= 7.1.3.4)
+      actionview (= 7.1.2)
-      activesupport (= 7.1.3.4)
+      activesupport (= 7.1.2)
       nokogiri (>= 1.8.5)
       racc
       rack (>= 2.2.4)
@@ -26,13 +26,13 @@ GEM
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    actionview (7.1.3.4)
+    actionview (7.1.2)
-      activesupport (= 7.1.3.4)
+      activesupport (= 7.1.2)
       builder (~> 3.1)
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    activesupport (7.1.3.4)
+    activesupport (7.1.2)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -44,55 +44,52 @@ GEM
       tzinfo (~> 2.0)
     ast (2.4.2)
     base64 (0.2.0)
-    bcrypt_pbkdf (1.1.1)
+    bcrypt_pbkdf (1.1.0)
-    bcrypt_pbkdf (1.1.1-arm64-darwin)
+    bigdecimal (3.1.5)
-    bcrypt_pbkdf (1.1.1-x86_64-darwin)
+    builder (3.2.4)
-    bigdecimal (3.1.8)
+    concurrent-ruby (1.2.2)
-    builder (3.3.0)
-    concurrent-ruby (1.3.3)
     connection_pool (2.4.1)
     crass (1.0.6)
-    debug (1.9.2)
+    debug (1.9.1)
       irb (~> 1.10)
       reline (>= 0.3.8)
-    dotenv (3.1.2)
+    dotenv (2.8.1)
-    drb (2.2.1)
+    drb (2.2.0)
+      ruby2_keywords
     ed25519 (1.3.0)
-    erubi (1.13.0)
+    erubi (1.12.0)
-    i18n (1.14.5)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    io-console (0.7.2)
+    io-console (0.7.1)
-    irb (1.14.0)
+    irb (1.11.0)
-      rdoc (>= 4.0.0)
+      rdoc
-      reline (>= 0.4.2)
+      reline (>= 0.3.8)
-    json (2.7.2)
+    json (2.7.1)
     language_server-protocol (3.17.0.3)
     loofah (2.22.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
-    minitest (5.24.1)
+    minitest (5.20.0)
-    mocha (2.4.5)
+    mocha (2.1.0)
       ruby2_keywords (>= 0.0.5)
     mutex_m (0.2.0)
     net-scp (4.0.0)
       net-ssh (>= 2.6.5, < 8.0.0)
-    net-sftp (4.0.0)
+    net-ssh (7.2.1)
-      net-ssh (>= 5.0.0, < 8.0.0)
+    nokogiri (1.16.0-arm64-darwin)
-    net-ssh (7.2.3)
-    nokogiri (1.16.7-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.16.7-x86_64-darwin)
+    nokogiri (1.16.0-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.16.7-x86_64-linux)
+    nokogiri (1.16.0-x86_64-linux)
       racc (~> 1.4)
-    parallel (1.25.1)
+    parallel (1.24.0)
-    parser (3.3.4.0)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
       racc
     psych (5.1.2)
       stringio
-    racc (1.8.1)
+    racc (1.7.3)
-    rack (3.1.7)
+    rack (3.0.8)
     rack-session (2.0.0)
       rack (>= 3.0.0)
     rack-test (2.1.0)
@@ -107,43 +104,42 @@ GEM
     rails-html-sanitizer (1.6.0)
       loofah (~> 2.21)
       nokogiri (~> 1.14)
-    railties (7.1.3.4)
+    railties (7.1.2)
-      actionpack (= 7.1.3.4)
+      actionpack (= 7.1.2)
-      activesupport (= 7.1.3.4)
+      activesupport (= 7.1.2)
       irb
       rackup (>= 1.0.0)
       rake (>= 12.2)
       thor (~> 1.0, >= 1.2.2)
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
-    rake (13.2.1)
+    rake (13.1.0)
-    rdoc (6.7.0)
+    rdoc (6.6.2)
       psych (>= 4.0.0)
-    regexp_parser (2.9.2)
+    regexp_parser (2.9.0)
-    reline (0.5.9)
+    reline (0.4.2)
       io-console (~> 0.5)
-    rexml (3.3.4)
+    rexml (3.2.6)
-      strscan
+    rubocop (1.62.1)
-    rubocop (1.65.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 2.4, < 3.0)
+      regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
       rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.32.0)
+    rubocop-ast (1.31.2)
-      parser (>= 3.3.1.0)
+      parser (>= 3.3.0.4)
-    rubocop-minitest (0.35.1)
+    rubocop-minitest (0.35.0)
       rubocop (>= 1.61, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-performance (1.21.1)
+    rubocop-performance (1.20.2)
       rubocop (>= 1.48.1, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
-    rubocop-rails (2.25.1)
+    rubocop-rails (2.24.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
@@ -155,19 +151,17 @@ GEM
       rubocop-rails
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
-    sshkit (1.23.0)
+    sshkit (1.21.7)
-      base64
+      mutex_m
       net-scp (>= 1.1.2)
-      net-sftp (>= 2.1.2)
       net-ssh (>= 2.8.0)
-    stringio (3.1.1)
+    stringio (3.1.0)
-    strscan (3.1.0)
+    thor (1.3.0)
-    thor (1.3.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.5.0)
     webrick (1.8.1)
-    zeitwerk (2.6.17)
+    zeitwerk (2.6.12)
 
 PLATFORMS
   arm64-darwin

README.md

@@ -1,6 +1,6 @@
 # Kamal: Deploy web apps anywhere
 
-From bare metal to cloud VMs, deploy web apps anywhere with zero downtime. Kamal uses [kamal-proxy](https://github.com/basecamp/kamal-proxy) to seamlessly switch requests between containers. Works seamlessly across multiple servers, using SSHKit to execute commands. Originally built for Rails apps, Kamal will work with any type of web app that can be containerized with Docker.
+From bare metal to cloud VMs, deploy web apps anywhere with zero downtime. Kamal has the dynamic reverse-proxy Traefik hold requests while a new app container is started and the old one is stopped. Works seamlessly across multiple hosts, using SSHKit to execute commands. Originally built for Rails apps, Kamal will work with any type of web app that can be containerized with Docker.
 
 ➡️ See [kamal-deploy.org](https://kamal-deploy.org) for documentation on [installation](https://kamal-deploy.org/docs/installation), [configuration](https://kamal-deploy.org/docs/configuration), and [commands](https://kamal-deploy.org/docs/commands).
 

bin/docs

@@ -1,141 +0,0 @@
-#!/usr/bin/env ruby
-require "stringio"
-
-def usage
-  puts "Usage: #{$0} <kamal_site_repo>"
-  exit 1
-end
-
-usage if ARGV.size != 1
-
-kamal_site_repo = ARGV[0]
-
-if !File.directory?(kamal_site_repo)
-  puts "Error: #{kamal_site_repo} is not a directory"
-  exit 1
-end
-
-DOCS = {
-  "accessory" => "Accessories",
-  "alias" => "Aliases",
-  "boot" => "Booting",
-  "builder" => "Builders",
-  "configuration" => "Configuration overview",
-  "env" => "Environment variables",
-  "logging" => "Logging",
-  "proxy" => "Proxy",
-  "registry" => "Docker Registry",
-  "role" => "Roles",
-  "servers" => "Servers",
-  "ssh" => "SSH",
-  "sshkit" => "SSHKit"
-}
-DOCS_PATH = "lib/kamal/configuration/docs"
-
-class DocWriter
-  attr_reader :from_file, :to_file, :key, :heading, :body, :output, :in_yaml
-
-  def initialize(from_file, to_dir)
-    @from_file = from_file
-    @key = File.basename(from_file, ".yml")
-    @to_file = File.join(to_dir, "#{linkify(DOCS[key])}.md")
-    @body = File.readlines(from_file)
-    @heading = body.shift.chomp("\n")
-    @output = nil
-  end
-
-  def write
-    puts "Writing #{to_file}"
-    generate_markdown
-    File.write(to_file, output.string)
-  end
-
-  private
-    def generate_markdown
-      @output = StringIO.new
-
-      generate_header
-
-      place = :in_section
-
-      loop do
-        line = body.shift&.chomp("\n")
-        break if line.nil?
-
-        case place
-        when :new_section, :in_section
-          if line.empty?
-            output.puts
-            place = :new_section
-          elsif line =~ /^ *#/
-            generate_line(line, heading: place == :new_section)
-            place = :in_section
-          else
-            output.puts
-            output.puts "```yaml"
-            output.puts line
-            place = :in_yaml
-          end
-        when :in_yaml, :in_empty_line_yaml
-          if line =~ /^ *#/
-            output.puts "```"
-            output.puts
-            generate_line(line, heading: place == :in_empty_line_yaml)
-            place = :in_section
-          elsif line.empty?
-            place = :in_empty_line_yaml
-          else
-            output.puts line
-          end
-        end
-      end
-
-      output.puts "```" if place == :in_yaml
-    end
-
-    def generate_header
-      output.puts "---"
-      output.puts "# This file has been generated from the Kamal source, do not edit directly."
-      output.puts "# Find the source of this file at #{DOCS_PATH}/#{key}.yml in the Kamal repository."
-      output.puts "title: #{heading[2..-1]}"
-      output.puts "---"
-      output.puts
-      output.puts heading
-    end
-
-    def generate_line(line, heading: false)
-      line = line.gsub(/^ *#\s?/, "")
-
-      if line =~ /(.*)kamal docs ([a-z]*)(.*)/
-        line = "#{$1}[#{DOCS[$2]}](../#{linkify(DOCS[$2])})#{$3}"
-      end
-
-      if line =~ /(.*)https:\/\/kamal-deploy.org([a-z\/-]*)(.*)/
-        line = "#{$1}[#{titlify($2.split("/").last)}](#{$2})#{$3}"
-      end
-
-      if heading
-        output.puts "## [#{line}](##{linkify(line)})"
-      else
-        output.puts line
-      end
-    end
-
-    def linkify(text)
-      if text == "Configuration overview"
-        "overview"
-      else
-        text.downcase.gsub(" ", "-")
-      end
-    end
-
-    def titlify(text)
-      text.capitalize.gsub("-", " ")
-    end
-end
-
-from_dir = File.join(File.dirname(__FILE__), "../#{DOCS_PATH}")
-to_dir = File.join(kamal_site_repo, "docs/configuration")
-Dir.glob("#{from_dir}/*") do |from_file|
-  DocWriter.new(from_file, to_dir).write
-end

gemfiles/ruby_2.7.gemfile

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+git_source(:github) { |repo| "https://github.com/#{repo}.git" }
+
+gemspec path: "../"
+
+gem "nokogiri", "~> 1.15.0"

kamal.gemspec

@@ -12,10 +12,10 @@ Gem::Specification.new do |spec|
   spec.executables = %w[ kamal ]
 
   spec.add_dependency "activesupport", ">= 7.0"
-  spec.add_dependency "sshkit", ">= 1.23.0", "< 2.0"
+  spec.add_dependency "sshkit", "~> 1.21"
   spec.add_dependency "net-ssh", "~> 7.0"
-  spec.add_dependency "thor", "~> 1.3"
+  spec.add_dependency "thor", "~> 1.2"
-  spec.add_dependency "dotenv", "~> 3.1"
+  spec.add_dependency "dotenv", "~> 2.8"
   spec.add_dependency "zeitwerk", "~> 2.5"
   spec.add_dependency "ed25519", "~> 1.2"
   spec.add_dependency "bcrypt_pbkdf", "~> 1.0"

lib/kamal.rb

@@ -1,14 +1,10 @@
 module Kamal
-  class ConfigurationError < StandardError; end
 end
 
 require "active_support"
 require "zeitwerk"
-require "yaml"
-require "tmpdir"
-require "pathname"
 
 loader = Zeitwerk::Loader.for_gem
 loader.ignore(File.join(__dir__, "kamal", "sshkit_with_ext.rb"))
 loader.setup
-loader.eager_load_namespace(Kamal::Cli) # We need all commands loaded.
+loader.eager_load # We need all commands loaded.

lib/kamal/cli.rb

@@ -1,7 +1,6 @@
 module Kamal::Cli
-  class BootError < StandardError; end
-  class HookError < StandardError; end
   class LockError < StandardError; end
+  class HookError < StandardError; end
 end
 
 # SSHKit uses instance eval, so we need a global const for ergonomics

lib/kamal/cli/accessory.rb

@@ -1,22 +1,17 @@
-require "active_support/core_ext/array/conversions"
-
 class Kamal::Cli::Accessory < Kamal::Cli::Base
   desc "boot [NAME]", "Boot new accessory service on host (use NAME=all to boot all accessories)"
-  def boot(name, prepare: true)
+  def boot(name, login: true)
-    with_lock do
+    mutating do
       if name == "all"
         KAMAL.accessory_names.each { |accessory_name| boot(accessory_name) }
       else
-        prepare(name) if prepare
-
         with_accessory(name) do |accessory, hosts|
           directories(name)
           upload(name)
 
           on(hosts) do
+            execute *KAMAL.registry.login if login
             execute *KAMAL.auditor.record("Booted #{name} accessory"), verbosity: :debug
-            execute *accessory.ensure_env_directory
-            upload! accessory.secrets_io, accessory.secrets_path, mode: "0600"
             execute *accessory.run
           end
         end
@@ -26,7 +21,7 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
 
   desc "upload [NAME]", "Upload accessory files to host", hide: true
   def upload(name)
-    with_lock do
+    mutating do
       with_accessory(name) do |accessory, hosts|
         on(hosts) do
           accessory.files.each do |(local, remote)|
@@ -43,7 +38,7 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
 
   desc "directories [NAME]", "Create accessory directories on host", hide: true
   def directories(name)
-    with_lock do
+    mutating do
       with_accessory(name) do |accessory, hosts|
         on(hosts) do
           accessory.directories.keys.each do |host_path|
@@ -56,21 +51,26 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
 
   desc "reboot [NAME]", "Reboot existing accessory on host (stop container, remove container, start new container; use NAME=all to boot all accessories)"
   def reboot(name)
-    with_lock do
+    mutating do
       if name == "all"
         KAMAL.accessory_names.each { |accessory_name| reboot(accessory_name) }
       else
-        prepare(name)
+        with_accessory(name) do |accessory, hosts|
+          on(hosts) do
+            execute *KAMAL.registry.login
+          end
+
           stop(name)
           remove_container(name)
-        boot(name, prepare: false)
+          boot(name, login: false)
+        end
       end
     end
   end
 
   desc "start [NAME]", "Start existing accessory container on host"
   def start(name)
-    with_lock do
+    mutating do
       with_accessory(name) do |accessory, hosts|
         on(hosts) do
           execute *KAMAL.auditor.record("Started #{name} accessory"), verbosity: :debug
@@ -82,7 +82,7 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
 
   desc "stop [NAME]", "Stop existing accessory container on host"
   def stop(name)
-    with_lock do
+    mutating do
       with_accessory(name) do |accessory, hosts|
         on(hosts) do
           execute *KAMAL.auditor.record("Stopped #{name} accessory"), verbosity: :debug
@@ -94,20 +94,21 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
 
   desc "restart [NAME]", "Restart existing accessory container on host"
   def restart(name)
-    with_lock do
+    mutating do
+      with_accessory(name) do
         stop(name)
         start(name)
       end
     end
+  end
 
   desc "details [NAME]", "Show details about accessory on host (use NAME=all to show all accessories)"
   def details(name)
     if name == "all"
       KAMAL.accessory_names.each { |accessory_name| details(accessory_name) }
     else
-      type = "Accessory #{name}"
       with_accessory(name) do |accessory, hosts|
-        on(hosts) { puts_by_host host, capture_with_info(*accessory.info), type: type }
+        on(hosts) { puts capture_with_info(*accessory.info) }
       end
     end
   end
@@ -147,27 +148,23 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
   option :since, aliases: "-s", desc: "Show logs since timestamp (e.g. 2013-01-02T13:23:37Z) or relative (e.g. 42m for 42 minutes)"
   option :lines, type: :numeric, aliases: "-n", desc: "Number of log lines to pull from each server"
   option :grep, aliases: "-g", desc: "Show lines with grep match only (use this to fetch specific requests by id)"
-  option :grep_options, aliases: "-o", desc: "Additional options supplied to grep"
   option :follow, aliases: "-f", desc: "Follow logs on primary server (or specific host set by --hosts)"
-  option :skip_timestamps, type: :boolean, aliases: "-T", desc: "Skip appending timestamps to logging output"
   def logs(name)
     with_accessory(name) do |accessory, hosts|
       grep = options[:grep]
-      grep_options = options[:grep_options]
-      timestamps = !options[:skip_timestamps]
 
       if options[:follow]
         run_locally do
           info "Following logs on #{hosts}..."
-          info accessory.follow_logs(timestamps: timestamps, grep: grep, grep_options: grep_options)
+          info accessory.follow_logs(grep: grep)
-          exec accessory.follow_logs(timestamps: timestamps, grep: grep, grep_options: grep_options)
+          exec accessory.follow_logs(grep: grep)
         end
       else
         since = options[:since]
         lines = options[:lines].presence || ((since || grep) ? nil : 100) # Default to 100 lines if since or grep isn't set
 
         on(hosts) do
-          puts capture_with_info(*accessory.logs(timestamps: timestamps, since: since, lines: lines, grep: grep, grep_options: grep_options))
+          puts capture_with_info(*accessory.logs(since: since, lines: lines, grep: grep))
         end
       end
     end
@@ -176,12 +173,17 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
   desc "remove [NAME]", "Remove accessory container, image and data directory from host (use NAME=all to remove all accessories)"
   option :confirmed, aliases: "-y", type: :boolean, default: false, desc: "Proceed without confirmation question"
   def remove(name)
-    confirming "This will remove all containers, images and data directories for #{name}. Are you sure?" do
+    mutating do
-      with_lock do
       if name == "all"
-          KAMAL.accessory_names.each { |accessory_name| remove_accessory(accessory_name) }
+        KAMAL.accessory_names.each { |accessory_name| remove(accessory_name) }
       else
-          remove_accessory(name)
+        confirming "This will remove all containers, images and data directories for #{name}. Are you sure?" do
+          with_accessory(name) do
+            stop(name)
+            remove_container(name)
+            remove_image(name)
+            remove_service_directory(name)
+          end
         end
       end
     end
@@ -189,7 +191,7 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
 
   desc "remove_container [NAME]", "Remove accessory container from host", hide: true
   def remove_container(name)
-    with_lock do
+    mutating do
       with_accessory(name) do |accessory, hosts|
         on(hosts) do
           execute *KAMAL.auditor.record("Remove #{name} accessory container"), verbosity: :debug
@@ -201,7 +203,7 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
 
   desc "remove_image [NAME]", "Remove accessory image from host", hide: true
   def remove_image(name)
-    with_lock do
+    mutating do
       with_accessory(name) do |accessory, hosts|
         on(hosts) do
           execute *KAMAL.auditor.record("Removed #{name} accessory image"), verbosity: :debug
@@ -213,7 +215,7 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
 
   desc "remove_service_directory [NAME]", "Remove accessory directory used for uploaded files and data directories from host", hide: true
   def remove_service_directory(name)
-    with_lock do
+    mutating do
       with_accessory(name) do |accessory, hosts|
         on(hosts) do
           execute *accessory.remove_service_directory
@@ -222,25 +224,6 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
     end
   end
 
-  desc "upgrade", "Upgrade accessories from Kamal 1.x to 2.0 (restart them in 'kamal' network)"
-  option :rolling, type: :boolean, default: false, desc: "Upgrade one host at a time"
-  option :confirmed, aliases: "-y", type: :boolean, default: false, desc: "Proceed without confirmation question"
-  def upgrade(name)
-    confirming "This will restart all accessories" do
-      with_lock do
-        host_groups = options[:rolling] ? KAMAL.accessory_hosts : [ KAMAL.accessory_hosts ]
-        host_groups.each do |hosts|
-          host_list = Array(hosts).join(",")
-          KAMAL.with_specific_hosts(hosts) do
-            say "Upgrading #{name} accessories on #{host_list}...", :magenta
-            reboot name
-            say "Upgraded #{name} accessories on #{host_list}...", :magenta
-          end
-        end
-      end
-    end
-  end
-
   private
     def with_accessory(name)
       if KAMAL.config.accessory(name)
@@ -266,22 +249,4 @@ class Kamal::Cli::Accessory < Kamal::Cli::Base
         accessory.hosts
       end
     end
-
-    def remove_accessory(name)
-      stop(name)
-      remove_container(name)
-      remove_image(name)
-      remove_service_directory(name)
-    end
-
-    def prepare(name)
-      with_accessory(name) do |accessory, hosts|
-        on(hosts) do
-          execute *KAMAL.registry.login
-          execute *KAMAL.docker.create_network
-        rescue SSHKit::Command::Failed => e
-          raise unless e.message.include?("already exists")
-        end
-      end
-    end
 end

lib/kamal/cli/alias/command.rb

@@ -1,9 +0,0 @@
-class Kamal::Cli::Alias::Command < Thor::DynamicCommand
-  def run(instance, args = [])
-    if (_alias = KAMAL.config.aliases[name])
-      Kamal::Cli::Main.start(Shellwords.split(_alias.command) + ARGV[1..-1])
-    else
-      super
-    end
-  end
-end

lib/kamal/cli/app.rb

@@ -1,10 +1,11 @@
 class Kamal::Cli::App < Kamal::Cli::Base
   desc "boot", "Boot app on servers (or reboot app if already running)"
   def boot
-    with_lock do
+    mutating do
+      hold_lock_on_error do
         say "Get most recent version available as an image...", :magenta unless options[:version]
         using_version(version_or_latest) do |version|
-        say "Start container with version #{version} (or reboot if already running)...", :magenta
+          say "Start container with version #{version} using a #{KAMAL.config.readiness_delay}s readiness delay (or reboot if already running)...", :magenta
 
           # Assets are prepared in a separate step to ensure they are on all hosts before booting
           on(KAMAL.hosts) do
@@ -13,16 +14,12 @@ class Kamal::Cli::App < Kamal::Cli::Base
             end
           end
 
-        # Primary hosts and roles are returned first, so they can open the barrier
-        barrier = Kamal::Cli::Healthcheck::Barrier.new
-
           on(KAMAL.hosts, **KAMAL.boot_strategy) do |host|
             KAMAL.roles_on(host).each do |role|
-            Kamal::Cli::App::Boot.new(host, role, self, version, barrier).run
+              Kamal::Cli::App::Boot.new(host, role, version, self).run
             end
           end
 
-        # Tag once the app booted on all hosts
           on(KAMAL.hosts) do |host|
             execute *KAMAL.auditor.record("Tagging #{KAMAL.config.absolute_image} as the latest image"), verbosity: :debug
             execute *KAMAL.app.tag_latest_image
@@ -30,25 +27,17 @@ class Kamal::Cli::App < Kamal::Cli::Base
         end
       end
     end
+  end
 
   desc "start", "Start existing app container on servers"
   def start
-    with_lock do
+    mutating do
       on(KAMAL.hosts) do |host|
         roles = KAMAL.roles_on(host)
 
         roles.each do |role|
-          app = KAMAL.app(role: role, host: host)
           execute *KAMAL.auditor.record("Started app version #{KAMAL.config.version}"), verbosity: :debug
-          execute *app.start, raise_on_non_zero_exit: false
+          execute *KAMAL.app(role: role).start, raise_on_non_zero_exit: false
-
-          if role.running_proxy?
-            version = capture_with_info(*app.current_running_version, raise_on_non_zero_exit: false).strip
-            endpoint = capture_with_info(*app.container_id_for_version(version)).strip
-            raise Kamal::Cli::BootError, "Failed to get endpoint for #{role} on #{host}, did the container boot?" if endpoint.empty?
-
-            execute *app.deploy(target: endpoint)
-          end
         end
       end
     end
@@ -56,23 +45,13 @@ class Kamal::Cli::App < Kamal::Cli::Base
 
   desc "stop", "Stop app container on servers"
   def stop
-    with_lock do
+    mutating do
       on(KAMAL.hosts) do |host|
         roles = KAMAL.roles_on(host)
 
         roles.each do |role|
-          app = KAMAL.app(role: role, host: host)
           execute *KAMAL.auditor.record("Stopped app", role: role), verbosity: :debug
-
+          execute *KAMAL.app(role: role).stop, raise_on_non_zero_exit: false
-          if role.running_proxy?
-            version = capture_with_info(*app.current_running_version, raise_on_non_zero_exit: false).strip
-            endpoint = capture_with_info(*app.container_id_for_version(version)).strip
-            if endpoint.present?
-              execute *app.remove, raise_on_non_zero_exit: false
-            end
-          end
-
-          execute *app.stop, raise_on_non_zero_exit: false
         end
       end
     end
@@ -85,24 +64,23 @@ class Kamal::Cli::App < Kamal::Cli::Base
       roles = KAMAL.roles_on(host)
 
       roles.each do |role|
-        puts_by_host host, capture_with_info(*KAMAL.app(role: role, host: host).info)
+        puts_by_host host, capture_with_info(*KAMAL.app(role: role).info)
       end
     end
   end
 
-  desc "exec [CMD...]", "Execute a custom command on servers within the app container (use --help to show options)"
+  desc "exec [CMD]", "Execute a custom command on servers (use --help to show options)"
   option :interactive, aliases: "-i", type: :boolean, default: false, desc: "Execute command over ssh for an interactive shell (use for console/bash)"
   option :reuse, type: :boolean, default: false, desc: "Reuse currently running container instead of starting a new one"
   option :env, aliases: "-e", type: :hash, desc: "Set environment variables for the command"
-  def exec(*cmd)
+  def exec(cmd)
-    cmd = Kamal::Utils.join_commands(cmd)
     env = options[:env]
     case
     when options[:interactive] && options[:reuse]
       say "Get current version of running container...", :magenta unless options[:version]
       using_version(options[:version] || current_running_version) do |version|
         say "Launching interactive command with version #{version} via SSH from existing container on #{KAMAL.primary_host}...", :magenta
-        run_locally { exec KAMAL.app(role: KAMAL.primary_role, host: KAMAL.primary_host).execute_in_existing_container_over_ssh(cmd, env: env) }
+        run_locally { exec KAMAL.app(role: KAMAL.primary_role).execute_in_existing_container_over_ssh(cmd, host: KAMAL.primary_host, env: env) }
       end
 
     when options[:interactive]
@@ -110,7 +88,7 @@ class Kamal::Cli::App < Kamal::Cli::Base
       using_version(version_or_latest) do |version|
         say "Launching interactive command with version #{version} via SSH from new container on #{KAMAL.primary_host}...", :magenta
         run_locally do
-          exec KAMAL.app(role: KAMAL.primary_role, host: KAMAL.primary_host).execute_in_new_container_over_ssh(cmd, env: env)
+          exec KAMAL.app(role: KAMAL.primary_role).execute_in_new_container_over_ssh(cmd, host: KAMAL.primary_host, env: env)
         end
       end
 
@@ -124,7 +102,7 @@ class Kamal::Cli::App < Kamal::Cli::Base
 
           roles.each do |role|
             execute *KAMAL.auditor.record("Executed cmd '#{cmd}' on app version #{version}", role: role), verbosity: :debug
-            puts_by_host host, capture_with_info(*KAMAL.app(role: role, host: host).execute_in_existing_container(cmd, env: env))
+            puts_by_host host, capture_with_info(*KAMAL.app(role: role).execute_in_existing_container(cmd, env: env))
           end
         end
       end
@@ -138,7 +116,7 @@ class Kamal::Cli::App < Kamal::Cli::Base
 
           roles.each do |role|
             execute *KAMAL.auditor.record("Executed cmd '#{cmd}' on app version #{version}"), verbosity: :debug
-            puts_by_host host, capture_with_info(*KAMAL.app(role: role, host: host).execute_in_new_container(cmd, env: env))
+            puts_by_host host, capture_with_info(*KAMAL.app(role: role).execute_in_new_container(cmd, env: env))
           end
         end
       end
@@ -153,21 +131,22 @@ class Kamal::Cli::App < Kamal::Cli::Base
   desc "stale_containers", "Detect app stale containers"
   option :stop, aliases: "-s", type: :boolean, default: false, desc: "Stop the stale containers found"
   def stale_containers
+    mutating do
       stop = options[:stop]
 
-    with_lock_if_stopping do
+      cli = self
+
       on(KAMAL.hosts) do |host|
         roles = KAMAL.roles_on(host)
 
         roles.each do |role|
-          app = KAMAL.app(role: role, host: host)
+          versions = capture_with_info(*KAMAL.app(role: role).list_versions, raise_on_non_zero_exit: false).split("\n")
-          versions = capture_with_info(*app.list_versions, raise_on_non_zero_exit: false).split("\n")
+          versions -= [ capture_with_info(*KAMAL.app(role: role).current_running_version, raise_on_non_zero_exit: false).strip ]
-          versions -= [ capture_with_info(*app.current_running_version, raise_on_non_zero_exit: false).strip ]
 
           versions.each do |version|
             if stop
               puts_by_host host, "Stopping stale container for role #{role} with version #{version}"
-              execute *app.stop(version: version), raise_on_non_zero_exit: false
+              execute *KAMAL.app(role: role).stop(version: version), raise_on_non_zero_exit: false
             else
               puts_by_host host,  "Detected stale container for role #{role} with version #{version} (use `kamal app stale_containers --stop` to stop)"
             end
@@ -186,29 +165,23 @@ class Kamal::Cli::App < Kamal::Cli::Base
   option :since, aliases: "-s", desc: "Show lines since timestamp (e.g. 2013-01-02T13:23:37Z) or relative (e.g. 42m for 42 minutes)"
   option :lines, type: :numeric, aliases: "-n", desc: "Number of lines to show from each server"
   option :grep, aliases: "-g", desc: "Show lines with grep match only (use this to fetch specific requests by id)"
-  option :grep_options, aliases: "-o", desc: "Additional options supplied to grep"
   option :follow, aliases: "-f", desc: "Follow log on primary server (or specific host set by --hosts)"
-  option :skip_timestamps, type: :boolean, aliases: "-T", desc: "Skip appending timestamps to logging output"
   def logs
     # FIXME: Catch when app containers aren't running
 
     grep = options[:grep]
-    grep_options = options[:grep_options]
     since = options[:since]
-    timestamps = !options[:skip_timestamps]
-
     if options[:follow]
       lines = options[:lines].presence || ((since || grep) ? nil : 10) # Default to 10 lines if since or grep isn't set
 
       run_locally do
         info "Following logs on #{KAMAL.primary_host}..."
 
-        KAMAL.specific_roles ||= [ KAMAL.primary_role.name ]
+        KAMAL.specific_roles ||= [ "web" ]
         role = KAMAL.roles_on(KAMAL.primary_host).first
 
-        app = KAMAL.app(role: role, host: host)
+        info KAMAL.app(role: role).follow_logs(host: KAMAL.primary_host, lines: lines, grep: grep)
-        info app.follow_logs(host: KAMAL.primary_host, timestamps: timestamps, lines: lines, grep: grep, grep_options: grep_options)
+        exec KAMAL.app(role: role).follow_logs(host: KAMAL.primary_host, lines: lines, grep: grep)
-        exec app.follow_logs(host: KAMAL.primary_host, timestamps: timestamps, lines: lines, grep: grep, grep_options: grep_options)
       end
     else
       lines = options[:lines].presence || ((since || grep) ? nil : 100) # Default to 100 lines if since or grep isn't set
@@ -218,7 +191,7 @@ class Kamal::Cli::App < Kamal::Cli::Base
 
         roles.each do |role|
           begin
-            puts_by_host host, capture_with_info(*KAMAL.app(role: role, host: host).logs(timestamps: timestamps, since: since, lines: lines, grep: grep, grep_options: grep_options))
+            puts_by_host host, capture_with_info(*KAMAL.app(role: role).logs(since: since, lines: lines, grep: grep))
           rescue SSHKit::Command::Failed
             puts_by_host host, "Nothing found"
           end
@@ -229,23 +202,22 @@ class Kamal::Cli::App < Kamal::Cli::Base
 
   desc "remove", "Remove app containers and images from servers"
   def remove
-    with_lock do
+    mutating do
       stop
       remove_containers
       remove_images
-      remove_app_directory
     end
   end
 
   desc "remove_container [VERSION]", "Remove app container with given version from servers", hide: true
   def remove_container(version)
-    with_lock do
+    mutating do
       on(KAMAL.hosts) do |host|
         roles = KAMAL.roles_on(host)
 
         roles.each do |role|
           execute *KAMAL.auditor.record("Removed app container with version #{version}", role: role), verbosity: :debug
-          execute *KAMAL.app(role: role, host: host).remove_container(version: version)
+          execute *KAMAL.app(role: role).remove_container(version: version)
         end
       end
     end
@@ -253,13 +225,13 @@ class Kamal::Cli::App < Kamal::Cli::Base
 
   desc "remove_containers", "Remove all app containers from servers", hide: true
   def remove_containers
-    with_lock do
+    mutating do
       on(KAMAL.hosts) do |host|
         roles = KAMAL.roles_on(host)
 
         roles.each do |role|
           execute *KAMAL.auditor.record("Removed all app containers", role: role), verbosity: :debug
-          execute *KAMAL.app(role: role, host: host).remove_containers
+          execute *KAMAL.app(role: role).remove_containers
         end
       end
     end
@@ -267,7 +239,7 @@ class Kamal::Cli::App < Kamal::Cli::Base
 
   desc "remove_images", "Remove all app images from servers", hide: true
   def remove_images
-    with_lock do
+    mutating do
       on(KAMAL.hosts) do
         execute *KAMAL.auditor.record("Removed all app images"), verbosity: :debug
         execute *KAMAL.app.remove_images
@@ -275,25 +247,11 @@ class Kamal::Cli::App < Kamal::Cli::Base
     end
   end
 
-  desc "remove_app_directory", "Remove the service directory from servers", hide: true
-  def remove_app_directory
-    with_lock do
-      on(KAMAL.hosts) do |host|
-        roles = KAMAL.roles_on(host)
-
-        roles.each do |role|
-          execute *KAMAL.auditor.record("Removed #{KAMAL.config.app_directory} on all servers", role: role), verbosity: :debug
-          execute *KAMAL.server.remove_app_directory, raise_on_non_zero_exit: false
-        end
-      end
-    end
-  end
-
   desc "version", "Show app version currently running on servers"
   def version
     on(KAMAL.hosts) do |host|
       role = KAMAL.roles_on(host).first
-      puts_by_host host, capture_with_info(*KAMAL.app(role: role, host: host).current_running_version).strip
+      puts_by_host host, capture_with_info(*KAMAL.app(role: role).current_running_version).strip
     end
   end
 
@@ -316,7 +274,7 @@ class Kamal::Cli::App < Kamal::Cli::Base
       version = nil
       on(host) do
         role = KAMAL.roles_on(host).first
-        version = capture_with_info(*KAMAL.app(role: role, host: host).current_running_version).strip
+        version = capture_with_info(*KAMAL.app(role: role).current_running_version).strip
       end
       version.presence
     end
@@ -324,12 +282,4 @@ class Kamal::Cli::App < Kamal::Cli::Base
     def version_or_latest
       options[:version] || KAMAL.config.latest_tag
     end
-
-    def with_lock_if_stopping
-      if options[:stop]
-        with_lock { yield }
-      else
-        yield
-      end
-    end
 end

lib/kamal/cli/app/boot.rb

@@ -1,110 +1,28 @@
 class Kamal::Cli::App::Boot
-  attr_reader :host, :role, :version, :barrier, :sshkit
+  attr_reader :host, :role, :version, :sshkit
-  delegate :execute, :capture_with_info, :capture_with_pretty_json, :info, :error, :upload!, to: :sshkit
+  delegate :execute, :capture_with_info, :info, to: :sshkit
-  delegate :assets?, :running_proxy?, to: :role
+  delegate :uses_cord?, :assets?, to: :role
 
-  def initialize(host, role, sshkit, version, barrier)
+  def initialize(host, role, version, sshkit)
     @host = host
     @role = role
     @version = version
-    @barrier = barrier
     @sshkit = sshkit
   end
 
   def run
-    old_version = old_version_renamed_if_clashing
+    old_version, old_app = old_version_renamed_if_clashing
 
-    wait_at_barrier if queuer?
-
-    begin
     start_new_version
-    rescue => e
-      close_barrier if gatekeeper?
-      stop_new_version
-      raise
-    end
-
-    release_barrier if gatekeeper?
 
     if old_version
-      stop_old_version(old_version)
+      stop_old_version(old_version, old_app)
     end
   end
 
   private
-    def old_version_renamed_if_clashing
-      if capture_with_info(*app.container_id_for_version(version), raise_on_non_zero_exit: false).present?
-        renamed_version = "#{version}_replaced_#{SecureRandom.hex(8)}"
-        info "Renaming container #{version} to #{renamed_version} as already deployed on #{host}"
-        audit("Renaming container #{version} to #{renamed_version}")
-        execute *app.rename_container(version: version, new_version: renamed_version)
-      end
-
-      capture_with_info(*app.current_running_version, raise_on_non_zero_exit: false).strip.presence
-    end
-
-    def start_new_version
-      audit "Booted app version #{version}"
-      hostname = "#{host.to_s[0...51].gsub(/\.+$/, '')}-#{SecureRandom.hex(6)}"
-
-      execute *app.ensure_env_directory
-      upload! role.secrets_io(host), role.secrets_path, mode: "0600"
-
-      execute *app.run(hostname: hostname)
-      if running_proxy?
-        endpoint = capture_with_info(*app.container_id_for_version(version)).strip
-        raise Kamal::Cli::BootError, "Failed to get endpoint for #{role} on #{host}, did the container boot?" if endpoint.empty?
-        execute *app.deploy(target: endpoint)
-      else
-        Kamal::Cli::Healthcheck::Poller.wait_for_healthy(pause_after_ready: true) { capture_with_info(*app.status(version: version)) }
-      end
-    rescue => e
-      error "Failed to boot #{role} on #{host}"
-      raise e
-    end
-
-    def stop_new_version
-      execute *app.stop(version: version), raise_on_non_zero_exit: false
-    end
-
-    def stop_old_version(version)
-      execute *app.stop(version: version), raise_on_non_zero_exit: false
-      execute *app.clean_up_assets if assets?
-    end
-
-    def release_barrier
-      if barrier.open
-        info "First #{KAMAL.primary_role} container is healthy on #{host}, booting any other roles"
-      end
-    end
-
-    def wait_at_barrier
-      info "Waiting for the first healthy #{KAMAL.primary_role} container before booting #{role} on #{host}..."
-      barrier.wait
-      info "First #{KAMAL.primary_role} container is healthy, booting #{role} on #{host}..."
-    rescue Kamal::Cli::Healthcheck::Error
-      info "First #{KAMAL.primary_role} container is unhealthy, not booting #{role} on #{host}"
-      raise
-    end
-
-    def close_barrier
-      if barrier.close
-        info "First #{KAMAL.primary_role} container is unhealthy on #{host}, not booting any other roles"
-        begin
-          error capture_with_info(*app.logs(version: version))
-          error capture_with_info(*app.container_health_log(version: version))
-        rescue SSHKit::Command::Failed
-          error "Could not fetch logs for #{version}"
-        end
-      end
-    end
-
-    def barrier_role?
-      role == KAMAL.primary_role
-    end
-
     def app
-      @app ||= KAMAL.app(role: role, host: host)
+      @app ||= KAMAL.app(role: role)
     end
 
     def auditor
@@ -115,11 +33,41 @@ class Kamal::Cli::App::Boot
       execute *auditor.record(message), verbosity: :debug
     end
 
-    def gatekeeper?
+    def old_version_renamed_if_clashing
-      barrier && barrier_role?
+      if capture_with_info(*app.container_id_for_version(version), raise_on_non_zero_exit: false).present?
+        renamed_version = "#{version}_replaced_#{SecureRandom.hex(8)}"
+        info "Renaming container #{version} to #{renamed_version} as already deployed on #{host}"
+        audit("Renaming container #{version} to #{renamed_version}")
+        execute *app.rename_container(version: version, new_version: renamed_version)
       end
 
-    def queuer?
+      [ role, *role.previous_roles ].each do |old_role|
-      barrier && !barrier_role?
+        old_app = KAMAL.app(role: old_role)
+        old_version = capture_with_info(*old_app.current_running_version, raise_on_non_zero_exit: false).strip.presence
+        return [ old_version, old_app ] if old_version
+      end
+
+      nil
+    end
+
+    def start_new_version
+      audit "Booted app version #{version}"
+      execute *app.tie_cord(role.cord_host_file) if uses_cord?
+      execute *app.run(hostname: "#{host}-#{SecureRandom.hex(6)}")
+      Kamal::Cli::Healthcheck::Poller.wait_for_healthy(pause_after_ready: true) { capture_with_info(*app.status(version: version)) }
+    end
+
+    def stop_old_version(version, app)
+      if uses_cord?
+        cord = capture_with_info(*app.cord(version: version), raise_on_non_zero_exit: false).strip
+        if cord.present?
+          execute *app.cut_cord(cord)
+          Kamal::Cli::Healthcheck::Poller.wait_for_unhealthy(pause_after_ready: true) { capture_with_info(*app.status(version: version)) }
+        end
+      end
+
+      execute *app.stop(version: version), raise_on_non_zero_exit: false
+
+      execute *app.clean_up_assets if assets?
     end
 end

lib/kamal/cli/app/prepare_assets.rb

@@ -19,6 +19,6 @@ class Kamal::Cli::App::PrepareAssets
 
   private
     def app
-      @app ||= KAMAL.app(role: role, host: host)
+      @app ||= KAMAL.app(role: role)
     end
 end

lib/kamal/cli/base.rb

@@ -1,12 +1,12 @@
 require "thor"
+require "dotenv"
 require "kamal/sshkit_with_ext"
 
 module Kamal::Cli
   class Base < Thor
     include SSHKit::DSL
 
-    def self.exit_on_failure?() false end
+    def self.exit_on_failure?() true end
-    def self.dynamic_command_class() Kamal::Cli::Alias::Command end
 
     class_option :verbose, type: :boolean, aliases: "-v", desc: "Detailed logging"
     class_option :quiet, type: :boolean, aliases: "-q", desc: "Minimal logging"
@@ -22,23 +22,33 @@ module Kamal::Cli
 
     class_option :skip_hooks, aliases: "-H", type: :boolean, default: false, desc: "Don't run hooks"
 
-    def initialize(args = [], local_options = {}, config = {})
+    def initialize(*)
-      if config[:current_command].is_a?(Kamal::Cli::Alias::Command)
-        # When Thor generates a dynamic command, it doesn't attempt to parse the arguments.
-        # For our purposes, it means the arguments are passed in args rather than local_options.
-        super([], args, config)
-      else
       super
-      end
+      @original_env = ENV.to_h.dup
-      initialize_commander unless KAMAL.configured?
+      load_envs
+      initialize_commander(options_with_subcommand_class_options)
     end
 
     private
+      def load_envs
+        if destination = options[:destination]
+          Dotenv.load(".env.#{destination}", ".env")
+        else
+          Dotenv.load(".env")
+        end
+      end
+
+      def reload_envs
+        ENV.clear
+        ENV.update(@original_env)
+        load_envs
+      end
+
       def options_with_subcommand_class_options
         options.merge(@_initializer.last[:class_options] || {})
       end
 
-      def initialize_commander
+      def initialize_commander(options)
         KAMAL.tap do |commander|
           if options[:verbose]
             ENV["VERBOSE"] = "1" # For backtraces via cli/start
@@ -69,26 +79,29 @@ module Kamal::Cli
         puts "  Finished all in #{sprintf("%.1f seconds", runtime)}"
       end
 
-      def with_lock
+      def mutating
-        if KAMAL.holding_lock?
+        return yield if KAMAL.holding_lock?
-          yield
+
-        else
+        run_hook "pre-connect"
+
+        ensure_run_and_locks_directory
+
         acquire_lock
 
         begin
           yield
         rescue
-            begin
+          if KAMAL.hold_lock_on_error?
+            error "  \e[31mDeploy lock was not released\e[0m"
+          else
             release_lock
-            rescue => e
-              say "Error releasing the deploy lock: #{e.message}", :red
           end
+
           raise
         end
 
         release_lock
       end
-      end
 
       def confirming(question)
         return yield if options[:confirmed]
@@ -101,8 +114,6 @@ module Kamal::Cli
       end
 
       def acquire_lock
-        ensure_run_directory
-
         raise_if_locked do
           say "Acquiring the deploy lock...", :magenta
           on(KAMAL.primary_host) { execute *KAMAL.lock.acquire("Automatic deploy lock", KAMAL.config.version), verbosity: :debug }
@@ -130,30 +141,29 @@ module Kamal::Cli
         end
       end
 
+      def hold_lock_on_error
+        if KAMAL.hold_lock_on_error?
+          yield
+        else
+          KAMAL.hold_lock_on_error = true
+          yield
+          KAMAL.hold_lock_on_error = false
+        end
+      end
+
       def run_hook(hook, **extra_details)
         if !options[:skip_hooks] && KAMAL.hook.hook_exists?(hook)
           details = { hosts: KAMAL.hosts.join(","), command: command, subcommand: subcommand }
 
           say "Running the #{hook} hook...", :magenta
-          with_env KAMAL.hook.env(**details, **extra_details) do
           run_locally do
-              execute *KAMAL.hook.run(hook)
+            execute *KAMAL.hook.run(hook, **details, **extra_details)
-            end
           rescue SSHKit::Command::Failed => e
             raise HookError.new("Hook `#{hook}` failed:\n#{e.message}")
           end
         end
       end
 
-      def on(*args, &block)
-        if !KAMAL.connected?
-          run_hook "pre-connect"
-          KAMAL.connected = true
-        end
-
-        super
-      end
-
       def command
         @kamal_command ||= begin
           invocation_class, invocation_commands = *first_invocation
@@ -176,23 +186,14 @@ module Kamal::Cli
         instance_variable_get("@_invocations").first
       end
 
-      def reset_invocation(cli_class)
+      def ensure_run_and_locks_directory
-        instance_variable_get("@_invocations")[cli_class].pop
-      end
-
-      def ensure_run_directory
         on(KAMAL.hosts) do
           execute(*KAMAL.server.ensure_run_directory)
         end
-      end
 
-      def with_env(env)
+        on(KAMAL.primary_host) do
-        current_env = ENV.to_h.dup
+          execute(*KAMAL.lock.ensure_locks_directory)
-        ENV.update(env)
+        end
-        yield
-      ensure
-        ENV.clear
-        ENV.update(current_env)
       end
   end
 end

lib/kamal/cli/build.rb

@@ -5,75 +5,60 @@ class Kamal::Cli::Build < Kamal::Cli::Base
 
   desc "deliver", "Build app and push app image to registry then pull image on servers"
   def deliver
+    mutating do
       push
       pull
     end
+  end
 
   desc "push", "Build and push app image to registry"
   def push
+    mutating do
       cli = self
 
       verify_local_dependencies
       run_hook "pre-build"
 
-    uncommitted_changes = Kamal::Git.uncommitted_changes
+      if (uncommitted_changes = Kamal::Git.uncommitted_changes).present?
-
+        say "The following paths have uncommitted changes:\n #{uncommitted_changes}", :yellow
-    if KAMAL.config.builder.git_clone?
-      if uncommitted_changes.present?
-        say "Building from a local git clone, so ignoring these uncommitted changes:\n #{uncommitted_changes}", :yellow
       end
 
-      run_locally do
-        Clone.new(self).prepare
-      end
-    elsif uncommitted_changes.present?
-      say "Building with uncommitted changes:\n #{uncommitted_changes}", :yellow
-    end
-
-    with_env(KAMAL.config.builder.secrets) do
       run_locally do
         begin
-          execute *KAMAL.builder.inspect_builder
+          KAMAL.with_verbosity(:debug) do
+            execute *KAMAL.builder.push
+          end
         rescue SSHKit::Command::Failed => e
-          if e.message =~ /(context not found|no builder|no compatible builder|does not exist)/
+          if e.message =~ /(no builder)|(no such file or directory)/
-            warn "Missing compatible builder, so creating a new one first"
+            error "Missing compatible builder, so creating a new one first"
-            begin
+
-              cli.remove
+            if cli.create
-            rescue SSHKit::Command::Failed
+              KAMAL.with_verbosity(:debug) { execute *KAMAL.builder.push }
-              raise unless e.message =~ /(context not found|no builder|does not exist)/
             end
-            cli.create
           else
             raise
           end
         end
-
-        # Get the command here to ensure the Dir.chdir doesn't interfere with it
-        push = KAMAL.builder.push
-
-        KAMAL.with_verbosity(:debug) do
-          Dir.chdir(KAMAL.config.builder.build_directory) { execute *push }
-        end
       end
     end
   end
 
   desc "pull", "Pull app image from registry onto servers"
   def pull
-    if (first_hosts = mirror_hosts).any?
+    mutating do
-      #  Pull on a single host per mirror first to seed them
+      on(KAMAL.hosts) do
-      say "Pulling image on #{first_hosts.join(", ")} to seed the #{"mirror".pluralize(first_hosts.count)}...", :magenta
+        execute *KAMAL.auditor.record("Pulled image with version #{KAMAL.config.version}"), verbosity: :debug
-      pull_on_hosts(first_hosts)
+        execute *KAMAL.builder.clean, raise_on_non_zero_exit: false
-      say "Pulling image on remaining hosts...", :magenta
+        execute *KAMAL.builder.pull
-      pull_on_hosts(KAMAL.hosts - first_hosts)
+        execute *KAMAL.builder.validate_image
-    else
+      end
-      pull_on_hosts(KAMAL.hosts)
     end
   end
 
   desc "create", "Create a build setup"
   def create
-    if (remote_host = KAMAL.config.builder.remote)
+    mutating do
+      if (remote_host = KAMAL.config.builder.remote_host)
         connect_to_remote_host(remote_host)
       end
 
@@ -91,14 +76,17 @@ class Kamal::Cli::Build < Kamal::Cli::Base
         end
       end
     end
+  end
 
   desc "remove", "Remove build setup"
   def remove
+    mutating do
       run_locally do
         debug "Using builder: #{KAMAL.builder.name}"
         execute *KAMAL.builder.remove
       end
     end
+  end
 
   desc "details", "Show build setup"
   def details
@@ -126,37 +114,10 @@ class Kamal::Cli::Build < Kamal::Cli::Base
     def connect_to_remote_host(remote_host)
       remote_uri = URI.parse(remote_host)
       if remote_uri.scheme == "ssh"
-        host = SSHKit::Host.new(
+        options = { user: remote_uri.user, port: remote_uri.port }.compact
-          hostname: remote_uri.host,
+        on(remote_uri.host, options) do
-          ssh_options: { user: remote_uri.user, port: remote_uri.port }.compact
-        )
-        on(host, options) do
           execute "true"
         end
       end
     end
-
-    def mirror_hosts
-      if KAMAL.hosts.many?
-        mirror_hosts = Concurrent::Hash.new
-        on(KAMAL.hosts) do |host|
-          first_mirror = capture_with_info(*KAMAL.builder.first_mirror).strip.presence
-          mirror_hosts[first_mirror] ||= host.to_s if first_mirror
-        rescue SSHKit::Command::Failed => e
-          raise unless e.message =~ /error calling index: reflect: slice index out of range/
-        end
-        mirror_hosts.values
-      else
-        []
-      end
-    end
-
-    def pull_on_hosts(hosts)
-      on(hosts) do
-        execute *KAMAL.auditor.record("Pulled image with version #{KAMAL.config.version}"), verbosity: :debug
-        execute *KAMAL.builder.clean, raise_on_non_zero_exit: false
-        execute *KAMAL.builder.pull
-        execute *KAMAL.builder.validate_image
-      end
-    end
 end

lib/kamal/cli/build/clone.rb

@@ -1,61 +0,0 @@
-require "uri"
-
-class Kamal::Cli::Build::Clone
-  attr_reader :sshkit
-  delegate :info, :error, :execute, :capture_with_info, to: :sshkit
-
-  def initialize(sshkit)
-    @sshkit = sshkit
-  end
-
-  def prepare
-    begin
-      clone_repo
-    rescue SSHKit::Command::Failed => e
-      if e.message =~ /already exists and is not an empty directory/
-        reset
-      else
-        raise Kamal::Cli::Build::BuildError, "Failed to clone repo: #{e.message}"
-      end
-    end
-
-    validate!
-  rescue Kamal::Cli::Build::BuildError => e
-    error "Error preparing clone: #{e.message}, deleting and retrying..."
-
-    FileUtils.rm_rf KAMAL.config.builder.clone_directory
-    clone_repo
-    validate!
-  end
-
-  private
-    def clone_repo
-      info "Cloning repo into build directory `#{KAMAL.config.builder.build_directory}`..."
-
-      FileUtils.mkdir_p KAMAL.config.builder.clone_directory
-      execute *KAMAL.builder.clone
-    end
-
-    def reset
-      info "Resetting local clone as `#{KAMAL.config.builder.build_directory}` already exists..."
-
-      KAMAL.builder.clone_reset_steps.each { |step| execute *step }
-    rescue SSHKit::Command::Failed => e
-      raise Kamal::Cli::Build::BuildError, "Failed to clone repo: #{e.message}"
-    end
-
-    def validate!
-      status = capture_with_info(*KAMAL.builder.clone_status).strip
-
-      unless status.empty?
-        raise Kamal::Cli::Build::BuildError, "Clone in #{KAMAL.config.builder.build_directory} is dirty, #{status}"
-      end
-
-      revision = capture_with_info(*KAMAL.builder.clone_revision).strip
-      if revision != Kamal::Git.revision
-        raise Kamal::Cli::Build::BuildError, "Clone in #{KAMAL.config.builder.build_directory} is not on the correct revision, expected `#{Kamal::Git.revision}` but got `#{revision}`"
-      end
-    rescue SSHKit::Command::Failed => e
-      raise Kamal::Cli::Build::BuildError, "Failed to validate clone: #{e.message}"
-    end
-end

lib/kamal/cli/env.rb

@@ -0,0 +1,54 @@
+require "tempfile"
+
+class Kamal::Cli::Env < Kamal::Cli::Base
+  desc "push", "Push the env file to the remote hosts"
+  def push
+    mutating do
+      on(KAMAL.hosts) do
+        execute *KAMAL.auditor.record("Pushed env files"), verbosity: :debug
+
+        KAMAL.roles_on(host).each do |role|
+          execute *KAMAL.app(role: role).make_env_directory
+          upload! role.env.secrets_io, role.env.secrets_file, mode: 400
+        end
+      end
+
+      on(KAMAL.traefik_hosts) do
+        execute *KAMAL.traefik.make_env_directory
+        upload! KAMAL.traefik.env.secrets_io, KAMAL.traefik.env.secrets_file, mode: 400
+      end
+
+      on(KAMAL.accessory_hosts) do
+        KAMAL.accessories_on(host).each do |accessory|
+          accessory_config = KAMAL.config.accessory(accessory)
+          execute *KAMAL.accessory(accessory).make_env_directory
+          upload! accessory_config.env.secrets_io, accessory_config.env.secrets_file, mode: 400
+        end
+      end
+    end
+  end
+
+  desc "delete", "Delete the env file from the remote hosts"
+  def delete
+    mutating do
+      on(KAMAL.hosts) do
+        execute *KAMAL.auditor.record("Deleted env files"), verbosity: :debug
+
+        KAMAL.roles_on(host).each do |role|
+          execute *KAMAL.app(role: role).remove_env_file
+        end
+      end
+
+      on(KAMAL.traefik_hosts) do
+        execute *KAMAL.traefik.remove_env_file
+      end
+
+      on(KAMAL.accessory_hosts) do
+        KAMAL.accessories_on(host).each do |accessory|
+          accessory_config = KAMAL.config.accessory(accessory)
+          execute *KAMAL.accessory(accessory).remove_env_file
+        end
+      end
+    end
+  end
+end

lib/kamal/cli/healthcheck.rb

@@ -0,0 +1,21 @@
+class Kamal::Cli::Healthcheck < Kamal::Cli::Base
+  default_command :perform
+
+  desc "perform", "Health check current app version"
+  def perform
+    raise "The primary host is not configured to run Traefik" unless KAMAL.config.role(KAMAL.config.primary_role).running_traefik?
+    on(KAMAL.primary_host) do
+      begin
+        execute *KAMAL.healthcheck.run
+        Poller.wait_for_healthy { capture_with_info(*KAMAL.healthcheck.status) }
+      rescue Poller::HealthcheckError => e
+        error capture_with_info(*KAMAL.healthcheck.logs)
+        error capture_with_pretty_json(*KAMAL.healthcheck.container_health_log)
+        raise
+      ensure
+        execute *KAMAL.healthcheck.stop, raise_on_non_zero_exit: false
+        execute *KAMAL.healthcheck.remove, raise_on_non_zero_exit: false
+      end
+    end
+  end
+end

lib/kamal/cli/healthcheck/barrier.rb

@@ -1,33 +0,0 @@
-require "concurrent/ivar"
-
-class Kamal::Cli::Healthcheck::Barrier
-  def initialize
-    @ivar = Concurrent::IVar.new
-  end
-
-  def close
-    set(false)
-  end
-
-  def open
-    set(true)
-  end
-
-  def wait
-    unless opened?
-      raise Kamal::Cli::Healthcheck::Error.new("Halted at barrier")
-    end
-  end
-
-  private
-    def opened?
-      @ivar.value
-    end
-
-    def set(value)
-      @ivar.set(value)
-      true
-    rescue Concurrent::MultipleAssignmentError
-      false
-    end
-end

lib/kamal/cli/healthcheck/error.rb

@@ -1,2 +0,0 @@
-class Kamal::Cli::Healthcheck::Error < StandardError
-end

lib/kamal/cli/healthcheck/poller.rb

@@ -1,30 +1,27 @@
 module Kamal::Cli::Healthcheck::Poller
   extend self
 
-  def wait_for_healthy(role, &block)
+  TRAEFIK_UPDATE_DELAY = 5
+
+  class HealthcheckError < StandardError; end
+
+  def wait_for_healthy(pause_after_ready: false, &block)
     attempt = 1
-    timeout_at = Time.now + KAMAL.config.deploy_timeout
+    max_attempts = KAMAL.config.healthcheck["max_attempts"]
-    readiness_delay = KAMAL.config.readiness_delay
 
     begin
-      status = block.call
+      case status = block.call
-
+      when "healthy"
-      if status == "running"
+        sleep TRAEFIK_UPDATE_DELAY if pause_after_ready
-        # Wait for the readiness delay and confirm it is still running
+      when "running" # No health check configured
-        if readiness_delay > 0
+        sleep KAMAL.config.readiness_delay if pause_after_ready
-          info "Container is running, waiting for readiness delay of #{readiness_delay} seconds"
+      else
-          sleep readiness_delay
+        raise HealthcheckError, "container not ready (#{status})"
-          status = block.call
       end
-      end
+    rescue HealthcheckError => e
-
+      if attempt <= max_attempts
-      unless %w[ running healthy ].include?(status)
+        info "#{e.message}, retrying in #{attempt}s (attempt #{attempt}/#{max_attempts})..."
-        raise Kamal::Cli::Healthcheck::Error, "container not ready after #{KAMAL.config.deploy_timeout} seconds (#{status})"
+        sleep attempt
-      end
-    rescue Kamal::Cli::Healthcheck::Error => e
-      time_left = timeout_at - Time.now
-      if time_left > 0
-        sleep [ attempt, time_left ].min
         attempt += 1
         retry
       else
@@ -35,6 +32,31 @@ module Kamal::Cli::Healthcheck::Poller
     info "Container is healthy!"
   end
 
+  def wait_for_unhealthy(pause_after_ready: false, &block)
+    attempt = 1
+    max_attempts = KAMAL.config.healthcheck["max_attempts"]
+
+    begin
+      case status = block.call
+      when "unhealthy"
+        sleep TRAEFIK_UPDATE_DELAY if pause_after_ready
+      else
+        raise HealthcheckError, "container not unhealthy (#{status})"
+      end
+    rescue HealthcheckError => e
+      if attempt <= max_attempts
+        info "#{e.message}, retrying in #{attempt}s (attempt #{attempt}/#{max_attempts})..."
+        sleep attempt
+        attempt += 1
+        retry
+      else
+        raise
+      end
+    end
+
+    info "Container is unhealthy!"
+  end
+
   private
     def info(message)
       SSHKit.config.output.info(message)

lib/kamal/cli/lock.rb

@@ -3,6 +3,7 @@ class Kamal::Cli::Lock < Kamal::Cli::Base
   def status
     handle_missing_lock do
       on(KAMAL.primary_host) do
+        execute *KAMAL.server.ensure_run_directory
         puts capture_with_debug(*KAMAL.lock.status)
       end
     end
@@ -12,10 +13,9 @@ class Kamal::Cli::Lock < Kamal::Cli::Base
   option :message, aliases: "-m", type: :string, desc: "A lock message", required: true
   def acquire
     message = options[:message]
-    ensure_run_directory
-
     raise_if_locked do
       on(KAMAL.primary_host) do
+        execute *KAMAL.server.ensure_run_directory
         execute *KAMAL.lock.acquire(message, KAMAL.config.version), verbosity: :debug
       end
       say "Acquired the deploy lock"
@@ -26,6 +26,7 @@ class Kamal::Cli::Lock < Kamal::Cli::Base
   def release
     handle_missing_lock do
       on(KAMAL.primary_host) do
+        execute *KAMAL.server.ensure_run_directory
         execute *KAMAL.lock.release, verbosity: :debug
       end
       say "Released the deploy lock"

lib/kamal/cli/main.rb

@@ -3,12 +3,15 @@ class Kamal::Cli::Main < Kamal::Cli::Base
   option :skip_push, aliases: "-P", type: :boolean, default: false, desc: "Skip image build and push"
   def setup
     print_runtime do
-      with_lock do
+      mutating do
         invoke_options = deploy_options
 
         say "Ensure Docker is installed...", :magenta
         invoke "kamal:cli:server:bootstrap", [], invoke_options
 
+        say "Push env files...", :magenta
+        invoke "kamal:cli:env:push", [], invoke_options
+
         invoke "kamal:cli:accessory:boot", [ "all" ], invoke_options
         deploy
       end
@@ -19,10 +22,11 @@ class Kamal::Cli::Main < Kamal::Cli::Base
   option :skip_push, aliases: "-P", type: :boolean, default: false, desc: "Skip image build and push"
   def deploy
     runtime = print_runtime do
+      mutating do
         invoke_options = deploy_options
 
         say "Log into image registry...", :magenta
-      invoke "kamal:cli:registry:login", [], invoke_options.merge(skip_local: options[:skip_push])
+        invoke "kamal:cli:registry:login", [], invoke_options
 
         if options[:skip_push]
           say "Pull app image...", :magenta
@@ -32,11 +36,15 @@ class Kamal::Cli::Main < Kamal::Cli::Base
           invoke "kamal:cli:build:deliver", [], invoke_options
         end
 
-      with_lock do
+        run_hook "pre-deploy"
-        run_hook "pre-deploy", secrets: true
 
-        say "Ensure kamal-proxy is running...", :magenta
+        say "Ensure Traefik is running...", :magenta
-        invoke "kamal:cli:proxy:boot", [], invoke_options
+        invoke "kamal:cli:traefik:boot", [], invoke_options
+
+        if KAMAL.config.role(KAMAL.config.primary_role).running_traefik?
+          say "Ensure app can pass healthcheck...", :magenta
+          invoke "kamal:cli:healthcheck:perform", [], invoke_options
+        end
 
         say "Detect stale containers...", :magenta
         invoke "kamal:cli:app:stale_containers", [], invoke_options.merge(stop: true)
@@ -48,13 +56,14 @@ class Kamal::Cli::Main < Kamal::Cli::Base
       end
     end
 
-    run_hook "post-deploy", secrets: true, runtime: runtime.round.to_s
+    run_hook "post-deploy", runtime: runtime.round
   end
 
-  desc "redeploy", "Deploy app to servers without bootstrapping servers, starting kamal-proxy, pruning, and registry login"
+  desc "redeploy", "Deploy app to servers without bootstrapping servers, starting Traefik, pruning, and registry login"
   option :skip_push, aliases: "-P", type: :boolean, default: false, desc: "Skip image build and push"
   def redeploy
     runtime = print_runtime do
+      mutating do
         invoke_options = deploy_options
 
         if options[:skip_push]
@@ -65,8 +74,10 @@ class Kamal::Cli::Main < Kamal::Cli::Base
           invoke "kamal:cli:build:deliver", [], invoke_options
         end
 
-      with_lock do
+        run_hook "pre-deploy"
-        run_hook "pre-deploy", secrets: true
+
+        say "Ensure app can pass healthcheck...", :magenta
+        invoke "kamal:cli:healthcheck:perform", [], invoke_options
 
         say "Detect stale containers...", :magenta
         invoke "kamal:cli:app:stale_containers", [], invoke_options.merge(stop: true)
@@ -75,21 +86,21 @@ class Kamal::Cli::Main < Kamal::Cli::Base
       end
     end
 
-    run_hook "post-deploy", secrets: true, runtime: runtime.round.to_s
+    run_hook "post-deploy", runtime: runtime.round
   end
 
   desc "rollback [VERSION]", "Rollback app to VERSION"
   def rollback(version)
     rolled_back = false
     runtime = print_runtime do
-      with_lock do
+      mutating do
         invoke_options = deploy_options
 
         KAMAL.config.version = version
         old_version = nil
 
         if container_available?(version)
-          run_hook "pre-deploy", secrets: true
+          run_hook "pre-deploy"
 
           invoke "kamal:cli:app:boot", [], invoke_options.merge(version: version)
           rolled_back = true
@@ -99,12 +110,12 @@ class Kamal::Cli::Main < Kamal::Cli::Base
       end
     end
 
-    run_hook "post-deploy", secrets: true, runtime: runtime.round.to_s if rolled_back
+    run_hook "post-deploy", runtime: runtime.round if rolled_back
   end
 
   desc "details", "Show details about all containers"
   def details
-    invoke "kamal:cli:proxy:details"
+    invoke "kamal:cli:traefik:details"
     invoke "kamal:cli:app:details"
     invoke "kamal:cli:accessory:details", [ "all" ]
   end
@@ -123,19 +134,7 @@ class Kamal::Cli::Main < Kamal::Cli::Base
     end
   end
 
-  desc "docs [SECTION]", "Show Kamal configuration documentation"
+  desc "init", "Create config stub in config/deploy.yml and env stub in .env"
-  def docs(section = nil)
-    case section
-    when NilClass
-      puts Kamal::Configuration.validation_doc
-    else
-      puts Kamal::Configuration.const_get(section.titlecase.to_sym).validation_doc
-    end
-  rescue NameError
-    puts "No documentation found for #{section}"
-  end
-
-  desc "init", "Create config stub in config/deploy.yml and secrets stub in .kamal"
   option :bundle, type: :boolean, default: false, desc: "Add Kamal to the Gemfile and create a bin/kamal binstub"
   def init
     require "fileutils"
@@ -148,10 +147,9 @@ class Kamal::Cli::Main < Kamal::Cli::Base
       puts "Created configuration file in config/deploy.yml"
     end
 
-    unless (secrets_file = Pathname.new(File.expand_path(".kamal/secrets"))).exist?
+    unless (deploy_file = Pathname.new(File.expand_path(".env"))).exist?
-      FileUtils.mkdir_p secrets_file.dirname
+      FileUtils.cp_r Pathname.new(File.expand_path("templates/template.env", __dir__)), deploy_file
-      FileUtils.cp_r Pathname.new(File.expand_path("templates/secrets", __dir__)), secrets_file
+      puts "Created .env file"
-      puts "Created .kamal/secrets file"
     end
 
     unless (hooks_dir = Pathname.new(File.expand_path(".kamal/hooks"))).exist?
@@ -176,46 +174,34 @@ class Kamal::Cli::Main < Kamal::Cli::Base
     end
   end
 
-  desc "remove", "Remove kamal-proxy, app, accessories, and registry session from servers"
+  desc "envify", "Create .env by evaluating .env.erb (or .env.staging.erb -> .env.staging when using -d staging)"
-  option :confirmed, aliases: "-y", type: :boolean, default: false, desc: "Proceed without confirmation question"
+  option :skip_push, aliases: "-P", type: :boolean, default: false, desc: "Skip .env file push"
-  def remove
+  def envify
-    confirming "This will remove all containers and images. Are you sure?" do
+    if destination = options[:destination]
-      with_lock do
+      env_template_path = ".env.#{destination}.erb"
-        invoke "kamal:cli:app:remove", [], options.without(:confirmed)
+      env_path          = ".env.#{destination}"
-        invoke "kamal:cli:proxy:remove", [], options.without(:confirmed)
+    else
-        invoke "kamal:cli:accessory:remove", [ "all" ], options
+      env_template_path = ".env.erb"
-        invoke "kamal:cli:registry:logout", [], options.without(:confirmed).merge(skip_local: true)
+      env_path          = ".env"
     end
+
+    File.write(env_path, ERB.new(File.read(env_template_path), trim_mode: "-").result, perm: 0600)
+
+    unless options[:skip_push]
+      reload_envs
+      invoke "kamal:cli:env:push", options
     end
   end
 
-  desc "upgrade", "Upgrade from Kamal 1.x to 2.0"
+  desc "remove", "Remove Traefik, app, accessories, and registry session from servers"
   option :confirmed, aliases: "-y", type: :boolean, default: false, desc: "Proceed without confirmation question"
-  option :rolling, type: :boolean, default: false, desc: "Upgrade one host at a time"
+  def remove
-  def upgrade
+    mutating do
-    confirming "This will replace Traefik with kamal-proxy and restart all accessories" do
+      confirming "This will remove all containers and images. Are you sure?" do
-      with_lock do
+        invoke "kamal:cli:traefik:remove", [], options.without(:confirmed)
-        if options[:rolling]
+        invoke "kamal:cli:app:remove", [], options.without(:confirmed)
-          (KAMAL.hosts | KAMAL.accessory_hosts).each do |host|
+        invoke "kamal:cli:accessory:remove", [ "all" ], options
-            KAMAL.with_specific_hosts(host) do
+        invoke "kamal:cli:registry:logout", [], options.without(:confirmed)
-              say "Upgrading #{host}...", :magenta
-              if KAMAL.hosts.include?(host)
-                invoke "kamal:cli:proxy:upgrade", [], options.merge(confirmed: true, rolling: false)
-                reset_invocation(Kamal::Cli::Proxy)
-              end
-              if KAMAL.accessory_hosts.include?(host)
-                invoke "kamal:cli:accessory:upgrade", [ "all" ], options.merge(confirmed: true, rolling: false)
-                reset_invocation(Kamal::Cli::Accessory)
-              end
-              say "Upgraded #{host}", :magenta
-            end
-          end
-        else
-          say "Upgrading all hosts...", :magenta
-          invoke "kamal:cli:proxy:upgrade", [], options.merge(confirmed: true)
-          invoke "kamal:cli:accessory:upgrade", [ "all" ], options.merge(confirmed: true)
-          say "Upgraded all hosts", :magenta
-        end
       end
     end
   end
@@ -234,34 +220,37 @@ class Kamal::Cli::Main < Kamal::Cli::Base
   desc "build", "Build application image"
   subcommand "build", Kamal::Cli::Build
 
+  desc "env", "Manage environment files"
+  subcommand "env", Kamal::Cli::Env
+
+  desc "healthcheck", "Healthcheck application"
+  subcommand "healthcheck", Kamal::Cli::Healthcheck
+
   desc "lock", "Manage the deploy lock"
   subcommand "lock", Kamal::Cli::Lock
 
-  desc "proxy", "Manage kamal-proxy"
-  subcommand "proxy", Kamal::Cli::Proxy
-
   desc "prune", "Prune old application images and containers"
   subcommand "prune", Kamal::Cli::Prune
 
   desc "registry", "Login and -out of the image registry"
   subcommand "registry", Kamal::Cli::Registry
 
-  desc "secrets", "Helpers for extracting secrets"
-  subcommand "secrets", Kamal::Cli::Secrets
-
   desc "server", "Bootstrap servers with curl and Docker"
   subcommand "server", Kamal::Cli::Server
 
+  desc "traefik", "Manage Traefik load balancer"
+  subcommand "traefik", Kamal::Cli::Traefik
+
   private
     def container_available?(version)
       begin
         on(KAMAL.hosts) do
           KAMAL.roles_on(host).each do |role|
-            container_id = capture_with_info(*KAMAL.app(role: role, host: host).container_id_for_version(version))
+            container_id = capture_with_info(*KAMAL.app(role: role).container_id_for_version(version))
             raise "Container not found" unless container_id.present?
           end
         end
-      rescue SSHKit::Runner::ExecuteError, SSHKit::Runner::MultipleExecuteError => e
+      rescue SSHKit::Runner::ExecuteError => e
         if e.message =~ /Container not found/
           say "Error looking for container version #{version}: #{e.message}"
           return false

lib/kamal/cli/proxy.rb

@@ -1,257 +0,0 @@
-class Kamal::Cli::Proxy < Kamal::Cli::Base
-  desc "boot", "Boot proxy on servers"
-  def boot
-    with_lock do
-      on(KAMAL.hosts) do |host|
-        execute *KAMAL.docker.create_network
-      rescue SSHKit::Command::Failed => e
-        raise unless e.message.include?("already exists")
-      end
-
-      on(KAMAL.proxy_hosts) do |host|
-        execute *KAMAL.registry.login
-
-        version = capture_with_info(*KAMAL.proxy.version).strip.presence
-
-        if version && Kamal::Utils.older_version?(version, Kamal::Configuration::PROXY_MINIMUM_VERSION)
-          raise "kamal-proxy version #{version} is too old, please reboot to update to at least #{Kamal::Configuration::PROXY_MINIMUM_VERSION}"
-        end
-        execute *KAMAL.proxy.start_or_run
-      end
-    end
-  end
-
-  desc "boot_config <set|get|clear>", "Mange kamal-proxy boot configuration"
-  option :publish, type: :boolean, default: true, desc: "Publish the proxy ports on the host"
-  option :http_port, type: :numeric, default: Kamal::Configuration::PROXY_HTTP_PORT, desc: "HTTP port to publish on the host"
-  option :https_port, type: :numeric, default: Kamal::Configuration::PROXY_HTTPS_PORT, desc: "HTTPS port to publish on the host"
-  option :log_max_size, type: :string, default: Kamal::Configuration::PROXY_LOG_MAX_SIZE, desc: "Max size of proxy logs"
-  option :docker_options, type: :array, default: [], desc: "Docker options to pass to the proxy container", banner: "option=value option2=value2"
-  def boot_config(subcommand)
-    case subcommand
-    when "set"
-      boot_options = [
-        *(KAMAL.config.proxy_publish_args(options[:http_port], options[:https_port]) if options[:publish]),
-        *(KAMAL.config.proxy_logging_args(options[:log_max_size])),
-        *options[:docker_options].map { |option| "--#{option}" }
-      ]
-
-      on(KAMAL.proxy_hosts) do |host|
-        execute(*KAMAL.proxy.ensure_proxy_directory)
-        upload! StringIO.new(boot_options.join(" ")), KAMAL.config.proxy_options_file
-      end
-    when "get"
-      on(KAMAL.proxy_hosts) do |host|
-        puts "Host #{host}: #{capture_with_info(*KAMAL.proxy.get_boot_options)}"
-      end
-    when "reset"
-      on(KAMAL.proxy_hosts) do |host|
-        execute *KAMAL.proxy.reset_boot_options
-      end
-    else
-      raise ArgumentError, "Unknown boot_config subcommand #{subcommand}"
-    end
-  end
-
-  desc "reboot", "Reboot proxy on servers (stop container, remove container, start new container)"
-  option :rolling, type: :boolean, default: false, desc: "Reboot proxy on hosts in sequence, rather than in parallel"
-  option :confirmed, aliases: "-y", type: :boolean, default: false, desc: "Proceed without confirmation question"
-  def reboot
-    confirming "This will cause a brief outage on each host. Are you sure?" do
-      with_lock do
-        host_groups = options[:rolling] ? KAMAL.proxy_hosts : [ KAMAL.proxy_hosts ]
-        host_groups.each do |hosts|
-          host_list = Array(hosts).join(",")
-          run_hook "pre-proxy-reboot", hosts: host_list
-          on(hosts) do |host|
-            execute *KAMAL.auditor.record("Rebooted proxy"), verbosity: :debug
-            execute *KAMAL.registry.login
-
-            "Stopping and removing Traefik on #{host}, if running..."
-            execute *KAMAL.proxy.cleanup_traefik
-
-            "Stopping and removing kamal-proxy on #{host}, if running..."
-            execute *KAMAL.proxy.stop, raise_on_non_zero_exit: false
-            execute *KAMAL.proxy.remove_container
-
-            execute *KAMAL.proxy.run
-
-            KAMAL.roles_on(host).select(&:running_proxy?).each do |role|
-              app = KAMAL.app(role: role, host: host)
-
-              version = capture_with_info(*app.current_running_version, raise_on_non_zero_exit: false).strip
-              endpoint = capture_with_info(*app.container_id_for_version(version)).strip
-
-              if endpoint.present?
-                info "Deploying #{endpoint} for role `#{role}` on #{host}..."
-                execute *app.deploy(target: endpoint)
-              end
-            end
-          end
-          run_hook "post-proxy-reboot", hosts: host_list
-        end
-      end
-    end
-  end
-
-  desc "upgrade", "Upgrade to kamal-proxy on servers (stop container, remove container, start new container, reboot app)", hide: true
-  option :rolling, type: :boolean, default: false, desc: "Reboot proxy on hosts in sequence, rather than in parallel"
-  option :confirmed, aliases: "-y", type: :boolean, default: false, desc: "Proceed without confirmation question"
-  def upgrade
-    invoke_options = { "version" => KAMAL.config.latest_tag }.merge(options)
-
-    confirming "This will cause a brief outage on each host. Are you sure?" do
-      host_groups = options[:rolling] ? KAMAL.hosts : [ KAMAL.hosts ]
-      host_groups.each do |hosts|
-        host_list = Array(hosts).join(",")
-        say "Upgrading proxy on #{host_list}...", :magenta
-        run_hook "pre-proxy-reboot", hosts: host_list
-        on(hosts) do |host|
-          execute *KAMAL.auditor.record("Rebooted proxy"), verbosity: :debug
-          execute *KAMAL.registry.login
-
-          "Stopping and removing Traefik on #{host}, if running..."
-          execute *KAMAL.proxy.cleanup_traefik
-
-          "Stopping and removing kamal-proxy on #{host}, if running..."
-          execute *KAMAL.proxy.stop, raise_on_non_zero_exit: false
-          execute *KAMAL.proxy.remove_container
-          execute *KAMAL.proxy.remove_image
-        end
-
-        KAMAL.with_specific_hosts(hosts) do
-          invoke "kamal:cli:proxy:boot", [], invoke_options
-          reset_invocation(Kamal::Cli::Proxy)
-          invoke "kamal:cli:app:boot", [], invoke_options
-          reset_invocation(Kamal::Cli::App)
-          invoke "kamal:cli:prune:all", [], invoke_options
-          reset_invocation(Kamal::Cli::Prune)
-        end
-
-        run_hook "post-proxy-reboot", hosts: host_list
-        say "Upgraded proxy on #{host_list}", :magenta
-      end
-    end
-  end
-
-  desc "start", "Start existing proxy container on servers"
-  def start
-    with_lock do
-      on(KAMAL.proxy_hosts) do |host|
-        execute *KAMAL.auditor.record("Started proxy"), verbosity: :debug
-        execute *KAMAL.proxy.start
-      end
-    end
-  end
-
-  desc "stop", "Stop existing proxy container on servers"
-  def stop
-    with_lock do
-      on(KAMAL.proxy_hosts) do |host|
-        execute *KAMAL.auditor.record("Stopped proxy"), verbosity: :debug
-        execute *KAMAL.proxy.stop, raise_on_non_zero_exit: false
-      end
-    end
-  end
-
-  desc "restart", "Restart existing proxy container on servers"
-  def restart
-    with_lock do
-      stop
-      start
-    end
-  end
-
-  desc "details", "Show details about proxy container from servers"
-  def details
-    on(KAMAL.proxy_hosts) { |host| puts_by_host host, capture_with_info(*KAMAL.proxy.info), type: "Proxy" }
-  end
-
-  desc "logs", "Show log lines from proxy on servers"
-  option :since, aliases: "-s", desc: "Show logs since timestamp (e.g. 2013-01-02T13:23:37Z) or relative (e.g. 42m for 42 minutes)"
-  option :lines, type: :numeric, aliases: "-n", desc: "Number of log lines to pull from each server"
-  option :grep, aliases: "-g", desc: "Show lines with grep match only (use this to fetch specific requests by id)"
-  option :follow, aliases: "-f", desc: "Follow logs on primary server (or specific host set by --hosts)"
-  option :skip_timestamps, type: :boolean, aliases: "-T", desc: "Skip appending timestamps to logging output"
-  def logs
-    grep = options[:grep]
-    timestamps = !options[:skip_timestamps]
-
-    if options[:follow]
-      run_locally do
-        info "Following logs on #{KAMAL.primary_host}..."
-        info KAMAL.proxy.follow_logs(host: KAMAL.primary_host, timestamps: timestamps, grep: grep)
-        exec KAMAL.proxy.follow_logs(host: KAMAL.primary_host, timestamps: timestamps, grep: grep)
-      end
-    else
-      since = options[:since]
-      lines = options[:lines].presence || ((since || grep) ? nil : 100) # Default to 100 lines if since or grep isn't set
-
-      on(KAMAL.proxy_hosts) do |host|
-        puts_by_host host, capture(*KAMAL.proxy.logs(timestamps: timestamps, since: since, lines: lines, grep: grep)), type: "Proxy"
-      end
-    end
-  end
-
-  desc "remove", "Remove proxy container and image from servers"
-  option :force, type: :boolean, default: false, desc: "Force removing proxy when apps are still installed"
-  def remove
-    with_lock do
-      if removal_allowed?(options[:force])
-        stop
-        remove_container
-        remove_image
-        remove_proxy_directory
-      end
-    end
-  end
-
-  desc "remove_container", "Remove proxy container from servers", hide: true
-  def remove_container
-    with_lock do
-      on(KAMAL.proxy_hosts) do
-        execute *KAMAL.auditor.record("Removed proxy container"), verbosity: :debug
-        execute *KAMAL.proxy.remove_container
-      end
-    end
-  end
-
-  desc "remove_image", "Remove proxy image from servers", hide: true
-  def remove_image
-    with_lock do
-      on(KAMAL.proxy_hosts) do
-        execute *KAMAL.auditor.record("Removed proxy image"), verbosity: :debug
-        execute *KAMAL.proxy.remove_image
-      end
-    end
-  end
-
-  desc "remove_proxy_directory", "Remove the proxy directory from servers", hide: true
-  def remove_proxy_directory
-    with_lock do
-      on(KAMAL.proxy_hosts) do
-        execute *KAMAL.proxy.remove_proxy_directory, raise_on_non_zero_exit: false
-      end
-    end
-  end
-
-  private
-    def removal_allowed?(force)
-      on(KAMAL.proxy_hosts) do |host|
-        app_count = capture_with_info(*KAMAL.server.app_directory_count).chomp.to_i
-        raise "The are other applications installed on #{host}" if app_count > 0
-      end
-
-      true
-    rescue SSHKit::Runner::ExecuteError => e
-      raise unless e.message.include?("The are other applications installed on")
-
-      if force
-        say "Forcing, so removing the proxy, even though other apps are installed", :magenta
-      else
-        say "Not removing the proxy, as other apps are installed, ignore this check with kamal proxy remove --force", :magenta
-      end
-
-      force
-    end
-end

lib/kamal/cli/prune.rb

@@ -1,7 +1,7 @@
 class Kamal::Cli::Prune < Kamal::Cli::Base
   desc "all", "Prune unused images and stopped containers"
   def all
-    with_lock do
+    mutating do
       containers
       images
     end
@@ -9,7 +9,7 @@ class Kamal::Cli::Prune < Kamal::Cli::Base
 
   desc "images", "Prune unused images"
   def images
-    with_lock do
+    mutating do
       on(KAMAL.hosts) do
         execute *KAMAL.auditor.record("Pruned images"), verbosity: :debug
         execute *KAMAL.prune.dangling_images
@@ -24,10 +24,11 @@ class Kamal::Cli::Prune < Kamal::Cli::Base
     retain = options.fetch(:retain, KAMAL.config.retain_containers)
     raise "retain must be at least 1" if retain < 1
 
-    with_lock do
+    mutating do
       on(KAMAL.hosts) do
         execute *KAMAL.auditor.record("Pruned containers"), verbosity: :debug
         execute *KAMAL.prune.app_containers(retain: retain)
+        execute *KAMAL.prune.healthcheck_containers
       end
     end
   end

lib/kamal/cli/registry.rb

@@ -1,17 +1,18 @@
 class Kamal::Cli::Registry < Kamal::Cli::Base
   desc "login", "Log in to registry locally and remotely"
-  option :skip_local, aliases: "-L", type: :boolean, default: false, desc: "Skip local login"
-  option :skip_remote, aliases: "-R", type: :boolean, default: false, desc: "Skip remote login"
   def login
-    run_locally    { execute *KAMAL.registry.login } unless options[:skip_local]
+    run_locally    { execute *KAMAL.registry.login }
-    on(KAMAL.hosts) { execute *KAMAL.registry.login } unless options[:skip_remote]
+    on(KAMAL.hosts) { execute *KAMAL.registry.login }
+  # FIXME: This rescue needed?
+  rescue ArgumentError => e
+    puts e.message
   end
 
-  desc "logout", "Log out of registry locally and remotely"
+  desc "logout", "Log out of registry remotely"
-  option :skip_local, aliases: "-L", type: :boolean, default: false, desc: "Skip local login"
-  option :skip_remote, aliases: "-R", type: :boolean, default: false, desc: "Skip remote login"
   def logout
-    run_locally    { execute *KAMAL.registry.logout } unless options[:skip_local]
+    on(KAMAL.hosts) { execute *KAMAL.registry.logout }
-    on(KAMAL.hosts) { execute *KAMAL.registry.logout } unless options[:skip_remote]
+  # FIXME: This rescue needed?
+  rescue ArgumentError => e
+    puts e.message
   end
 end

lib/kamal/cli/secrets.rb

@@ -1,43 +0,0 @@
-class Kamal::Cli::Secrets < Kamal::Cli::Base
-  desc "fetch [SECRETS...]", "Fetch secrets from a vault"
-  option :adapter, type: :string, aliases: "-a", required: true, desc: "Which vault adapter to use"
-  option :account, type: :string, required: true, desc: "The account identifier or username"
-  option :from, type: :string, required: false, desc: "A vault or folder to fetch the secrets from"
-  option :inline, type: :boolean, required: false, hidden: true
-  def fetch(*secrets)
-    results = adapter(options[:adapter]).fetch(secrets, **options.slice(:account, :from).symbolize_keys)
-
-    return_or_puts JSON.dump(results).shellescape, inline: options[:inline]
-  end
-
-  desc "extract", "Extract a single secret from the results of a fetch call"
-  option :inline, type: :boolean, required: false, hidden: true
-  def extract(name, secrets)
-    parsed_secrets = JSON.parse(secrets)
-    value = parsed_secrets[name] || parsed_secrets.find { |k, v| k.end_with?("/#{name}") }&.last
-
-    raise "Could not find secret #{name}" if value.nil?
-
-    return_or_puts value, inline: options[:inline]
-  end
-
-  desc "print", "Print the secrets (for debugging)"
-  def print
-    KAMAL.config.secrets.to_h.each do |key, value|
-      puts "#{key}=#{value}"
-    end
-  end
-
-  private
-    def adapter(adapter)
-      Kamal::Secrets::Adapters.lookup(adapter)
-    end
-
-    def return_or_puts(value, inline: nil)
-      if inline
-        value
-      else
-        puts value
-      end
-    end
-end

lib/kamal/cli/server.rb

@@ -1,30 +1,6 @@
 class Kamal::Cli::Server < Kamal::Cli::Base
-  desc "exec", "Run a custom command on the server (use --help to show options)"
-  option :interactive, type: :boolean, aliases: "-i", default: false, desc: "Run the command interactively (use for console/bash)"
-  def exec(*cmd)
-    cmd = Kamal::Utils.join_commands(cmd)
-    hosts = KAMAL.hosts | KAMAL.accessory_hosts
-
-    case
-    when options[:interactive]
-      host = KAMAL.primary_host
-
-      say "Running '#{cmd}' on #{host} interactively...", :magenta
-
-      run_locally { exec KAMAL.server.run_over_ssh(cmd, host: host) }
-    else
-      say "Running '#{cmd}' on #{hosts.join(', ')}...", :magenta
-
-      on(hosts) do |host|
-        execute *KAMAL.auditor.record("Executed cmd '#{cmd}' on #{host}"), verbosity: :debug
-        puts_by_host host, capture_with_info(cmd)
-      end
-    end
-  end
-
   desc "bootstrap", "Set up Docker to run Kamal apps"
   def bootstrap
-    with_lock do
     missing = []
 
     on(KAMAL.hosts | KAMAL.accessory_hosts) do |host|
@@ -36,6 +12,8 @@ class Kamal::Cli::Server < Kamal::Cli::Base
           missing << host
         end
       end
+
+      execute(*KAMAL.server.ensure_run_directory)
     end
 
     if missing.any?
@@ -45,4 +23,3 @@ class Kamal::Cli::Server < Kamal::Cli::Base
     run_hook "docker-setup"
   end
 end
-end

lib/kamal/cli/templates/deploy.yml

@@ -2,25 +2,11 @@
 service: my-app
 
 # Name of the container image.
-image: my-user/my-app
+image: user/my-app
 
 # Deploy to these servers.
 servers:
-  web:
   - 192.168.0.1
-  # job:
-  #   hosts:
-  #     - 192.168.0.1
-  #   cmd: bin/jobs
-
-# Enable SSL auto certification via Let's Encrypt (and allow for multiple apps on one server).
-# If using something like Cloudflare, it is recommended to set encryption mode 
-# in Cloudflare's SSL/TLS setting to "Full" to enable end-to-end encryption. 
-proxy: 
-  ssl: true
-  host: app.example.com
-  # kamal-proxy connects to your container over port 80, use `app_port` to specify a different port.
-  # app_port: 3000
 
 # Credentials for your image host.
 registry:
@@ -28,52 +14,33 @@ registry:
   # server: registry.digitalocean.com / ghcr.io / ...
   username: my-user
 
-  # Always use an access token rather than real password (pulled from .kamal/secrets).
+  # Always use an access token rather than real password when possible.
   password:
     - KAMAL_REGISTRY_PASSWORD
 
-# Configure builder setup.
+# Inject ENV variables into containers (secrets come from .env).
-builder:
+# Remember to run `kamal env push` after making changes!
-  arch: amd64
-
-# Inject ENV variables into containers (secrets come from .kamal/secrets).
-#
 # env:
 #   clear:
 #     DB_HOST: 192.168.0.2
 #   secret:
 #     - RAILS_MASTER_KEY
 
-# Aliases are triggered with "bin/kamal <alias>". You can overwrite arguments on invocation:
-# "bin/kamal logs -r job" will tail logs from the first server in the job section.
-#
-# aliases:
-#   shell: app exec --interactive --reuse "bash"
-
 # Use a different ssh user than root
-#
 # ssh:
 #   user: app
 
-# Use a persistent storage volume.
+# Configure builder setup.
-#
+# builder:
-# volumes:
+#   args:
-#   - "app_storage:/app/storage"
+#     RUBY_VERSION: 3.2.0
+#   secrets:
+#     - GITHUB_TOKEN
+#   remote:
+#     arch: amd64
+#     host: ssh://app@192.168.0.1
 
-# Bridge fingerprinted assets, like JS and CSS, between versions to avoid
+# Use accessory services (secrets come from .env).
-# hitting 404 on in-flight requests. Combines all files from new and old
-# version inside the asset_path.
-#
-# asset_path: /app/public/assets
-
-# Configure rolling deploys by setting a wait time between batches of restarts.
-#
-# boot:
-#   limit: 10 # Can also specify as a percentage of total hosts, such as "25%"
-#   wait: 2
-
-# Use accessory services (secrets come from .kamal/secrets).
-#
 # accessories:
 #   db:
 #     image: mysql:8.0
@@ -95,3 +62,40 @@ builder:
 #     port: 6379
 #     directories:
 #       - data:/data
+
+# Configure custom arguments for Traefik. Be sure to reboot traefik when you modify it.
+# traefik:
+#   args:
+#     accesslog: true
+#     accesslog.format: json
+
+# Configure a custom healthcheck (default is /up on port 3000)
+# healthcheck:
+#   path: /healthz
+#   port: 4000
+
+# Bridge fingerprinted assets, like JS and CSS, between versions to avoid
+# hitting 404 on in-flight requests. Combines all files from new and old
+# version inside the asset_path.
+#
+# If your app is using the Sprockets gem, ensure it sets `config.assets.manifest`.
+# See https://github.com/basecamp/kamal/issues/626 for details
+#
+# asset_path: /rails/public/assets
+
+# Configure rolling deploys by setting a wait time between batches of restarts.
+# boot:
+#   limit: 10 # Can also specify as a percentage of total hosts, such as "25%"
+#   wait: 2
+
+# Configure the role used to determine the primary_host. This host takes
+# deploy locks, runs health checks during the deploy, and follow logs, etc.
+#
+# Caution: there's no support for role renaming yet, so be careful to cleanup
+#          the previous role on the deployed hosts.
+# primary_role: web
+
+# Controls if we abort when see a role with no hosts. Disabling this may be
+# useful for more complex deploy configurations.
+#
+# allow_empty_roles: false

lib/kamal/cli/templates/sample_hooks/docker-setup.sample

@@ -1,3 +1,7 @@
-#!/bin/sh
+#!/usr/bin/env ruby
 
-echo "Docker set up on $KAMAL_HOSTS..."
+# A sample docker-setup hook
+#
+# Sets up a Docker network which can then be used by the application’s containers
+
+ssh user@example.com docker network create kamal

lib/kamal/cli/templates/sample_hooks/post-proxy-reboot.sample

@@ -1,3 +0,0 @@
-#!/bin/sh
-
-echo "Rebooted kamal-proxy on $KAMAL_HOSTS"

lib/kamal/cli/templates/sample_hooks/post-traefik-reboot.sample

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+echo "Rebooted Traefik on $KAMAL_HOSTS"

lib/kamal/cli/templates/sample_hooks/pre-proxy-reboot.sample

@@ -1,3 +0,0 @@
-#!/bin/sh
-
-echo "Rebooting kamal-proxy on $KAMAL_HOSTS..."

lib/kamal/cli/templates/sample_hooks/pre-traefik-reboot.sample

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+echo "Rebooting Traefik on $KAMAL_HOSTS..."

lib/kamal/cli/templates/secrets

@@ -1,17 +0,0 @@
-# Secrets defined here are available for reference under registry/password, env/secret, builder/secrets,
-# and accessories/*/env/secret in config/deploy.yml. All secrets should be pulled from either
-# password manager, ENV, or a file. DO NOT ENTER RAW CREDENTIALS HERE! This file needs to be safe for git.
-
-# Option 1: Read secrets from the environment
-KAMAL_REGISTRY_PASSWORD=$KAMAL_REGISTRY_PASSWORD
-
-# Option 2: Read secrets via a command
-# RAILS_MASTER_KEY=$(cat config/master.key)
-
-# Option 3: Read secrets via kamal secrets helpers
-# These will handle logging in and fetching the secrets in as few calls as possible
-# There are adapters for 1Password, LastPass + Bitwarden
-#
-# SECRETS=$(kamal secrets fetch --adapter 1password --account my-account --from MyVault/MyItem KAMAL_REGISTRY_PASSWORD RAILS_MASTER_KEY)
-# KAMAL_REGISTRY_PASSWORD=$(kamal secrets extract KAMAL_REGISTRY_PASSWORD $SECRETS)
-# RAILS_MASTER_KEY=$(kamal secrets extract RAILS_MASTER_KEY $SECRETS)

lib/kamal/cli/templates/template.env

@@ -0,0 +1,2 @@
+KAMAL_REGISTRY_PASSWORD=change-this
+RAILS_MASTER_KEY=another-env

lib/kamal/cli/traefik.rb

@@ -0,0 +1,120 @@
+class Kamal::Cli::Traefik < Kamal::Cli::Base
+  desc "boot", "Boot Traefik on servers"
+  def boot
+    mutating do
+      on(KAMAL.traefik_hosts) do
+        execute *KAMAL.registry.login
+        execute *KAMAL.traefik.start_or_run
+      end
+    end
+  end
+
+  desc "reboot", "Reboot Traefik on servers (stop container, remove container, start new container)"
+  option :rolling, type: :boolean, default: false, desc: "Reboot traefik on hosts in sequence, rather than in parallel"
+  option :confirmed, aliases: "-y", type: :boolean, default: false, desc: "Proceed without confirmation question"
+  def reboot
+    confirming "This will cause a brief outage on each host. Are you sure?" do
+      mutating do
+        host_groups = options[:rolling] ? KAMAL.traefik_hosts : [ KAMAL.traefik_hosts ]
+        host_groups.each do |hosts|
+          host_list = Array(hosts).join(",")
+          run_hook "pre-traefik-reboot", hosts: host_list
+          on(hosts) do
+            execute *KAMAL.auditor.record("Rebooted traefik"), verbosity: :debug
+            execute *KAMAL.registry.login
+            execute *KAMAL.traefik.stop, raise_on_non_zero_exit: false
+            execute *KAMAL.traefik.remove_container
+            execute *KAMAL.traefik.run
+          end
+          run_hook "post-traefik-reboot", hosts: host_list
+        end
+      end
+    end
+  end
+
+  desc "start", "Start existing Traefik container on servers"
+  def start
+    mutating do
+      on(KAMAL.traefik_hosts) do
+        execute *KAMAL.auditor.record("Started traefik"), verbosity: :debug
+        execute *KAMAL.traefik.start
+      end
+    end
+  end
+
+  desc "stop", "Stop existing Traefik container on servers"
+  def stop
+    mutating do
+      on(KAMAL.traefik_hosts) do
+        execute *KAMAL.auditor.record("Stopped traefik"), verbosity: :debug
+        execute *KAMAL.traefik.stop, raise_on_non_zero_exit: false
+      end
+    end
+  end
+
+  desc "restart", "Restart existing Traefik container on servers"
+  def restart
+    mutating do
+      stop
+      start
+    end
+  end
+
+  desc "details", "Show details about Traefik container from servers"
+  def details
+    on(KAMAL.traefik_hosts) { |host| puts_by_host host, capture_with_info(*KAMAL.traefik.info), type: "Traefik" }
+  end
+
+  desc "logs", "Show log lines from Traefik on servers"
+  option :since, aliases: "-s", desc: "Show logs since timestamp (e.g. 2013-01-02T13:23:37Z) or relative (e.g. 42m for 42 minutes)"
+  option :lines, type: :numeric, aliases: "-n", desc: "Number of log lines to pull from each server"
+  option :grep, aliases: "-g", desc: "Show lines with grep match only (use this to fetch specific requests by id)"
+  option :follow, aliases: "-f", desc: "Follow logs on primary server (or specific host set by --hosts)"
+  def logs
+    grep = options[:grep]
+
+    if options[:follow]
+      run_locally do
+        info "Following logs on #{KAMAL.primary_host}..."
+        info KAMAL.traefik.follow_logs(host: KAMAL.primary_host, grep: grep)
+        exec KAMAL.traefik.follow_logs(host: KAMAL.primary_host, grep: grep)
+      end
+    else
+      since = options[:since]
+      lines = options[:lines].presence || ((since || grep) ? nil : 100) # Default to 100 lines if since or grep isn't set
+
+      on(KAMAL.traefik_hosts) do |host|
+        puts_by_host host, capture(*KAMAL.traefik.logs(since: since, lines: lines, grep: grep)), type: "Traefik"
+      end
+    end
+  end
+
+  desc "remove", "Remove Traefik container and image from servers"
+  def remove
+    mutating do
+      stop
+      remove_container
+      remove_image
+    end
+  end
+
+  desc "remove_container", "Remove Traefik container from servers", hide: true
+  def remove_container
+    mutating do
+      on(KAMAL.traefik_hosts) do
+        execute *KAMAL.auditor.record("Removed traefik container"), verbosity: :debug
+        execute *KAMAL.traefik.remove_container
+      end
+    end
+  end
+
+  desc "remove_image", "Remove Traefik image from servers", hide: true
+  def remove_image
+    mutating do
+      on(KAMAL.traefik_hosts) do
+        execute *KAMAL.auditor.record("Removed traefik image"), verbosity: :debug
+        execute *KAMAL.traefik.remove_image
+      end
+    end
+  end
+end

lib/kamal/commander.rb

@@ -1,15 +1,14 @@
 require "active_support/core_ext/enumerable"
 require "active_support/core_ext/module/delegation"
-require "active_support/core_ext/object/blank"
 
 class Kamal::Commander
-  attr_accessor :verbosity, :holding_lock, :connected
+  attr_accessor :verbosity, :holding_lock, :hold_lock_on_error
-  delegate :hosts, :roles, :primary_host, :primary_role, :roles_on, :proxy_hosts, :accessory_hosts, to: :specifics
+  delegate :hosts, :roles, :primary_host, :primary_role, :roles_on, :traefik_hosts, :accessory_hosts, to: :specifics
 
   def initialize
     self.verbosity = :info
     self.holding_lock = false
-    self.connected = false
+    self.hold_lock_on_error = false
     @specifics = nil
   end
 
@@ -24,20 +23,12 @@ class Kamal::Commander
     @config, @config_kwargs = nil, kwargs
   end
 
-  def configured?
-    @config || @config_kwargs
-  end
-
   attr_reader :specific_roles, :specific_hosts
 
   def specific_primary!
     @specifics = nil
-    if specific_roles.present?
-      self.specific_hosts = [ specific_roles.first.primary_host ]
-    else
     self.specific_hosts = [ config.primary_host ]
   end
-  end
 
   def specific_roles=(role_names)
     @specifics = nil
@@ -65,13 +56,6 @@ class Kamal::Commander
     end
   end
 
-  def with_specific_hosts(hosts)
-    original_hosts, self.specific_hosts = specific_hosts, hosts
-    yield
-  ensure
-    self.specific_hosts = original_hosts
-  end
-
   def accessory_names
     config.accessories&.collect(&:name) || []
   end
@@ -81,8 +65,8 @@ class Kamal::Commander
   end
 
 
-  def app(role: nil, host: nil)
+  def app(role: nil)
-    Kamal::Commands::App.new(config, role: role, host: host)
+    Kamal::Commands::App.new(config, role: role)
   end
 
   def accessory(name)
@@ -101,6 +85,10 @@ class Kamal::Commander
     @docker ||= Kamal::Commands::Docker.new(config)
   end
 
+  def healthcheck
+    @healthcheck ||= Kamal::Commands::Healthcheck.new(config)
+  end
+
   def hook
     @hook ||= Kamal::Commands::Hook.new(config)
   end
@@ -109,10 +97,6 @@ class Kamal::Commander
     @lock ||= Kamal::Commands::Lock.new(config)
   end
 
-  def proxy
-    @proxy ||= Kamal::Commands::Proxy.new(config)
-  end
-
   def prune
     @prune ||= Kamal::Commands::Prune.new(config)
   end
@@ -125,8 +109,8 @@ class Kamal::Commander
     @server ||= Kamal::Commands::Server.new(config)
   end
 
-  def alias(name)
+  def traefik
-    config.aliases[name]
+    @traefik ||= Kamal::Commands::Traefik.new(config)
   end
 
 
@@ -154,8 +138,8 @@ class Kamal::Commander
     self.holding_lock
   end
 
-  def connected?
+  def hold_lock_on_error?
-    self.connected
+    self.hold_lock_on_error
   end
 
   private

lib/kamal/commander/specifics.rb

@@ -18,12 +18,12 @@ class Kamal::Commander::Specifics
     roles.select { |role| role.hosts.include?(host.to_s) }
   end
 
-  def proxy_hosts
+  def traefik_hosts
-    config.proxy_hosts & specified_hosts
+    specific_hosts || config.traefik_hosts
   end
 
   def accessory_hosts
-    config.accessories.flat_map(&:hosts) & specified_hosts
+    specific_hosts || config.accessories.flat_map(&:hosts)
   end
 
   private
@@ -43,12 +43,7 @@ class Kamal::Commander::Specifics
     end
 
     def specified_hosts
-      specified_hosts = specific_hosts || config.all_hosts
+      (specific_hosts || config.all_hosts) \
-
+        .select { |host| (specific_roles || config.roles).flat_map(&:hosts).include?(host) }
-      if (specific_role_hosts = specific_roles&.flat_map(&:hosts)).present?
-        specified_hosts.select { |host| specific_role_hosts.include?(host) }
-      else
-        specified_hosts
-      end
     end
 end

lib/kamal/commands/accessory.rb

@@ -1,9 +1,7 @@
 class Kamal::Commands::Accessory < Kamal::Commands::Base
   attr_reader :accessory_config
   delegate :service_name, :image, :hosts, :port, :files, :directories, :cmd,
-           :publish_args, :env_args, :volume_args, :label_args, :option_args,
+           :publish_args, :env_args, :volume_args, :label_args, :option_args, to: :accessory_config
-           :secrets_io, :secrets_path, :env_directory,
-           to: :accessory_config
 
   def initialize(config, name:)
     super(config)
@@ -15,7 +13,6 @@ class Kamal::Commands::Accessory < Kamal::Commands::Base
       "--name", service_name,
       "--detach",
       "--restart", "unless-stopped",
-      "--network", "kamal",
       *config.logging_args,
       *publish_args,
       *env_args,
@@ -39,17 +36,17 @@ class Kamal::Commands::Accessory < Kamal::Commands::Base
   end
 
 
-  def logs(timestamps: true, since: nil, lines: nil, grep: nil, grep_options: nil)
+  def logs(since: nil, lines: nil, grep: nil)
     pipe \
-      docker(:logs, service_name, (" --since #{since}" if since), (" --tail #{lines}" if lines), ("--timestamps" if timestamps), "2>&1"),
+      docker(:logs, service_name, (" --since #{since}" if since), (" --tail #{lines}" if lines), "--timestamps", "2>&1"),
-      ("grep '#{grep}'#{" #{grep_options}" if grep_options}" if grep)
+      ("grep '#{grep}'" if grep)
   end
 
-  def follow_logs(timestamps: true, grep: nil, grep_options: nil)
+  def follow_logs(grep: nil)
     run_over_ssh \
       pipe \
-        docker(:logs, service_name, ("--timestamps" if timestamps), "--tail", "10", "--follow", "2>&1"),
+        docker(:logs, service_name, "--timestamps", "--tail", "10", "--follow", "2>&1"),
-        (%(grep "#{grep}"#{" #{grep_options}" if grep_options}) if grep)
+        (%(grep "#{grep}") if grep)
   end
 
 
@@ -64,7 +61,6 @@ class Kamal::Commands::Accessory < Kamal::Commands::Base
     docker :run,
       ("-it" if interactive),
       "--rm",
-      "--network", "kamal",
       *env_args,
       *volume_args,
       image,
@@ -102,8 +98,12 @@ class Kamal::Commands::Accessory < Kamal::Commands::Base
     docker :image, :rm, "--force", image
   end
 
-  def ensure_env_directory
+  def make_env_directory
-    make_directory env_directory
+    make_directory accessory_config.env.secrets_directory
+  end
+
+  def remove_env_file
+    [ :rm, "-f", accessory_config.env.secrets_file ]
   end
 
   private

lib/kamal/commands/app.rb

@@ -1,16 +1,13 @@
 class Kamal::Commands::App < Kamal::Commands::Base
-  include Assets, Containers, Execution, Images, Logging, Proxy
+  include Assets, Containers, Cord, Execution, Images, Logging
 
   ACTIVE_DOCKER_STATUSES = [ :running, :restarting ]
 
-  attr_reader :role, :host
+  attr_reader :role
 
-  delegate :container_name, to: :role
+  def initialize(config, role: nil)
-
-  def initialize(config, role: nil, host: nil)
     super(config)
     @role = role
-    @host = host
   end
 
   def run(hostname: nil)
@@ -18,11 +15,11 @@ class Kamal::Commands::App < Kamal::Commands::Base
       "--detach",
       "--restart unless-stopped",
       "--name", container_name,
-      "--network", "kamal",
       *([ "--hostname", hostname ] if hostname),
       "-e", "KAMAL_CONTAINER_NAME=\"#{container_name}\"",
       "-e", "KAMAL_VERSION=\"#{config.version}\"",
-      *role.env_args(host),
+      *role.env_args,
+      *role.health_check_args,
       *role.logging_args,
       *config.volume_args,
       *role.asset_volume_args,
@@ -43,7 +40,7 @@ class Kamal::Commands::App < Kamal::Commands::Base
   def stop(version: nil)
     pipe \
       version ? container_id_for_version(version) : current_running_container_id,
-      xargs(docker(:stop, *role.stop_args))
+      xargs(config.stop_wait_time ? docker(:stop, "-t", config.stop_wait_time) : docker(:stop))
   end
 
   def info
@@ -71,11 +68,21 @@ class Kamal::Commands::App < Kamal::Commands::Base
       extract_version_from_name
   end
 
-  def ensure_env_directory
+
-    make_directory role.env_directory
+  def make_env_directory
+    make_directory role.env.secrets_directory
   end
 
+  def remove_env_file
+    [ :rm, "-f", role.env.secrets_file ]
+  end
+
+
   private
+    def container_name(version = nil)
+      [ role.container_prefix, version || config.version ].compact.join("-")
+    end
+
     def latest_image_id
       docker :image, :ls, *argumentize("--filter", "reference=#{config.latest_image}"), "--format", "'{{.ID}}'"
     end

lib/kamal/commands/app/assets.rb

@@ -3,18 +3,18 @@ module Kamal::Commands::App::Assets
     asset_container = "#{role.container_prefix}-assets"
 
     combine \
-      make_directory(role.asset_extracted_directory),
+      make_directory(role.asset_extracted_path),
       [ *docker(:stop, "-t 1", asset_container, "2> /dev/null"), "|| true" ],
-      docker(:run, "--name", asset_container, "--detach", "--rm", "--entrypoint", "sleep", config.absolute_image, "1000000"),
+      docker(:run, "--name", asset_container, "--detach", "--rm", config.absolute_image, "sleep 1000000"),
-      docker(:cp, "-L", "#{asset_container}:#{role.asset_path}/.", role.asset_extracted_directory),
+      docker(:cp, "-L", "#{asset_container}:#{role.asset_path}/.", role.asset_extracted_path),
       docker(:stop, "-t 1", asset_container),
       by: "&&"
   end
 
   def sync_asset_volumes(old_version: nil)
-    new_extracted_path, new_volume_path = role.asset_extracted_directory(config.version), role.asset_volume.host_path
+    new_extracted_path, new_volume_path = role.asset_extracted_path(config.version), role.asset_volume.host_path
     if old_version.present?
-      old_extracted_path, old_volume_path = role.asset_extracted_directory(old_version), role.asset_volume(old_version).host_path
+      old_extracted_path, old_volume_path = role.asset_extracted_path(old_version), role.asset_volume(old_version).host_path
     end
 
     commands = [ make_directory(new_volume_path), copy_contents(new_extracted_path, new_volume_path) ]
@@ -29,8 +29,8 @@ module Kamal::Commands::App::Assets
 
   def clean_up_assets
     chain \
-      find_and_remove_older_siblings(role.asset_extracted_directory),
+      find_and_remove_older_siblings(role.asset_extracted_path),
-      find_and_remove_older_siblings(role.asset_volume_directory)
+      find_and_remove_older_siblings(role.asset_volume_path)
   end
 
   private
@@ -39,7 +39,7 @@ module Kamal::Commands::App::Assets
         :find,
         Pathname.new(path).dirname.to_s,
         "-maxdepth 1",
-        "-name", "'#{role.name}-*'",
+        "-name", "'#{role.container_prefix}-*'",
         "!", "-name", Pathname.new(path).basename.to_s,
         "-exec rm -rf \"{}\" +"
       ]

lib/kamal/commands/app/containers.rb

@@ -1,6 +1,4 @@
 module Kamal::Commands::App::Containers
-  DOCKER_HEALTH_LOG_FORMAT    = "'{{json .State.Health}}'"
-
   def list_containers
     docker :container, :ls, "--all", *filter_args
   end
@@ -22,10 +20,4 @@ module Kamal::Commands::App::Containers
   def remove_containers
     docker :container, :prune, "--force", *filter_args
   end
-
-  def container_health_log(version:)
-    pipe \
-      container_id_for(container_name: container_name(version)),
-      xargs(docker(:inspect, "--format", DOCKER_HEALTH_LOG_FORMAT))
-  end
 end

lib/kamal/commands/app/cord.rb

@@ -0,0 +1,22 @@
+module Kamal::Commands::App::Cord
+  def cord(version:)
+    pipe \
+      docker(:inspect, "-f '{{ range .Mounts }}{{printf \"%s %s\\n\" .Source .Destination}}{{ end }}'", container_name(version)),
+      [ :awk, "'$2 == \"#{role.cord_volume.container_path}\" {print $1}'" ]
+  end
+
+  def tie_cord(cord)
+    create_empty_file(cord)
+  end
+
+  def cut_cord(cord)
+    remove_directory(cord)
+  end
+
+  private
+    def create_empty_file(file)
+      chain \
+        make_directory_for(file),
+        [ :touch, file ]
+    end
+end

lib/kamal/commands/app/execution.rb

@@ -11,8 +11,7 @@ module Kamal::Commands::App::Execution
     docker :run,
       ("-it" if interactive),
       "--rm",
-      "--network", "kamal",
+      *role&.env_args,
-      *role&.env_args(host),
       *argumentize("--env", env),
       *config.volume_args,
       *role&.option_args,
@@ -20,11 +19,11 @@ module Kamal::Commands::App::Execution
       *command
   end
 
-  def execute_in_existing_container_over_ssh(*command,  env:)
+  def execute_in_existing_container_over_ssh(*command, host:, env:)
     run_over_ssh execute_in_existing_container(*command, interactive: true, env: env), host: host
   end
 
-  def execute_in_new_container_over_ssh(*command, env:)
+  def execute_in_new_container_over_ssh(*command, host:, env:)
     run_over_ssh execute_in_new_container(*command, interactive: true, env: env), host: host
   end
 end

lib/kamal/commands/app/logging.rb

@@ -1,17 +1,17 @@
 module Kamal::Commands::App::Logging
-  def logs(version: nil, timestamps: true, since: nil, lines: nil, grep: nil, grep_options: nil)
+  def logs(since: nil, lines: nil, grep: nil)
     pipe \
-      version ? container_id_for_version(version) : current_running_container_id,
+      current_running_container_id,
-      "xargs docker logs#{" --timestamps" if timestamps}#{" --since #{since}" if since}#{" --tail #{lines}" if lines} 2>&1",
+      "xargs docker logs#{" --since #{since}" if since}#{" --tail #{lines}" if lines} 2>&1",
-      ("grep '#{grep}'#{" #{grep_options}" if grep_options}" if grep)
+      ("grep '#{grep}'" if grep)
   end
 
-  def follow_logs(host:, timestamps: true, lines: nil, grep: nil, grep_options: nil)
+  def follow_logs(host:, lines: nil, grep: nil)
     run_over_ssh \
       pipe(
         current_running_container_id,
-        "xargs docker logs#{" --timestamps" if timestamps}#{" --tail #{lines}" if lines} --follow 2>&1",
+        "xargs docker logs --timestamps#{" --tail #{lines}" if lines} --follow 2>&1",
-        (%(grep "#{grep}"#{" #{grep_options}" if grep_options}) if grep)
+        (%(grep "#{grep}") if grep)
       ),
       host: host
   end

lib/kamal/commands/app/proxy.rb

@@ -1,16 +0,0 @@
-module Kamal::Commands::App::Proxy
-  delegate :proxy_container_name, to: :config
-
-  def deploy(target:)
-    proxy_exec :deploy, role.container_prefix, *role.proxy.deploy_command_args(target: target)
-  end
-
-  def remove
-    proxy_exec :remove, role.container_prefix
-  end
-
-  private
-    def proxy_exec(*command)
-      docker :exec, proxy_container_name, "kamal-proxy", *command
-    end
-end

lib/kamal/commands/auditor.rb

@@ -8,12 +8,9 @@ class Kamal::Commands::Auditor < Kamal::Commands::Base
 
   # Runs remotely
   def record(line, **details)
-    combine \
+    append \
-      [ :mkdir, "-p", config.run_directory ],
+      [ :echo, audit_tags(**details).except(:version, :service_version).to_s, line ],
-      append(
-        [ :echo, audit_tags(**details).except(:version, :service_version, :service).to_s, line ],
       audit_log_file
-      )
   end
 
   def reveal

lib/kamal/commands/base.rb

@@ -3,6 +3,7 @@ module Kamal::Commands
     delegate :sensitive, :argumentize, to: Kamal::Utils
 
     DOCKER_HEALTH_STATUS_FORMAT = "'{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}'"
+    DOCKER_HEALTH_LOG_FORMAT    = "'{{json .State.Health}}'"
 
     attr_accessor :config
 
@@ -17,7 +18,7 @@ module Kamal::Commands
         elsif config.ssh.proxy && config.ssh.proxy.is_a?(Net::SSH::Proxy::Command)
           cmd << " -o ProxyCommand='#{config.ssh.proxy.command_line_template}'"
         end
-        cmd << " -t #{config.ssh.user}@#{host} -p #{config.ssh.port} '#{command.join(" ").gsub("'", "'\\\\''")}'"
+        cmd << " -t #{config.ssh.user}@#{host} -p #{config.ssh.port} '#{command.join(" ")}'"
       end
     end
 
@@ -37,10 +38,6 @@ module Kamal::Commands
       [ :rm, "-r", path ]
     end
 
-    def remove_file(path)
-      [ :rm, path ]
-    end
-
     private
       def combine(*commands, by: "&&")
         commands
@@ -81,12 +78,8 @@ module Kamal::Commands
         args.compact.unshift :docker
       end
 
-      def git(*args, path: nil)
+      def git(*args)
-        [ :git, *([ "-C", path ] if path), *args.compact ]
+        args.compact.unshift :git
-      end
-
-      def grep(*args)
-        args.compact.unshift :grep
       end
 
       def tags(**details)

lib/kamal/commands/builder.rb

@@ -1,37 +1,45 @@
 require "active_support/core_ext/string/filters"
 
 class Kamal::Commands::Builder < Kamal::Commands::Base
-  delegate :create, :remove, :push, :clean, :pull, :info, :inspect_builder, :validate_image, :first_mirror, to: :target
+  delegate :create, :remove, :push, :clean, :pull, :info, :validate_image, to: :target
-  delegate :local?, :remote?, to: "config.builder"
-
-  include Clone
 
   def name
     target.class.to_s.remove("Kamal::Commands::Builder::").underscore.inquiry
   end
 
   def target
-    if remote?
+    case
-      if local?
+    when !config.builder.multiarch? && !config.builder.cached?
-        hybrid
+      native
+    when !config.builder.multiarch? && config.builder.cached?
+      native_cached
+    when config.builder.local? && config.builder.remote?
+      multiarch_remote
+    when config.builder.remote?
+      native_remote
     else
-        remote
+      multiarch
-      end
-    else
-      local
     end
   end
 
-  def remote
+  def native
-    @remote ||= Kamal::Commands::Builder::Remote.new(config)
+    @native ||= Kamal::Commands::Builder::Native.new(config)
   end
 
-  def local
+  def native_cached
-    @local ||= Kamal::Commands::Builder::Local.new(config)
+    @native ||= Kamal::Commands::Builder::Native::Cached.new(config)
   end
 
-  def hybrid
+  def native_remote
-    @hybrid ||= Kamal::Commands::Builder::Hybrid.new(config)
+    @native ||= Kamal::Commands::Builder::Native::Remote.new(config)
+  end
+
+  def multiarch
+    @multiarch ||= Kamal::Commands::Builder::Multiarch.new(config)
+  end
+
+  def multiarch_remote
+    @multiarch_remote ||= Kamal::Commands::Builder::Multiarch::Remote.new(config)
   end
 
 

lib/kamal/commands/builder/base.rb

@@ -1,43 +1,30 @@
+
 class Kamal::Commands::Builder::Base < Kamal::Commands::Base
   class BuilderError < StandardError; end
 
-  ENDPOINT_DOCKER_HOST_INSPECT = "'{{.Endpoints.docker.Host}}'"
-
   delegate :argumentize, to: Kamal::Utils
-  delegate \
+  delegate :args, :secrets, :dockerfile, :local_arch, :local_host, :remote_arch, :remote_host, :cache_from, :cache_to, :ssh, :git_archive?, to: :builder_config
-    :args, :secrets, :dockerfile, :target, :arches, :local_arches, :remote_arches, :remote,
-    :cache_from, :cache_to, :ssh, :driver, :docker_driver?,
-    to: :builder_config
 
   def clean
     docker :image, :rm, "--force", config.absolute_image
   end
 
-  def push
-    docker :buildx, :build,
-      "--push",
-      *platform_options(arches),
-      *([ "--builder", builder_name ] unless docker_driver?),
-      *build_options,
-      build_context
-  end
-
   def pull
     docker :pull, config.absolute_image
   end
 
-  def info
+  def push
-    combine \
+    if git_archive?
-      docker(:context, :ls),
+      pipe \
-      docker(:buildx, :ls)
+        git(:archive, "--format=tar", :HEAD),
+        build_and_push
+    else
+      build_and_push
     end
-
-  def inspect_builder
-    docker :buildx, :inspect, builder_name unless docker_driver?
   end
 
   def build_options
-    [ *build_tags, *build_cache, *build_labels, *build_args, *build_secrets, *build_dockerfile, *build_target, *build_ssh ]
+    [ *build_tags, *build_cache, *build_labels, *build_args, *build_secrets, *build_dockerfile, *build_ssh ]
   end
 
   def build_context
@@ -53,9 +40,6 @@ class Kamal::Commands::Builder::Base < Kamal::Commands::Base
       )
   end
 
-  def first_mirror
-    docker(:info, "--format '{{index .RegistryConfig.Mirrors 0}}'")
-  end
 
   private
     def build_tags
@@ -78,7 +62,7 @@ class Kamal::Commands::Builder::Base < Kamal::Commands::Base
     end
 
     def build_secrets
-      argumentize "--secret", secrets.keys.collect { |secret| [ "id", secret ] }
+      argumentize "--secret", secrets.collect { |secret| [ "id", secret ] }
     end
 
     def build_dockerfile
@@ -89,10 +73,6 @@ class Kamal::Commands::Builder::Base < Kamal::Commands::Base
       end
     end
 
-    def build_target
-      argumentize "--target", target if target.present?
-    end
-
     def build_ssh
       argumentize "--ssh", ssh if ssh.present?
     end
@@ -100,8 +80,4 @@ class Kamal::Commands::Builder::Base < Kamal::Commands::Base
     def builder_config
       config.builder
     end
-
-    def platform_options(arches)
-      argumentize "--platform", arches.map { |arch| "linux/#{arch}" }.join(",") if arches.any?
-    end
 end

lib/kamal/commands/builder/clone.rb

@@ -1,29 +0,0 @@
-module Kamal::Commands::Builder::Clone
-  extend ActiveSupport::Concern
-
-  included do
-    delegate :clone_directory, :build_directory, to: :"config.builder"
-  end
-
-  def clone
-    git :clone, Kamal::Git.root, "--recurse-submodules", path: clone_directory
-  end
-
-  def clone_reset_steps
-    [
-      git(:remote, "set-url", :origin, Kamal::Git.root, path: build_directory),
-      git(:fetch, :origin, path: build_directory),
-      git(:reset, "--hard", Kamal::Git.revision, path: build_directory),
-      git(:clean, "-fdx", path: build_directory),
-      git(:submodule, :update, "--init", path: build_directory)
-    ]
-  end
-
-  def clone_status
-    git :status, "--porcelain", path: build_directory
-  end
-
-  def clone_revision
-    git :"rev-parse", :HEAD, path: build_directory
-  end
-end

lib/kamal/commands/builder/hybrid.rb

@@ -1,21 +0,0 @@
-class Kamal::Commands::Builder::Hybrid < Kamal::Commands::Builder::Remote
-  def create
-    combine \
-      create_local_buildx,
-      create_remote_context,
-      append_remote_buildx
-  end
-
-  private
-    def builder_name
-      "kamal-hybrid-#{driver}-#{remote.gsub(/[^a-z0-9_-]/, "-")}"
-    end
-
-    def create_local_buildx
-      docker :buildx, :create, *platform_options(local_arches), "--name", builder_name, "--driver=#{driver}"
-    end
-
-    def append_remote_buildx
-      docker :buildx, :create, *platform_options(remote_arches), "--append", "--name", builder_name, remote_context_name
-    end
-end

lib/kamal/commands/builder/local.rb

@@ -1,14 +0,0 @@
-class Kamal::Commands::Builder::Local < Kamal::Commands::Builder::Base
-  def create
-    docker :buildx, :create, "--name", builder_name, "--driver=#{driver}" unless docker_driver?
-  end
-
-  def remove
-    docker :buildx, :rm, builder_name unless docker_driver?
-  end
-
-  private
-    def builder_name
-      "kamal-local-#{driver}"
-    end
-end

lib/kamal/commands/builder/multiarch.rb

@@ -0,0 +1,37 @@
+class Kamal::Commands::Builder::Multiarch < Kamal::Commands::Builder::Base
+  def create
+    docker :buildx, :create, "--use", "--name", builder_name
+  end
+
+  def remove
+    docker :buildx, :rm, builder_name
+  end
+
+  def info
+    combine \
+      docker(:context, :ls),
+      docker(:buildx, :ls)
+  end
+
+  private
+    def builder_name
+      "kamal-#{config.service}-multiarch"
+    end
+
+    def platform_names
+      if local_arch
+        "linux/#{local_arch}"
+      else
+        "linux/amd64,linux/arm64"
+      end
+    end
+
+    def build_and_push
+      docker :buildx, :build,
+        "--push",
+        "--platform", platform_names,
+        "--builder", builder_name,
+        *build_options,
+        build_context
+    end
+end

lib/kamal/commands/builder/multiarch/remote.rb

@@ -0,0 +1,51 @@
+class Kamal::Commands::Builder::Multiarch::Remote < Kamal::Commands::Builder::Multiarch
+  def create
+    combine \
+      create_contexts,
+      create_local_buildx,
+      append_remote_buildx
+  end
+
+  def remove
+    combine \
+      remove_contexts,
+      super
+  end
+
+  private
+    def builder_name
+      super + "-remote"
+    end
+
+    def builder_name_with_arch(arch)
+      "#{builder_name}-#{arch}"
+    end
+
+    def create_local_buildx
+      docker :buildx, :create, "--name", builder_name, builder_name_with_arch(local_arch), "--platform", "linux/#{local_arch}"
+    end
+
+    def append_remote_buildx
+      docker :buildx, :create, "--append", "--name", builder_name, builder_name_with_arch(remote_arch), "--platform", "linux/#{remote_arch}"
+    end
+
+    def create_contexts
+      combine \
+        create_context(local_arch, local_host),
+        create_context(remote_arch, remote_host)
+    end
+
+    def create_context(arch, host)
+      docker :context, :create, builder_name_with_arch(arch), "--description", "'#{builder_name} #{arch} native host'", "--docker", "'host=#{host}'"
+    end
+
+    def remove_contexts
+      combine \
+        remove_context(local_arch),
+        remove_context(remote_arch)
+    end
+
+    def remove_context(arch)
+      docker :context, :rm, builder_name_with_arch(arch)
+    end
+end

lib/kamal/commands/builder/native.rb

@@ -0,0 +1,21 @@
+class Kamal::Commands::Builder::Native < Kamal::Commands::Builder::Base
+  def create
+    # No-op on native without cache
+  end
+
+  def remove
+    # No-op on native without cache
+  end
+
+  def info
+    # No-op on native
+  end
+
+  private
+    def build_and_push
+      combine \
+        docker(:build, *build_options, build_context),
+        docker(:push, config.absolute_image),
+        docker(:push, config.latest_image)
+    end
+end

lib/kamal/commands/builder/native/cached.rb

@@ -0,0 +1,17 @@
+class Kamal::Commands::Builder::Native::Cached < Kamal::Commands::Builder::Native
+  def create
+    docker :buildx, :create, "--use", "--driver=docker-container"
+  end
+
+  def remove
+    docker :buildx, :rm, builder_name
+  end
+
+  private
+    def build_and_push
+      docker :buildx, :build,
+        "--push",
+        *build_options,
+        build_context
+    end
+end

lib/kamal/commands/builder/native/remote.rb

@@ -0,0 +1,59 @@
+class Kamal::Commands::Builder::Native::Remote < Kamal::Commands::Builder::Native
+  def create
+    chain \
+      create_context,
+      create_buildx
+  end
+
+  def remove
+    chain \
+      remove_context,
+      remove_buildx
+  end
+
+  def info
+    chain \
+      docker(:context, :ls),
+      docker(:buildx, :ls)
+  end
+
+
+  private
+    def builder_name
+      "kamal-#{config.service}-native-remote"
+    end
+
+    def builder_name_with_arch
+      "#{builder_name}-#{remote_arch}"
+    end
+
+    def platform
+      "linux/#{remote_arch}"
+    end
+
+    def create_context
+      docker :context, :create,
+        builder_name_with_arch, "--description", "'#{builder_name} #{remote_arch} native host'", "--docker", "'host=#{remote_host}'"
+    end
+
+    def remove_context
+      docker :context, :rm, builder_name_with_arch
+    end
+
+    def create_buildx
+      docker :buildx, :create, "--name", builder_name, builder_name_with_arch, "--platform", platform
+    end
+
+    def remove_buildx
+      docker :buildx, :rm, builder_name
+    end
+
+    def build_and_push
+      docker :buildx, :build,
+      "--push",
+      "--platform", platform,
+      "--builder", builder_name,
+      *build_options,
+      build_context
+    end
+end

lib/kamal/commands/builder/remote.rb

@@ -1,63 +0,0 @@
-class Kamal::Commands::Builder::Remote < Kamal::Commands::Builder::Base
-  def create
-    chain \
-      create_remote_context,
-      create_buildx
-  end
-
-  def remove
-    chain \
-      remove_remote_context,
-      remove_buildx
-  end
-
-  def info
-    chain \
-      docker(:context, :ls),
-      docker(:buildx, :ls)
-  end
-
-  def inspect_builder
-    combine \
-      combine inspect_buildx, inspect_remote_context,
-      [ "(echo no compatible builder && exit 1)" ],
-      by: "||"
-  end
-
-  private
-    def builder_name
-      "kamal-remote-#{remote.gsub(/[^a-z0-9_-]/, "-")}"
-    end
-
-    def remote_context_name
-      "#{builder_name}-context"
-    end
-
-    def inspect_buildx
-      pipe \
-        docker(:buildx, :inspect, builder_name),
-        grep("-q", "Endpoint:.*#{remote_context_name}")
-    end
-
-    def inspect_remote_context
-      pipe \
-        docker(:context, :inspect, remote_context_name, "--format", ENDPOINT_DOCKER_HOST_INSPECT),
-        grep("-xq", remote)
-    end
-
-    def create_remote_context
-      docker :context, :create, remote_context_name, "--description", "'#{builder_name} host'", "--docker", "'host=#{remote}'"
-    end
-
-    def remove_remote_context
-      docker :context, :rm, remote_context_name
-    end
-
-    def create_buildx
-      docker :buildx, :create, "--name", builder_name, remote_context_name
-    end
-
-    def remove_buildx
-      docker :buildx, :rm, builder_name
-    end
-end

lib/kamal/commands/docker.rb

@@ -19,10 +19,6 @@ class Kamal::Commands::Docker < Kamal::Commands::Base
     [ '[ "${EUID:-$(id -u)}" -eq 0 ] || command -v sudo >/dev/null || command -v su >/dev/null' ]
   end
 
-  def create_network
-    docker :network, :create, :kamal
-  end
-
   private
     def get_docker
       shell \

lib/kamal/commands/healthcheck.rb

@@ -0,0 +1,59 @@
+class Kamal::Commands::Healthcheck < Kamal::Commands::Base
+  def run
+    primary = config.role(config.primary_role)
+
+    docker :run,
+      "--detach",
+      "--name", container_name_with_version,
+      "--publish", "#{exposed_port}:#{config.healthcheck["port"]}",
+      "--label", "service=#{config.healthcheck_service}",
+      "-e", "KAMAL_CONTAINER_NAME=\"#{config.healthcheck_service}\"",
+      *primary.env_args,
+      *primary.health_check_args(cord: false),
+      *config.volume_args,
+      *primary.option_args,
+      config.absolute_image,
+      primary.cmd
+  end
+
+  def status
+    pipe container_id, xargs(docker(:inspect, "--format", DOCKER_HEALTH_STATUS_FORMAT))
+  end
+
+  def container_health_log
+    pipe container_id, xargs(docker(:inspect, "--format", DOCKER_HEALTH_LOG_FORMAT))
+  end
+
+  def logs
+    pipe container_id, xargs(docker(:logs, "--tail", log_lines, "2>&1"))
+  end
+
+  def stop
+    pipe container_id, xargs(docker(:stop))
+  end
+
+  def remove
+    pipe container_id, xargs(docker(:container, :rm))
+  end
+
+  private
+    def container_name_with_version
+      "#{config.healthcheck_service}-#{config.version}"
+    end
+
+    def container_id
+      container_id_for(container_name: container_name_with_version)
+    end
+
+    def health_url
+      "http://localhost:#{exposed_port}#{config.healthcheck["path"]}"
+    end
+
+    def exposed_port
+      config.healthcheck["exposed_port"]
+    end
+
+    def log_lines
+      config.healthcheck["log_lines"]
+    end
+end

lib/kamal/commands/hook.rb

@@ -1,12 +1,6 @@
 class Kamal::Commands::Hook < Kamal::Commands::Base
-  def run(hook)
+  def run(hook, **details)
-    [ hook_file(hook) ]
+    [ hook_file(hook), env: tags(**details).env ]
-  end
-
-  def env(secrets: false, **details)
-    tags(**details).env.tap do |env|
-      env.merge!(config.secrets.to_h) if secrets
-    end
   end
 
   def hook_exists?(hook)

lib/kamal/commands/lock.rb

@@ -44,10 +44,14 @@ class Kamal::Commands::Lock < Kamal::Commands::Base
         "/dev/null"
     end
 
-    def lock_dir
+    def locks_dir
-      dir_name = [ "lock", config.service, config.destination ].compact.join("-")
+      File.join(config.run_directory, "locks")
+    end
 
-      File.join(config.run_directory, dir_name)
+    def lock_dir
+      dir_name = [ config.service, config.destination ].compact.join("-")
+
+      File.join(locks_dir, dir_name)
     end
 
     def lock_details_file

lib/kamal/commands/proxy.rb

@@ -1,87 +0,0 @@
-class Kamal::Commands::Proxy < Kamal::Commands::Base
-  delegate :argumentize, :optionize, to: Kamal::Utils
-
-  def run
-    docker :run,
-      "--name", container_name,
-      "--network", "kamal",
-      "--detach",
-      "--restart", "unless-stopped",
-      "--volume", "kamal-proxy-config:/home/kamal-proxy/.config/kamal-proxy",
-      "\$\(#{get_boot_options.join(" ")}\)",
-      config.proxy_image
-  end
-
-  def start
-    docker :container, :start, container_name
-  end
-
-  def stop(name: container_name)
-    docker :container, :stop, name
-  end
-
-  def start_or_run
-    combine start, run, by: "||"
-  end
-
-  def info
-    docker :ps, "--filter", "name=^#{container_name}$"
-  end
-
-  def version
-    pipe \
-      docker(:inspect, container_name, "--format '{{.Config.Image}}'"),
-      [ :cut, "-d:", "-f2" ]
-  end
-
-  def logs(timestamps: true, since: nil, lines: nil, grep: nil, grep_options: nil)
-    pipe \
-      docker(:logs, container_name, ("--since #{since}" if since), ("--tail #{lines}" if lines), ("--timestamps" if timestamps), "2>&1"),
-      ("grep '#{grep}'#{" #{grep_options}" if grep_options}" if grep)
-  end
-
-  def follow_logs(host:, timestamps: true, grep: nil, grep_options: nil)
-    run_over_ssh pipe(
-      docker(:logs, container_name, ("--timestamps" if timestamps), "--tail", "10", "--follow", "2>&1"),
-      (%(grep "#{grep}"#{" #{grep_options}" if grep_options}) if grep)
-    ).join(" "), host: host
-  end
-
-  def remove_container
-    docker :container, :prune, "--force", "--filter", "label=org.opencontainers.image.title=kamal-proxy"
-  end
-
-  def remove_image
-    docker :image, :prune, "--all", "--force", "--filter", "label=org.opencontainers.image.title=kamal-proxy"
-  end
-
-  def cleanup_traefik
-    chain \
-      docker(:container, :stop, "traefik"),
-      combine(
-        docker(:container, :prune, "--force", "--filter", "label=org.opencontainers.image.title=Traefik"),
-        docker(:image, :prune, "--all", "--force", "--filter", "label=org.opencontainers.image.title=Traefik")
-      )
-  end
-
-  def ensure_proxy_directory
-    make_directory config.proxy_directory
-  end
-
-  def remove_proxy_directory
-    remove_directory config.proxy_directory
-  end
-
-  def get_boot_options
-    combine [ :cat, config.proxy_options_file ], [ :echo, "\"#{config.proxy_options_default.join(" ")}\"" ], by: "||"
-  end
-
-  def reset_boot_options
-    remove_file config.proxy_options_file
-  end
-
-  private
-    def container_name
-      config.proxy_container_name
-    end
-end

lib/kamal/commands/prune.rb

@@ -9,7 +9,7 @@ class Kamal::Commands::Prune < Kamal::Commands::Base
   def tagged_images
     pipe \
       docker(:image, :ls, *service_filter, "--format", "'{{.ID}} {{.Repository}}:{{.Tag}}'"),
-      grep("-v -w \"#{active_image_list}\""),
+      "grep -v -w \"#{active_image_list}\"",
       "while read image tag; do docker rmi $tag; done"
   end
 
@@ -20,6 +20,10 @@ class Kamal::Commands::Prune < Kamal::Commands::Base
       "while read container_id; do docker rm $container_id; done"
   end
 
+  def healthcheck_containers
+    docker :container, :prune, "--force", *healthcheck_service_filter
+  end
+
   private
     def stopped_containers_filters
       [ "created", "exited", "dead" ].flat_map { |status| [ "--filter", "status=#{status}" ] }
@@ -35,4 +39,8 @@ class Kamal::Commands::Prune < Kamal::Commands::Base
     def service_filter
       [ "--filter", "label=service=#{config.service}" ]
     end
+
+    def healthcheck_service_filter
+      [ "--filter", "label=service=#{config.healthcheck_service}" ]
+    end
 end

lib/kamal/commands/registry.rb

@@ -3,12 +3,21 @@ class Kamal::Commands::Registry < Kamal::Commands::Base
 
   def login
     docker :login,
-      registry.server,
+      registry["server"],
-      "-u", sensitive(Kamal::Utils.escape_shell_value(registry.username)),
+      "-u", sensitive(Kamal::Utils.escape_shell_value(lookup("username"))),
-      "-p", sensitive(Kamal::Utils.escape_shell_value(registry.password))
+      "-p", sensitive(Kamal::Utils.escape_shell_value(lookup("password")))
   end
 
   def logout
-    docker :logout, registry.server
+    docker :logout, registry["server"]
+  end
+
+  private
+    def lookup(key)
+      if registry[key].is_a?(Array)
+        ENV.fetch(registry[key].first).dup
+      else
+        registry[key]
+      end
     end
 end

lib/kamal/commands/server.rb

@@ -1,15 +1,5 @@
 class Kamal::Commands::Server < Kamal::Commands::Base
   def ensure_run_directory
-    make_directory config.run_directory
+    [ :mkdir, "-p", config.run_directory ]
-  end
-
-  def remove_app_directory
-    remove_directory config.app_directory
-  end
-
-  def app_directory_count
-    pipe \
-      [ :ls, config.apps_directory ],
-      [ :wc, "-l" ]
   end
 end

lib/kamal/commands/traefik.rb

@@ -0,0 +1,124 @@
+class Kamal::Commands::Traefik < Kamal::Commands::Base
+  delegate :argumentize, :optionize, to: Kamal::Utils
+
+  DEFAULT_IMAGE = "traefik:v2.10"
+  CONTAINER_PORT = 80
+  DEFAULT_ARGS = {
+    "log.level" => "DEBUG"
+  }
+  DEFAULT_LABELS = {
+    # These ensure we serve a 502 rather than a 404 if no containers are available
+    "traefik.http.routers.catchall.entryPoints" => "http",
+    "traefik.http.routers.catchall.rule" => "PathPrefix(`/`)",
+    "traefik.http.routers.catchall.service" => "unavailable",
+    "traefik.http.routers.catchall.priority" => 1,
+    "traefik.http.services.unavailable.loadbalancer.server.port" => "0"
+  }
+
+  def run
+    docker :run, "--name traefik",
+      "--detach",
+      "--restart", "unless-stopped",
+      *publish_args,
+      "--volume", "/var/run/docker.sock:/var/run/docker.sock",
+      *env_args,
+      *config.logging_args,
+      *label_args,
+      *docker_options_args,
+      image,
+      "--providers.docker",
+      *cmd_option_args
+  end
+
+  def start
+    docker :container, :start, "traefik"
+  end
+
+  def stop
+    docker :container, :stop, "traefik"
+  end
+
+  def start_or_run
+    any start, run
+  end
+
+  def info
+    docker :ps, "--filter", "name=^traefik$"
+  end
+
+  def logs(since: nil, lines: nil, grep: nil)
+    pipe \
+      docker(:logs, "traefik", (" --since #{since}" if since), (" --tail #{lines}" if lines), "--timestamps", "2>&1"),
+      ("grep '#{grep}'" if grep)
+  end
+
+  def follow_logs(host:, grep: nil)
+    run_over_ssh pipe(
+      docker(:logs, "traefik", "--timestamps", "--tail", "10", "--follow", "2>&1"),
+      (%(grep "#{grep}") if grep)
+    ).join(" "), host: host
+  end
+
+  def remove_container
+    docker :container, :prune, "--force", "--filter", "label=org.opencontainers.image.title=Traefik"
+  end
+
+  def remove_image
+    docker :image, :prune, "--all", "--force", "--filter", "label=org.opencontainers.image.title=Traefik"
+  end
+
+  def port
+    "#{host_port}:#{CONTAINER_PORT}"
+  end
+
+  def env
+    Kamal::Configuration::Env.from_config \
+      config: config.traefik.fetch("env", {}),
+      secrets_file: File.join(config.host_env_directory, "traefik", "traefik.env")
+  end
+
+  def make_env_directory
+    make_directory(env.secrets_directory)
+  end
+
+  def remove_env_file
+    [ :rm, "-f", env.secrets_file ]
+  end
+
+  private
+    def publish_args
+      argumentize "--publish", port unless config.traefik["publish"] == false
+    end
+
+    def label_args
+      argumentize "--label", labels
+    end
+
+    def env_args
+      env.args
+    end
+
+    def labels
+      DEFAULT_LABELS.merge(config.traefik["labels"] || {})
+    end
+
+    def image
+      config.traefik.fetch("image") { DEFAULT_IMAGE }
+    end
+
+    def docker_options_args
+      optionize(config.traefik["options"] || {})
+    end
+
+    def cmd_option_args
+      if args = config.traefik["args"]
+        optionize DEFAULT_ARGS.merge(args), with: "="
+      else
+        optionize DEFAULT_ARGS, with: "="
+      end
+    end
+
+    def host_port
+      config.traefik["host_port"] || CONTAINER_PORT
+    end
+end

lib/kamal/configuration.rb

@@ -1,28 +1,18 @@
 require "active_support/ordered_options"
 require "active_support/core_ext/string/inquiry"
 require "active_support/core_ext/module/delegation"
-require "active_support/core_ext/hash/keys"
+require "pathname"
 require "erb"
 require "net/ssh/proxy/jump"
 
 class Kamal::Configuration
-  delegate :service, :image, :labels, :hooks_path, to: :raw_config, allow_nil: true
+  delegate :service, :image, :servers, :labels, :registry, :stop_wait_time, :hooks_path, :logging, to: :raw_config, allow_nil: true
   delegate :argumentize, :optionize, to: Kamal::Utils
 
-  attr_reader :destination, :raw_config, :secrets
+  attr_reader :destination, :raw_config
-  attr_reader :accessories, :aliases, :boot, :builder, :env, :logging, :proxy, :servers, :ssh, :sshkit, :registry
-
-  include Validation
-
-  PROXY_MINIMUM_VERSION = "v0.8.0"
-  PROXY_HTTP_PORT = 80
-  PROXY_HTTPS_PORT = 443
-  PROXY_LOG_MAX_SIZE = "10m"
 
   class << self
     def create_from(config_file:, destination: nil, version: nil)
-      ENV["KAMAL_DESTINATION"] = destination
-
       raw_config = load_config_files(config_file, *destination_config_file(config_file, destination))
 
       new raw_config, destination: destination, version: version
@@ -52,34 +42,7 @@ class Kamal::Configuration
     @raw_config = ActiveSupport::InheritableOptions.new(raw_config)
     @destination = destination
     @declared_version = version
-
+    valid? if validate
-    validate! raw_config, example: validation_yml.symbolize_keys, context: "", with: Kamal::Configuration::Validator::Configuration
-
-    @secrets = Kamal::Secrets.new(destination: destination)
-
-    # Eager load config to validate it, these are first as they have dependencies later on
-    @servers = Servers.new(config: self)
-    @registry = Registry.new(config: self)
-
-    @accessories = @raw_config.accessories&.keys&.collect { |name| Accessory.new(name, config: self) } || []
-    @aliases = @raw_config.aliases&.keys&.to_h { |name| [ name, Alias.new(name, config: self) ] } || {}
-    @boot = Boot.new(config: self)
-    @builder = Builder.new(config: self)
-    @env = Env.new(config: @raw_config.env || {}, secrets: secrets)
-
-    @logging = Logging.new(logging_config: @raw_config.logging)
-    @proxy = Proxy.new(config: self, proxy_config: @raw_config.proxy || {})
-    @ssh = Ssh.new(config: self)
-    @sshkit = Sshkit.new(config: self)
-
-    ensure_destination_if_required
-    ensure_required_keys_present
-    ensure_valid_kamal_version
-    ensure_retain_containers_valid
-    ensure_valid_service_name
-    ensure_no_traefik_reboot_hooks
-    ensure_one_host_for_ssl_roles
-    ensure_unique_hosts_for_ssl_roles
   end
 
 
@@ -108,13 +71,19 @@ class Kamal::Configuration
 
 
   def roles
-    servers.roles
+    @roles ||= role_names.collect do |role_name|
+      Role.new(role_name, config: self, specializations: role_specializations(role_name), primary: role_name == primary_role_name)
+    end
   end
 
   def role(name)
     roles.detect { |r| r.name == name.to_s }
   end
 
+  def accessories
+    @accessories ||= raw_config.accessories&.keys&.collect { |name| Kamal::Configuration::Accessory.new(name, config: self) } || []
+  end
+
   def accessory(name)
     accessories.detect { |a| a.name == name.to_s }
   end
@@ -140,20 +109,20 @@ class Kamal::Configuration
     raw_config.allow_empty_roles
   end
 
-  def proxy_roles
+  def traefik_roles
-    roles.select(&:running_proxy?)
+    roles.select(&:running_traefik?)
   end
 
-  def proxy_role_names
+  def traefik_role_names
-    proxy_roles.flat_map(&:name)
+    traefik_roles.flat_map(&:name)
   end
 
-  def proxy_hosts
+  def traefik_hosts
-    proxy_roles.flat_map(&:hosts).uniq
+    traefik_roles.flat_map(&:hosts).uniq
   end
 
   def repository
-    [ registry.server, image ].compact.join("/")
+    [ raw_config.registry["server"], image ].compact.join("/")
   end
 
   def absolute_image
@@ -190,44 +159,65 @@ class Kamal::Configuration
   end
 
   def logging_args
-    logging.args
+    if logging.present?
+      optionize({ "log-driver" => logging["driver"] }.compact) +
+        argumentize("--log-opt", logging["options"])
+    else
+      argumentize("--log-opt", { "max-size" => "10m" })
+    end
   end
 
 
+  def boot
+    Kamal::Configuration::Boot.new(config: self)
+  end
+
+  def builder
+    Kamal::Configuration::Builder.new(config: self)
+  end
+
+  def traefik
+    raw_config.traefik || {}
+  end
+
+  def ssh
+    Kamal::Configuration::Ssh.new(config: self)
+  end
+
+  def sshkit
+    Kamal::Configuration::Sshkit.new(config: self)
+  end
+
+
+  def healthcheck
+    { "path" => "/up", "port" => 3000, "max_attempts" => 7, "exposed_port" => 3999, "cord" => "/tmp/kamal-cord", "log_lines" => 50 }.merge(raw_config.healthcheck || {})
+  end
+
+  def healthcheck_service
+    [ "healthcheck", service, destination ].compact.join("-")
+  end
+
   def readiness_delay
     raw_config.readiness_delay || 7
   end
 
-  def deploy_timeout
+  def run_id
-    raw_config.deploy_timeout || 30
+    @run_id ||= SecureRandom.hex(16)
-  end
-
-  def drain_timeout
-    raw_config.drain_timeout || 30
   end
 
 
   def run_directory
-    ".kamal"
+    raw_config.run_directory || ".kamal"
   end
 
-  def apps_directory
+  def run_directory_as_docker_volume
-    File.join run_directory, "apps"
+    if Pathname.new(run_directory).absolute?
+      run_directory
+    else
+      File.join "$(pwd)", run_directory
     end
-
-  def app_directory
-    File.join apps_directory, [ service, destination ].compact.join("-")
   end
 
-  def env_directory
-    File.join app_directory, "env"
-  end
-
-  def assets_directory
-    File.join app_directory, "assets"
-  end
-
-
   def hooks_path
     raw_config.hooks_path || ".kamal/hooks"
   end
@@ -237,47 +227,19 @@ class Kamal::Configuration
   end
 
 
-  def env_tags
+  def host_env_directory
-    @env_tags ||= if (tags = raw_config.env["tags"])
+    File.join(run_directory, "env")
-      tags.collect { |name, config| Env::Tag.new(name, config: config, secrets: secrets) }
-    else
-      []
-    end
   end
 
-  def env_tag(name)
+  def env
-    env_tags.detect { |t| t.name == name.to_s }
+    raw_config.env || {}
   end
 
-  def proxy_publish_args(http_port, https_port)
-    argumentize "--publish", [ "#{http_port}:#{PROXY_HTTP_PORT}", "#{https_port}:#{PROXY_HTTPS_PORT}" ]
-  end
 
-  def proxy_logging_args(max_size)
+  def valid?
-    argumentize "--log-opt", "max-size=#{max_size}"
+    ensure_destination_if_required && ensure_required_keys_present && ensure_valid_kamal_version && ensure_retain_containers_valid && ensure_valid_service_name
   end
 
-  def proxy_options_default
-    [ *proxy_publish_args(PROXY_HTTP_PORT, PROXY_HTTPS_PORT), *proxy_logging_args(PROXY_LOG_MAX_SIZE) ]
-  end
-
-  def proxy_image
-    "basecamp/kamal-proxy:#{PROXY_MINIMUM_VERSION}"
-  end
-
-  def proxy_container_name
-    "kamal-proxy"
-  end
-
-  def proxy_directory
-    File.join run_directory, "proxy"
-  end
-
-  def proxy_options_file
-    File.join proxy_directory, "options"
-  end
-
-
   def to_h
     {
       roles: role_names,
@@ -292,10 +254,12 @@ class Kamal::Configuration
       sshkit: sshkit.to_h,
       builder: builder.to_h,
       accessories: raw_config.accessories,
-      logging: logging_args
+      logging: logging_args,
+      healthcheck: healthcheck
     }.compact
   end
 
+
   private
     # Will raise ArgumentError if any required config keys are missing
     def ensure_destination_if_required
@@ -308,21 +272,29 @@ class Kamal::Configuration
 
     def ensure_required_keys_present
       %i[ service image registry servers ].each do |key|
-        raise Kamal::ConfigurationError, "Missing required configuration for #{key}" unless raw_config[key].present?
+        raise ArgumentError, "Missing required configuration for #{key}" unless raw_config[key].present?
       end
 
-      unless role(primary_role_name).present?
+      if raw_config.registry["username"].blank?
-        raise Kamal::ConfigurationError, "The primary_role #{primary_role_name} isn't defined"
+        raise ArgumentError, "You must specify a username for the registry in config/deploy.yml"
+      end
+
+      if raw_config.registry["password"].blank?
+        raise ArgumentError, "You must specify a password for the registry in config/deploy.yml (or set the ENV variable if that's used)"
+      end
+
+      unless role_names.include?(primary_role_name)
+        raise ArgumentError, "The primary_role #{primary_role_name} isn't defined"
       end
 
       if primary_role.hosts.empty?
-        raise Kamal::ConfigurationError, "No servers specified for the #{primary_role.name} primary_role"
+        raise ArgumentError, "No servers specified for the #{primary_role.name} primary_role"
       end
 
       unless allow_empty_roles?
         roles.each do |role|
           if role.hosts.empty?
-            raise Kamal::ConfigurationError, "No servers specified for the #{role.name} role. You can ignore this with allow_empty_roles: true"
+            raise ArgumentError, "No servers specified for the #{role.name} role. You can ignore this with allow_empty_roles: true"
           end
         end
       end
@@ -331,58 +303,42 @@ class Kamal::Configuration
     end
 
     def ensure_valid_service_name
-      raise Kamal::ConfigurationError, "Service name can only include alphanumeric characters, hyphens, and underscores" unless raw_config[:service] =~ /^[a-z0-9_-]+$/i
+      raise ArgumentError, "Service name can only include alphanumeric characters, hyphens, and underscores" unless raw_config[:service] =~ /^[a-z0-9_-]+$/i
 
       true
     end
 
     def ensure_valid_kamal_version
       if minimum_version && Gem::Version.new(minimum_version) > Gem::Version.new(Kamal::VERSION)
-        raise Kamal::ConfigurationError, "Current version is #{Kamal::VERSION}, minimum required is #{minimum_version}"
+        raise ArgumentError, "Current version is #{Kamal::VERSION}, minimum required is #{minimum_version}"
       end
 
       true
     end
 
     def ensure_retain_containers_valid
-      raise Kamal::ConfigurationError, "Must retain at least 1 container" if retain_containers < 1
+      raise ArgumentError, "Must retain at least 1 container" if retain_containers < 1
 
       true
     end
 
-    def ensure_no_traefik_reboot_hooks
-      hooks = %w[ pre-traefik-reboot post-traefik-reboot ].select { |hook_file| File.exist?(File.join(hooks_path, hook_file)) }
-
-      if hooks.any?
-        raise Kamal::ConfigurationError, "Found #{hooks.join(", ")}, these should be renamed to (pre|post)-proxy-reboot"
-      end
-
-      true
-    end
-
-    def ensure_one_host_for_ssl_roles
-      roles.each(&:ensure_one_host_for_ssl)
-
-      true
-    end
-
-    def ensure_unique_hosts_for_ssl_roles
-      hosts = roles.select(&:ssl?).flat_map { |role| role.proxy.hosts }
-      duplicates = hosts.tally.filter_map { |host, count| host if count > 1 }
-
-      raise Kamal::ConfigurationError, "Different roles can't share the same host for SSL: #{duplicates.join(", ")}" if duplicates.any?
-
-      true
-    end
 
     def role_names
       raw_config.servers.is_a?(Array) ? [ "web" ] : raw_config.servers.keys.sort
     end
 
+    def role_specializations(name)
+      if servers.is_a?(Array) || servers[name].is_a?(Array)
+        {}
+      else
+        servers[name].except("hosts")
+      end
+    end
+
     def git_version
       @git_version ||=
         if Kamal::Git.used?
-          if Kamal::Git.uncommitted_changes.present? && !builder.git_clone?
+          if Kamal::Git.uncommitted_changes.present? && !builder.git_archive?
             uncommitted_suffix = "_uncommitted_#{SecureRandom.hex(8)}"
           end
           [ Kamal::Git.revision, uncommitted_suffix ].compact.join

lib/kamal/configuration/accessory.rb

@@ -1,39 +1,30 @@
 class Kamal::Configuration::Accessory
-  include Kamal::Configuration::Validation
-
   delegate :argumentize, :optionize, to: Kamal::Utils
 
-  attr_reader :name, :accessory_config, :env
+  attr_accessor :name, :specifics
 
   def initialize(name, config:)
-    @name, @config, @accessory_config = name.inquiry, config, config.raw_config["accessories"][name]
+    @name, @config, @specifics = name.inquiry, config, config.raw_config["accessories"][name]
-
-    validate! \
-      accessory_config,
-      example: validation_yml["accessories"]["mysql"],
-      context: "accessories/#{name}",
-      with: Kamal::Configuration::Validator::Accessory
-
-    @env = Kamal::Configuration::Env.new \
-      config: accessory_config.fetch("env", {}),
-      secrets: config.secrets,
-      context: "accessories/#{name}/env"
   end
 
   def service_name
-    accessory_config["service"] || "#{config.service}-#{name}"
+    specifics["service"] || "#{config.service}-#{name}"
   end
 
   def image
-    accessory_config["image"]
+    specifics["image"]
   end
 
   def hosts
+    if (specifics.keys & [ "host", "hosts", "roles" ]).size != 1
+      raise ArgumentError, "Specify one of `host`, `hosts` or `roles` for accessory `#{name}`"
+    end
+
     hosts_from_host || hosts_from_hosts || hosts_from_roles
   end
 
   def port
-    if port = accessory_config["port"]&.to_s
+    if port = specifics["port"]&.to_s
       port.include?(":") ? port : "#{port}:#{port}"
     end
   end
@@ -43,38 +34,32 @@ class Kamal::Configuration::Accessory
   end
 
   def labels
-    default_labels.merge(accessory_config["labels"] || {})
+    default_labels.merge(specifics["labels"] || {})
   end
 
   def label_args
     argumentize "--label", labels
   end
 
+  def env
+    Kamal::Configuration::Env.from_config \
+      config: specifics.fetch("env", {}),
+      secrets_file: File.join(config.host_env_directory, "accessories", "#{service_name}.env")
+  end
+
   def env_args
-    [ *env.clear_args, *argumentize("--env-file", secrets_path) ]
+    env.args
-  end
-
-  def env_directory
-    File.join(config.env_directory, "accessories")
-  end
-
-  def secrets_io
-    env.secrets_io
-  end
-
-  def secrets_path
-    File.join(config.env_directory, "accessories", "#{name}.env")
   end
 
   def files
-    accessory_config["files"]&.to_h do |local_to_remote_mapping|
+    specifics["files"]&.to_h do |local_to_remote_mapping|
       local_file, remote_file = local_to_remote_mapping.split(":")
       [ expand_local_file(local_file), expand_remote_file(remote_file) ]
     end || {}
   end
 
   def directories
-    accessory_config["directories"]&.to_h do |host_to_container_mapping|
+    specifics["directories"]&.to_h do |host_to_container_mapping|
       host_path, container_path = host_to_container_mapping.split(":")
       [ expand_host_path(host_path), container_path ]
     end || {}
@@ -89,7 +74,7 @@ class Kamal::Configuration::Accessory
   end
 
   def option_args
-    if args = accessory_config["options"]
+    if args = specifics["options"]
       optionize args
     else
       []
@@ -97,7 +82,7 @@ class Kamal::Configuration::Accessory
   end
 
   def cmd
-    accessory_config["cmd"]
+    specifics["cmd"]
   end
 
   private
@@ -131,18 +116,18 @@ class Kamal::Configuration::Accessory
     end
 
     def specific_volumes
-      accessory_config["volumes"] || []
+      specifics["volumes"] || []
     end
 
     def remote_files_as_volumes
-      accessory_config["files"]&.collect do |local_to_remote_mapping|
+      specifics["files"]&.collect do |local_to_remote_mapping|
         _, remote_file = local_to_remote_mapping.split(":")
         "#{service_data_directory + remote_file}:#{remote_file}"
       end || []
     end
 
     def remote_directories_as_volumes
-      accessory_config["directories"]&.collect do |host_to_container_mapping|
+      specifics["directories"]&.collect do |host_to_container_mapping|
         host_path, container_path = host_to_container_mapping.split(":")
         [ expand_host_path(host_path), container_path ].join(":")
       end || []
@@ -161,16 +146,30 @@ class Kamal::Configuration::Accessory
     end
 
     def hosts_from_host
-      [ accessory_config["host"] ] if accessory_config.key?("host")
+      if specifics.key?("host")
+        host = specifics["host"]
+        if host
+          [ host ]
+        else
+          raise ArgumentError, "Missing host for accessory `#{name}`"
+        end
+      end
     end
 
     def hosts_from_hosts
-      accessory_config["hosts"] if accessory_config.key?("hosts")
+      if specifics.key?("hosts")
+        hosts = specifics["hosts"]
+        if hosts.is_a?(Array)
+          hosts
+        else
+          raise ArgumentError, "Hosts should be an Array for accessory `#{name}`"
+        end
+      end
     end
 
     def hosts_from_roles
-      if accessory_config.key?("roles")
+      if specifics.key?("roles")
-        accessory_config["roles"].flat_map { |role| config.role(role).hosts }
+        specifics["roles"].flat_map { |role| config.role(role).hosts }
       end
     end
 end

lib/kamal/configuration/alias.rb

@@ -1,15 +0,0 @@
-class Kamal::Configuration::Alias
-  include Kamal::Configuration::Validation
-
-  attr_reader :name, :command
-
-  def initialize(name, config:)
-    @name, @command = name.inquiry, config.raw_config["aliases"][name]
-
-    validate! \
-      command,
-      example: validation_yml["aliases"]["uname"],
-      context: "aliases/#{name}",
-      with: Kamal::Configuration::Validator::Alias
-  end
-end

lib/kamal/configuration/boot.rb

@@ -1,25 +1,20 @@
 class Kamal::Configuration::Boot
-  include Kamal::Configuration::Validation
-
-  attr_reader :boot_config, :host_count
-
   def initialize(config:)
-    @boot_config = config.raw_config.boot || {}
+    @options = config.raw_config.boot || {}
     @host_count = config.all_hosts.count
-    validate! boot_config
   end
 
   def limit
-    limit = boot_config["limit"]
+    limit = @options["limit"]
 
     if limit.to_s.end_with?("%")
-      [ host_count * limit.to_i / 100, 1 ].max
+      [ @host_count * limit.to_i / 100, 1 ].max
     else
       limit
     end
   end
 
   def wait
-    boot_config["wait"]
+    @options["wait"]
   end
 end

lib/kamal/configuration/builder.rb

@@ -1,93 +1,67 @@
 class Kamal::Configuration::Builder
-  include Kamal::Configuration::Validation
-
-  attr_reader :config, :builder_config
-  delegate :image, :service, to: :config
-  delegate :server, to: :"config.registry"
-
   def initialize(config:)
-    @config = config
+    @options = config.raw_config.builder || {}
-    @builder_config = config.raw_config.builder || {}
     @image = config.image
-    @server = config.registry.server
+    @server = config.registry["server"]
-    @service = config.service
 
-    validate! builder_config, with: Kamal::Configuration::Validator::Builder
+    valid?
   end
 
   def to_h
-    builder_config
+    @options
   end
 
-  def remote
+  def multiarch?
-    builder_config["remote"]
+    @options["multiarch"] != false
-  end
-
-  def arches
-    Array(builder_config.fetch("arch", default_arch))
-  end
-
-  def local_arches
-    @local_arches ||= if local_disabled?
-      []
-    elsif remote
-      arches & [ Kamal::Utils.docker_arch ]
-    else
-      arches
-    end
-  end
-
-  def remote_arches
-    @remote_arches ||= if remote
-      arches - local_arches
-    else
-      []
-    end
-  end
-
-  def remote?
-    remote_arches.any?
   end
 
   def local?
-    !local_disabled? && (arches.empty? || local_arches.any?)
+    !!@options["local"]
+  end
+
+  def remote?
+    !!@options["remote"]
   end
 
   def cached?
-    !!builder_config["cache"]
+    !!@options["cache"]
   end
 
   def args
-    builder_config["args"] || {}
+    @options["args"] || {}
   end
 
   def secrets
-    (builder_config["secrets"] || []).to_h { |key| [ key, config.secrets[key] ] }
+    @options["secrets"] || []
   end
 
   def dockerfile
-    builder_config["dockerfile"] || "Dockerfile"
+    @options["dockerfile"] || "Dockerfile"
-  end
-
-  def target
-    builder_config["target"]
   end
 
   def context
-    builder_config["context"] || "."
+    @options["context"] || (git_archive? ? "-" : ".")
   end
 
-  def driver
+  def local_arch
-    builder_config.fetch("driver", "docker-container")
+    @options["local"]["arch"] if local?
   end
 
-  def local_disabled?
+  def local_host
-    builder_config["local"] == false
+    @options["local"]["host"] if local?
+  end
+
+  def remote_arch
+    @options["remote"]["arch"] if remote?
+  end
+
+  def remote_host
+    @options["remote"]["host"] if remote?
   end
 
   def cache_from
     if cached?
-      case builder_config["cache"]["type"]
+      case @options["cache"]["type"]
       when "gha"
         cache_from_config_for_gha
       when "registry"
@@ -98,7 +72,7 @@ class Kamal::Configuration::Builder
 
   def cache_to
     if cached?
-      case builder_config["cache"]["type"]
+      case @options["cache"]["type"]
       when "gha"
         cache_to_config_for_gha
       when "registry"
@@ -108,49 +82,26 @@ class Kamal::Configuration::Builder
   end
 
   def ssh
-    builder_config["ssh"]
+    @options["ssh"]
   end
 
-  def git_clone?
+  def git_archive?
-    Kamal::Git.used? && builder_config["context"].nil?
+    Kamal::Git.used? && @options["context"].nil?
-  end
-
-  def clone_directory
-    @clone_directory ||= File.join Dir.tmpdir, "kamal-clones", [ service, pwd_sha ].compact.join("-")
-  end
-
-  def build_directory
-    @build_directory ||=
-      if git_clone?
-        File.join clone_directory, repo_basename, repo_relative_pwd
-      else
-        "."
-      end
-  end
-
-  def docker_driver?
-    driver == "docker"
   end
 
   private
     def valid?
-      if docker_driver?
-        raise ArgumentError, "Invalid builder configuration: the `docker` driver does not not support remote builders" if remote
-        raise ArgumentError, "Invalid builder configuration: the `docker` driver does not not support caching" if cached?
-        raise ArgumentError, "Invalid builder configuration: the `docker` driver does not not support multiple arches" if arches.many?
-      end
-
       if @options["cache"] && @options["cache"]["type"]
         raise ArgumentError, "Invalid cache type: #{@options["cache"]["type"]}" unless [ "gha", "registry" ].include?(@options["cache"]["type"])
       end
     end
 
     def cache_image
-      builder_config["cache"]&.fetch("image", nil) || "#{image}-build-cache"
+      @options["cache"]&.fetch("image", nil) || "#{@image}-build-cache"
     end
 
     def cache_image_ref
-      [ server, cache_image ].compact.join("/")
+      [ @server, cache_image ].compact.join("/")
     end
 
     def cache_from_config_for_gha
@@ -162,26 +113,10 @@ class Kamal::Configuration::Builder
     end
 
     def cache_to_config_for_gha
-      [ "type=gha", builder_config["cache"]&.fetch("options", nil) ].compact.join(",")
+      [ "type=gha", @options["cache"]&.fetch("options", nil) ].compact.join(",")
     end
 
     def cache_to_config_for_registry
-      [ "type=registry", builder_config["cache"]&.fetch("options", nil), "ref=#{cache_image_ref}" ].compact.join(",")
+      [ "type=registry", @options["cache"]&.fetch("options", nil), "ref=#{cache_image_ref}" ].compact.join(",")
-    end
-
-    def repo_basename
-      File.basename(Kamal::Git.root)
-    end
-
-    def repo_relative_pwd
-      Dir.pwd.delete_prefix(Kamal::Git.root)
-    end
-
-    def pwd_sha
-      Digest::SHA256.hexdigest(Dir.pwd)[0..12]
-    end
-
-    def default_arch
-      docker_driver? ? [] : [ "amd64", "arm64" ]
     end
 end

lib/kamal/configuration/docs/accessory.yml

@@ -1,92 +0,0 @@
-# Accessories
-#
-# Accessories can be booted on a single host, a list of hosts, or on specific roles.
-# The hosts do not need to be defined in the Kamal servers configuration.
-#
-# Accessories are managed separately from the main service — they are not updated
-# when you deploy, and they do not have zero-downtime deployments.
-#
-# Run `kamal accessory boot <accessory>` to boot an accessory.
-# See `kamal accessory --help` for more information.
-
-# Configuring accessories
-#
-# First, define the accessory in the `accessories`:
-accessories:
-  mysql:
-
-    # Service name
-    #
-    # This is used in the service label and defaults to `<service>-<accessory>`,
-    # where `<service>` is the main service name from the root configuration:
-    service: mysql
-
-    # Image
-    #
-    # The Docker image to use, prefix it with a registry if not using Docker Hub:
-    image: mysql:8.0
-
-    # Accessory hosts
-    #
-    # Specify one of `host`, `hosts`, or `roles`:
-    host: mysql-db1
-    hosts:
-      - mysql-db1
-      - mysql-db2
-    roles:
-      - mysql
-
-    # Custom command
-    #
-    # You can set a custom command to run in the container if you do not want to use the default:
-    cmd: "bin/mysqld"
-
-    # Port mappings
-    #
-    # See https://docs.docker.com/network/, and especially note the warning about the security
-    # implications of exposing ports publicly.
-    port: "127.0.0.1:3306:3306"
-
-    # Labels
-    labels:
-      app: myapp
-
-    # Options
-    #
-    # These are passed to the Docker run command in the form `--<name> <value>`:
-    options:
-      restart: always
-      cpus: 2
-
-    # Environment variables
-    #
-    # See kamal docs env for more information:
-    env:
-      ...
-
-    # Copying files
-    #
-    # You can specify files to mount into the container.
-    # The format is `local:remote`, where `local` is the path to the file on the local machine
-    # and `remote` is the path to the file in the container.
-    #
-    # They will be uploaded from the local repo to the host and then mounted.
-    #
-    # ERB files will be evaluated before being copied.
-    files:
-      - config/my.cnf.erb:/etc/mysql/my.cnf
-      - config/myoptions.cnf:/etc/mysql/myoptions.cnf
-
-    # Directories
-    #
-    # You can specify directories to mount into the container. They will be created on the host
-    # before being mounted:
-    directories:
-      - mysql-logs:/var/log/mysql
-
-    # Volumes
-    #
-    # Any other volumes to mount, in addition to the files and directories.
-    # They are not created or copied before mounting:
-    volumes:
-      - /path/to/mysql-logs:/var/log/mysql

lib/kamal/configuration/docs/alias.yml

@@ -1,26 +0,0 @@
-# Aliases
-#
-# Aliases are shortcuts for Kamal commands.
-#
-# For example, for a Rails app, you might open a console with:
-#
-# ```shell
-# kamal app exec -i -r console "rails console"
-# ```
-#
-# By defining an alias, like this:
-aliases:
-  console: app exec -r console -i "rails console"
-# You can now open the console with:
-#
-# ```shell
-# kamal console
-# ```
-
-# Configuring aliases
-#
-# Aliases are defined in the root config under the alias key.
-#
-# Each alias is named and can only contain lowercase letters, numbers, dashes, and underscores:
-aliases:
-  uname: app exec -p -q -r web "uname -a"

lib/kamal/configuration/docs/boot.yml

@@ -1,19 +0,0 @@
-# Booting
-#
-# When deploying to large numbers of hosts, you might prefer not to restart your services on every host at the same time.
-#
-# Kamal’s default is to boot new containers on all hosts in parallel. However, you can control this with the boot configuration.
-
-# Fixed group sizes
-#
-# Here, we boot 2 hosts at a time with a 10-second gap between each group:
-boot:
-  limit: 2
-  wait: 10
-
-# Percentage of hosts
-#
-# Here, we boot 25% of the hosts at a time with a 2-second gap between each group:
-boot:
-  limit: 25%
-  wait: 2

lib/kamal/configuration/docs/builder.yml

@@ -1,104 +0,0 @@
-# Builder
-#
-# The builder configuration controls how the application is built with `docker build`.
-#
-# See https://kamal-deploy.org/docs/configuration/builder-examples/ for more information.
-
-# Builder options
-#
-# Options go under the builder key in the root configuration.
-builder:
-
-  # Arch
-  #
-  # The architectures to build for — you can set an array or just a single value.
-  #
-  # Allowed values are `amd64` and `arm64`:
-  arch:
-    - amd64
-
-  # Remote
-  #
-  # The connection string for a remote builder. If supplied, Kamal will use this
-  # for builds that do not match the local architecture of the deployment host.
-  remote: ssh://docker@docker-builder
-
-  # Local
-  #
-  # If set to false, Kamal will always use the remote builder even when building
-  # the local architecture.
-  #
-  # Defaults to true:
-  local: true
-
-  # Builder cache
-  #
-  # The type must be either 'gha' or 'registry'.
-  #
-  # The image is only used for registry cache and is not compatible with the Docker driver:
-  cache:
-    type: registry
-    options: mode=max
-    image: kamal-app-build-cache
-
-  # Build context
-  #
-  # If this is not set, then a local Git clone of the repo is used.
-  # This ensures a clean build with no uncommitted changes.
-  #
-  # To use the local checkout instead, you can set the context to `.`, or a path to another directory.
-  context: .
-
-  # Dockerfile
-  #
-  # The Dockerfile to use for building, defaults to `Dockerfile`:
-  dockerfile: Dockerfile.production
-
-  # Build target
-  #
-  # If not set, then the default target is used:
-  target: production
-
-  # Build arguments
-  #
-  # Any additional build arguments, passed to `docker build` with `--build-arg <key>=<value>`:
-  args:
-    ENVIRONMENT: production
-
-  # Referencing build arguments
-  #
-  # ```shell
-  # ARG RUBY_VERSION
-  # FROM ruby:$RUBY_VERSION-slim as base
-  # ```
-
-  # Build secrets
-  #
-  # Values are read from `.kamal/secrets`:
-  secrets:
-    - SECRET1
-    - SECRET2
-
-  # Referencing build secrets
-  #
-  # ```shell
-  # # Copy Gemfiles
-  # COPY Gemfile Gemfile.lock ./
-  #
-  # # Install dependencies, including private repositories via access token
-  # # Then remove bundle cache with exposed GITHUB_TOKEN
-  # RUN --mount=type=secret,id=GITHUB_TOKEN \
-  #   BUNDLE_GITHUB__COM=x-access-token:$(cat /run/secrets/GITHUB_TOKEN) \
-  #   bundle install && \
-  #   rm -rf /usr/local/bundle/cache
-  # ```
-
-  # SSH
-  #
-  # SSH agent socket or keys to expose to the build:
-  ssh: default=$SSH_AUTH_SOCK
-
-  # Driver
-  #
-  # The build driver to use, defaults to `docker-container`:
-  driver: docker

lib/kamal/configuration/docs/configuration.yml

@@ -1,178 +0,0 @@
-# Kamal Configuration
-#
-# Configuration is read from the `config/deploy.yml`.
-
-# Destinations
-#
-# When running commands, you can specify a destination with the `-d` flag,
-# e.g., `kamal deploy -d staging`.
-#
-# In this case, the configuration will also be read from `config/deploy.staging.yml`
-# and merged with the base configuration.
-
-# Extensions
-#
-# Kamal will not accept unrecognized keys in the configuration file.
-#
-# However, you might want to declare a configuration block using YAML anchors
-# and aliases to avoid repetition.
-#
-# You can prefix a configuration section with `x-` to indicate that it is an
-# extension. Kamal will ignore the extension and not raise an error.
-
-# The service name
-#
-# This is a required value. It is used as the container name prefix.
-service: myapp
-
-# The Docker image name
-#
-# The image will be pushed to the configured registry.
-image: my-image
-
-# Labels
-#
-# Additional labels to add to the container:
-labels:
-  my-label: my-value
-
-# Volumes
-#
-# Additional volumes to mount into the container:
-volumes:
-  - /path/on/host:/path/in/container:ro
-
-# Registry
-#
-# The Docker registry configuration, see kamal docs registry:
-registry:
-  ...
-
-# Servers
-#
-# The servers to deploy to, optionally with custom roles, see kamal docs servers:
-servers:
-  ...
-
-# Environment variables
-#
-# See kamal docs env:
-env:
-  ...
-
-# Asset path
-#
-# Used for asset bridging across deployments, default to `nil`.
-#
-# If there are changes to CSS or JS files, we may get requests
-# for the old versions on the new container, and vice versa.
-#
-# To avoid 404s, we can specify an asset path.
-# Kamal will replace that path in the container with a mapped
-# volume containing both sets of files.
-# This requires that file names change when the contents change
-# (e.g., by including a hash of the contents in the name).
-#
-# To configure this, set the path to the assets:
-asset_path: /path/to/assets
-
-# Hooks path
-#
-# Path to hooks, defaults to `.kamal/hooks`.
-# See https://kamal-deploy.org/docs/hooks for more information:
-hooks_path: /user_home/kamal/hooks
-
-# Require destinations
-#
-# Whether deployments require a destination to be specified, defaults to `false`:
-require_destination: true
-
-# Primary role
-#
-# This defaults to `web`, but if you have no web role, you can change this:
-primary_role: workers
-
-# Allowing empty roles
-#
-# Whether roles with no servers are allowed. Defaults to `false`:
-allow_empty_roles: false
-
-# Retain containers
-#
-# How many old containers and images we retain, defaults to 5:
-retain_containers: 3
-
-# Minimum version
-#
-# The minimum version of Kamal required to deploy this configuration, defaults to `nil`:
-minimum_version: 1.3.0
-
-# Readiness delay
-#
-# Seconds to wait for a container to boot after it is running, default 7.
-#
-# This only applies to containers that do not run a proxy or specify a healthcheck:
-readiness_delay: 4
-
-# Deploy timeout
-#
-# How long to wait for a container to become ready, default 30:
-deploy_timeout: 10
-
-# Drain timeout
-#
-# How long to wait for a container to drain, default 30:
-drain_timeout: 10
-
-# Run directory
-#
-# Directory to store kamal runtime files in on the host, default `.kamal`:
-run_directory: /etc/kamal
-
-# SSH options
-#
-# See kamal docs ssh:
-ssh:
-  ...
-
-# Builder options
-#
-# See kamal docs builder:
-builder:
-  ...
-
-# Accessories
-#
-# Additional services to run in Docker, see kamal docs accessory:
-accessories:
-  ...
-
-# Proxy
-#
-# Configuration for kamal-proxy, see kamal docs proxy:
-proxy:
-  ...
-
-# SSHKit
-#
-# See kamal docs sshkit:
-sshkit:
-  ...
-
-# Boot options
-#
-# See kamal docs boot:
-boot:
-  ...
-
-# Logging
-#
-# Docker logging configuration, see kamal docs logging:
-logging:
-  ...
-
-# Aliases
-#
-# Alias configuration, see kamal docs alias:
-aliases:
-  ...

lib/kamal/configuration/docs/env.yml

@@ -1,85 +0,0 @@
-# Environment variables
-#
-# Environment variables can be set directly in the Kamal configuration or
-# read from `.kamal/secrets`.
-
-# Reading environment variables from the configuration
-#
-# Environment variables can be set directly in the configuration file.
-#
-# These are passed to the `docker run` command when deploying.
-env:
-  DATABASE_HOST: mysql-db1
-  DATABASE_PORT: 3306
-
-# Secrets
-#
-# Kamal uses dotenv to automatically load environment variables set in the `.kamal/secrets` file.
-#
-# If you are using destinations, secrets will instead be read from `.kamal/secrets.<DESTINATION>` if
-# it exists.
-#
-# Common secrets across all destinations can be set in `.kamal/secrets-common`.
-#
-# This file can be used to set variables like `KAMAL_REGISTRY_PASSWORD` or database passwords.
-# You can use variable or command substitution in the secrets file.
-#
-# ```shell
-# KAMAL_REGISTRY_PASSWORD=$KAMAL_REGISTRY_PASSWORD
-# RAILS_MASTER_KEY=$(cat config/master.key)
-# ```
-#
-# You can also use [secret helpers](../../commands/secrets) for some common password managers.
-#
-# ```shell
-# SECRETS=$(kamal secrets fetch ...)
-#
-# REGISTRY_PASSWORD=$(kamal secrets extract REGISTRY_PASSWORD $SECRETS)
-# DB_PASSWORD=$(kamal secrets extract DB_PASSWORD $SECRETS)
-# ```
-#
-# If you store secrets directly in `.kamal/secrets`, ensure that it is not checked into version control.
-#
-# To pass the secrets, you should list them under the `secret` key. When you do this, the
-# other variables need to be moved under the `clear` key.
-#
-# Unlike clear values, secrets are not passed directly to the container
-# but are stored in an env file on the host:
-env:
-  clear:
-    DB_USER: app
-  secret:
-    - DB_PASSWORD
-
-# Tags
-#
-# Tags are used to add extra env variables to specific hosts.
-# See kamal docs servers for how to tag hosts.
-#
-# Tags are only allowed in the top-level env configuration (i.e., not under a role-specific env).
-#
-# The env variables can be specified with secret and clear values as explained above.
-env:
-  tags:
-    <tag1>:
-      MYSQL_USER: monitoring
-    <tag2>:
-      clear:
-        MYSQL_USER: readonly
-      secret:
-        - MYSQL_PASSWORD
-
-# Example configuration
-env:
-  clear:
-    MYSQL_USER: app
-  secret:
-    - MYSQL_PASSWORD
-  tags:
-    monitoring:
-      MYSQL_USER: monitoring
-    replica:
-      clear:
-        MYSQL_USER: readonly
-      secret:
-        - READONLY_PASSWORD

lib/kamal/configuration/docs/logging.yml

@@ -1,21 +0,0 @@
-# Custom logging configuration
-#
-# Set these to control the Docker logging driver and options.
-
-# Logging settings
-#
-# These go under the logging key in the configuration file.
-#
-# This can be specified at the root level or for a specific role.
-logging:
-
-  # Driver
-  #
-  # The logging driver to use, passed to Docker via `--log-driver`:
-  driver: json-file
-
-  # Options
-  #
-  # Any logging options to pass to the driver, passed to Docker via `--log-opt`:
-  options:
-    max-size: 100m

lib/kamal/configuration/docs/proxy.yml

@@ -1,105 +0,0 @@
-# Proxy
-#
-# Kamal uses [kamal-proxy](https://github.com/basecamp/kamal-proxy) to provide
-# gapless deployments. It runs on ports 80 and 443 and forwards requests to the
-# application container.
-#
-# The proxy is configured in the root configuration under `proxy`. These are
-# options that are set when deploying the application, not when booting the proxy.
-#
-# They are application-specific, so they are not shared when multiple applications
-# run on the same proxy.
-#
-# The proxy is enabled by default on the primary role but can be disabled by
-# setting `proxy: false`.
-#
-# It is disabled by default on all other roles but can be enabled by setting
-# `proxy: true` or providing a proxy configuration.
-proxy:
-
-  # Hosts
-  #
-  # The hosts that will be used to serve the app. The proxy will only route requests
-  # to this host to your app.
-  #
-  # If no hosts are set, then all requests will be forwarded, except for matching
-  # requests for other apps deployed on that server that do have a host set.
-  #
-  # Specify one of `host` or `hosts`.
-  host: foo.example.com
-  hosts:
-    - foo.example.com
-    - bar.example.com
-
-  # App port
-  #
-  # The port the application container is exposed on.
-  #
-  # Defaults to 80:
-  app_port: 3000
-
-  # SSL
-  #
-  # kamal-proxy can provide automatic HTTPS for your application via Let's Encrypt.
-  #
-  # This requires that we are deploying to one server and the host option is set.
-  # The host value must point to the server we are deploying to, and port 443 must be
-  # open for the Let's Encrypt challenge to succeed.
-  #
-  # Defaults to `false`:
-  ssl: true
-
-  # Response timeout
-  #
-  # How long to wait for requests to complete before timing out, defaults to 30 seconds:
-  response_timeout: 10
-
-  # Healthcheck
-  #
-  # When deploying, the proxy will by default hit `/up` once every second until we hit
-  # the deploy timeout, with a 5-second timeout for each request.
-  #
-  # Once the app is up, the proxy will stop hitting the healthcheck endpoint.
-  healthcheck:
-    interval: 3
-    path: /health
-    timeout: 3
-
-  # Buffering
-  #
-  # Whether to buffer request and response bodies in the proxy.
-  #
-  # By default, buffering is enabled with a max request body size of 1GB and no limit
-  # for response size.
-  #
-  # You can also set the memory limit for buffering, which defaults to 1MB; anything
-  # larger than that is written to disk.
-  buffering:
-    requests: true
-    responses: true
-    max_request_body: 40_000_000
-    max_response_body: 0
-    memory: 2_000_000
-
-  # Logging
-  #
-  # Configure request logging for the proxy.
-  # You can specify request and response headers to log.
-  # By default, `Cache-Control`, `Last-Modified`, and `User-Agent` request headers are logged:
-  logging:
-    request_headers:
-      - Cache-Control
-      - X-Forwarded-Proto
-    response_headers:
-      - X-Request-ID
-      - X-Request-Start
-
-  # Forward headers
-  #
-  # Whether to forward the `X-Forwarded-For` and `X-Forwarded-Proto` headers.
-  #
-  # If you are behind a trusted proxy, you can set this to `true` to forward the headers.
-  #
-  # By default, kamal-proxy will not forward the headers if the `ssl` option is set to `true`, and
-  # will forward them if it is set to `false`.
-  forward_headers: true

lib/kamal/configuration/docs/registry.yml

@@ -1,52 +0,0 @@
-# Registry
-#
-# The default registry is Docker Hub, but you can change it using `registry/server`.
-#
-# A reference to a secret (in this case, `DOCKER_REGISTRY_TOKEN`) will look up the secret
-# in the local environment:
-registry:
-  server: registry.digitalocean.com
-  username:
-    - DOCKER_REGISTRY_TOKEN
-  password:
-    - DOCKER_REGISTRY_TOKEN
-
-# Using AWS ECR as the container registry
-#
-# You will need to have the AWS CLI installed locally for this to work.
-# AWS ECR’s access token is only valid for 12 hours. In order to avoid having to manually regenerate the token every time, you can use ERB in the `deploy.yml` file to shell out to the AWS CLI command and obtain the token:
-registry:
-  server: <your aws account id>.dkr.ecr.<your aws region id>.amazonaws.com
-  username: AWS
-  password: <%= %x(aws ecr get-login-password) %>
-
-# Using GCP Artifact Registry as the container registry
-#
-# To sign into Artifact Registry, you need to
-# [create a service account](https://cloud.google.com/iam/docs/service-accounts-create#creating)
-# and [set up roles and permissions](https://cloud.google.com/artifact-registry/docs/access-control#permissions).
-# Normally, assigning the `roles/artifactregistry.writer` role should be sufficient.
-#
-# Once the service account is ready, you need to generate and download a JSON key and base64 encode it:
-#
-# ```shell
-# base64 -i /path/to/key.json | tr -d "\\n"
-# ```
-#
-# You'll then need to set the `KAMAL_REGISTRY_PASSWORD` secret to that value.
-#
-# Use the environment variable as the password along with `_json_key_base64` as the username.
-# Here’s the final configuration:
-registry:
-  server: <your registry region>-docker.pkg.dev
-  username: _json_key_base64
-  password:
-    - KAMAL_REGISTRY_PASSWORD
-
-# Validating the configuration
-#
-# You can validate the configuration by running:
-#
-# ```shell
-# kamal registry login
-# ```

lib/kamal/configuration/docs/role.yml

@@ -1,53 +0,0 @@
-# Roles
-#
-# Roles are used to configure different types of servers in the deployment.
-# The most common use for this is to run web servers and job servers.
-#
-# Kamal expects there to be a `web` role, unless you set a different `primary_role`
-# in the root configuration.
-
-# Role configuration
-#
-# Roles are specified under the servers key:
-servers:
-
-  # Simple role configuration
-  #
-  # This can be a list of hosts if you don't need custom configuration for the role.
-  #
-  # You can set tags on the hosts for custom env variables (see kamal docs env):
-  web:
-    - 172.1.0.1
-    - 172.1.0.2: experiment1
-    - 172.1.0.2: [ experiment1, experiment2 ]
-
-  # Custom role configuration
-  #
-  # When there are other options to set, the list of hosts goes under the `hosts` key.
-  #
-  # By default, only the primary role uses a proxy.
-  #
-  # For other roles, you can set it to `proxy: true` to enable it and inherit the root proxy
-  # configuration or provide a map of options to override the root configuration.
-  #
-  # For the primary role, you can set `proxy: false` to disable the proxy.
-  #
-  # You can also set a custom `cmd` to run in the container and overwrite other settings
-  # from the root configuration.
-  workers:
-    hosts:
-      - 172.1.0.3
-      - 172.1.0.4: experiment1
-    cmd: "bin/jobs"
-    options:
-      memory: 2g
-      cpus: 4
-    logging:
-      ...
-    proxy:
-      ...
-    labels:
-      my-label: workers
-    env:
-      ...
-    asset_path: /public

lib/kamal/configuration/docs/servers.yml

@@ -1,27 +0,0 @@
-# Servers
-#
-# Servers are split into different roles, with each role having its own configuration.
-#
-# For simpler deployments, though, where all servers are identical, you can just specify a list of servers.
-# They will be implicitly assigned to the `web` role.
-servers:
-  - 172.0.0.1
-  - 172.0.0.2
-  - 172.0.0.3
-
-# Tagging servers
-#
-# Servers can be tagged, with the tags used to add custom env variables (see kamal docs env).
-servers:
-  - 172.0.0.1
-  - 172.0.0.2: experiments
-  - 172.0.0.3: [ experiments, three ]
-
-# Roles
-#
-# For more complex deployments (e.g., if you are running job hosts), you can specify roles and configure each separately (see kamal docs role):
-servers:
-  web:
-    ...
-  workers:
-    ...

lib/kamal/configuration/docs/ssh.yml

@@ -1,70 +0,0 @@
-# SSH configuration
-#
-# Kamal uses SSH to connect and run commands on your hosts.
-# By default, it will attempt to connect to the root user on port 22.
-#
-# If you are using a non-root user, you may need to bootstrap your servers manually before using them with Kamal. On Ubuntu, you’d do:
-#
-# ```shell
-# sudo apt update
-# sudo apt upgrade -y
-# sudo apt install -y docker.io curl git
-# sudo usermod -a -G docker app
-# ```
-
-# SSH options
-#
-# The options are specified under the ssh key in the configuration file.
-ssh:
-
-  # The SSH user
-  #
-  # Defaults to `root`:
-  user: app
-
-  # The SSH port
-  #
-  # Defaults to 22:
-  port: "2222"
-
-  # Proxy host
-  #
-  # Specified in the form <host> or <user>@<host>:
-  proxy: root@proxy-host
-
-  # Proxy command
-  #
-  # A custom proxy command, required for older versions of SSH:
-  proxy_command: "ssh -W %h:%p user@proxy"
-
-  # Log level
-  #
-  # Defaults to `fatal`. Set this to `debug` if you are having SSH connection issues.
-  log_level: debug
-
-  # Keys only
-  #
-  # Set to `true` to use only private keys from the `keys` and `key_data` parameters,
-  # even if ssh-agent offers more identities. This option is intended for
-  # situations where ssh-agent offers many different identities or you
-  # need to overwrite all identities and force a single one.
-  keys_only: false
-
-  # Keys
-  #
-  # An array of file names of private keys to use for public key
-  # and host-based authentication:
-  keys: [ "~/.ssh/id.pem" ]
-
-  # Key data
-  #
-  # An array of strings, with each element of the array being
-  # a raw private key in PEM format.
-  key_data: [ "-----BEGIN OPENSSH PRIVATE KEY-----" ]
-
-  # Config
-  #
-  # Set to true to load the default OpenSSH config files (~/.ssh/config,
-  # /etc/ssh_config), to false ignore config files, or to a file path
-  # (or array of paths) to load specific configuration. Defaults to true.
-  config: true

lib/kamal/configuration/docs/sshkit.yml

@@ -1,23 +0,0 @@
-# SSHKit
-#
-# [SSHKit](https://github.com/capistrano/sshkit) is the SSH toolkit used by Kamal.
-#
-# The default, settings should be sufficient for most use cases, but
-# when connecting to a large number of hosts, you may need to adjust.
-
-# SSHKit options
-#
-# The options are specified under the sshkit key in the configuration file.
-sshkit:
-
-  # Max concurrent starts
-  #
-  # Creating SSH connections concurrently can be an issue when deploying to many servers.
-  # By default, Kamal will limit concurrent connection starts to 30 at a time.
-  max_concurrent_starts: 10
-
-  # Pool idle timeout
-  #
-  # Kamal sets a long idle timeout of 900 seconds on connections to try to avoid
-  # re-connection storms after an idle period, such as building an image or waiting for CI.
-  pool_idle_timeout: 300

lib/kamal/configuration/env.rb

@@ -1,29 +1,40 @@
 class Kamal::Configuration::Env
-  include Kamal::Configuration::Validation
+  attr_reader :secrets_keys, :clear, :secrets_file
-
-  attr_reader :context, :secrets
-  attr_reader :clear, :secret_keys
   delegate :argumentize, to: Kamal::Utils
 
-  def initialize(config:, secrets:, context: "env")
+  def self.from_config(config:, secrets_file: nil)
-    @clear = config.fetch("clear", config.key?("secret") || config.key?("tags") ? {} : config)
+    secrets_keys = config.fetch("secret", [])
-    @secrets = secrets
+    clear = config.fetch("clear", config.key?("secret") ? {} : config)
-    @secret_keys = config.fetch("secret", [])
+
-    @context = context
+    new clear: clear, secrets_keys: secrets_keys, secrets_file: secrets_file
-    validate! config, context: context, with: Kamal::Configuration::Validator::Env
   end
 
-  def clear_args
+  def initialize(clear:, secrets_keys:, secrets_file:)
-    argumentize("--env", clear)
+    @clear = clear
+    @secrets_keys = secrets_keys
+    @secrets_file = secrets_file
+  end
+
+  def args
+    [ "--env-file", secrets_file, *argumentize("--env", clear) ]
   end
 
   def secrets_io
-    Kamal::EnvFile.new(secret_keys.to_h { |key| [ key, secrets[key] ] }).to_io
+    StringIO.new(Kamal::EnvFile.new(secrets).to_s)
+  end
+
+  def secrets
+    @secrets ||= secrets_keys.to_h { |key| [ key, ENV.fetch(key) ] }
+  end
+
+  def secrets_directory
+    File.dirname(secrets_file)
   end
 
   def merge(other)
     self.class.new \
-      config: { "clear" => clear.merge(other.clear), "secret" => secret_keys | other.secret_keys },
+      clear: @clear.merge(other.clear),
-      secrets: secrets
+      secrets_keys: @secrets_keys | other.secrets_keys,
+      secrets_file: secrets_file
   end
 end

lib/kamal/configuration/env/tag.rb

@@ -1,13 +0,0 @@
-class Kamal::Configuration::Env::Tag
-  attr_reader :name, :config, :secrets
-
-  def initialize(name, config:, secrets:)
-    @name = name
-    @config = config
-    @secrets = secrets
-  end
-
-  def env
-    Kamal::Configuration::Env.new(config: config, secrets: secrets)
-  end
-end

lib/kamal/configuration/logging.rb

@@ -1,33 +0,0 @@
-class Kamal::Configuration::Logging
-  delegate :optionize, :argumentize, to: Kamal::Utils
-
-  include Kamal::Configuration::Validation
-
-  attr_reader :logging_config
-
-  def initialize(logging_config:, context: "logging")
-    @logging_config = logging_config || {}
-    validate! @logging_config, context: context
-  end
-
-  def driver
-    logging_config["driver"]
-  end
-
-  def options
-    logging_config.fetch("options", {})
-  end
-
-  def merge(other)
-    self.class.new logging_config: logging_config.deep_merge(other.logging_config)
-  end
-
-  def args
-    if driver.present? || options.present?
-      optionize({ "log-driver" => driver }.compact) +
-        argumentize("--log-opt", options)
-    else
-      argumentize("--log-opt", { "max-size" => "10m" })
-    end
-  end
-end

lib/kamal/configuration/proxy.rb

@@ -1,62 +0,0 @@
-class Kamal::Configuration::Proxy
-  include Kamal::Configuration::Validation
-
-  DEFAULT_LOG_REQUEST_HEADERS = [ "Cache-Control", "Last-Modified", "User-Agent" ]
-  CONTAINER_NAME = "kamal-proxy"
-
-  delegate :argumentize, :optionize, to: Kamal::Utils
-
-  attr_reader :config, :proxy_config
-
-  def initialize(config:, proxy_config:, context: "proxy")
-    @config = config
-    @proxy_config = proxy_config
-    validate! @proxy_config, with: Kamal::Configuration::Validator::Proxy, context: context
-  end
-
-  def app_port
-    proxy_config.fetch("app_port", 80)
-  end
-
-  def ssl?
-    proxy_config.fetch("ssl", false)
-  end
-
-  def hosts
-    proxy_config["hosts"] || proxy_config["host"]&.split(",") || []
-  end
-
-  def deploy_options
-    {
-      host: hosts,
-      tls: proxy_config["ssl"].presence,
-      "deploy-timeout": seconds_duration(config.deploy_timeout),
-      "drain-timeout": seconds_duration(config.drain_timeout),
-      "health-check-interval": seconds_duration(proxy_config.dig("healthcheck", "interval")),
-      "health-check-timeout": seconds_duration(proxy_config.dig("healthcheck", "timeout")),
-      "health-check-path": proxy_config.dig("healthcheck", "path"),
-      "target-timeout": seconds_duration(proxy_config["response_timeout"]),
-      "buffer-requests": proxy_config.fetch("buffering", { "requests": true }).fetch("requests", true),
-      "buffer-responses": proxy_config.fetch("buffering", { "responses": true }).fetch("responses", true),
-      "buffer-memory": proxy_config.dig("buffering", "memory"),
-      "max-request-body": proxy_config.dig("buffering", "max_request_body"),
-      "max-response-body": proxy_config.dig("buffering", "max_response_body"),
-      "forward-headers": proxy_config.dig("forward_headers"),
-      "log-request-header": proxy_config.dig("logging", "request_headers") || DEFAULT_LOG_REQUEST_HEADERS,
-      "log-response-header": proxy_config.dig("logging", "response_headers")
-    }.compact
-  end
-
-  def deploy_command_args(target:)
-    optionize ({ target: "#{target}:#{app_port}" }).merge(deploy_options), with: "="
-  end
-
-  def merge(other)
-    self.class.new config: config, proxy_config: proxy_config.deep_merge(other.proxy_config)
-  end
-
-  private
-    def seconds_duration(value)
-      value ? "#{value}s" : nil
-    end
-end

lib/kamal/configuration/registry.rb

@@ -1,32 +0,0 @@
-class Kamal::Configuration::Registry
-  include Kamal::Configuration::Validation
-
-  attr_reader :registry_config, :secrets
-
-  def initialize(config:)
-    @registry_config = config.raw_config.registry || {}
-    @secrets = config.secrets
-    validate! registry_config, with: Kamal::Configuration::Validator::Registry
-  end
-
-  def server
-    registry_config["server"]
-  end
-
-  def username
-    lookup("username")
-  end
-
-  def password
-    lookup("password")
-  end
-
-  private
-    def lookup(key)
-      if registry_config[key].is_a?(Array)
-        secrets[registry_config[key].first]
-      else
-        registry_config[key]
-      end
-    end
-end

lib/kamal/configuration/role.rb

@@ -1,30 +1,12 @@
 class Kamal::Configuration::Role
-  include Kamal::Configuration::Validation
+  CORD_FILE = "cord"
-
   delegate :argumentize, :optionize, to: Kamal::Utils
 
-  attr_reader :name, :config, :specialized_env, :specialized_logging, :specialized_proxy
+  attr_reader :name
-
   alias to_s name
 
-  def initialize(name, config:)
+  def initialize(name, config:, specializations:, primary:)
-    @name, @config = name.inquiry, config
+    @name, @config, @specializations, @primary = name.inquiry, config, specializations, primary
-    validate! \
-      specializations,
-      example: validation_yml["servers"]["workers"],
-      context: "servers/#{name}",
-      with: Kamal::Configuration::Validator::Role
-
-    @specialized_env = Kamal::Configuration::Env.new \
-      config: specializations.fetch("env", {}),
-      secrets: config.secrets,
-      context: "servers/#{name}/env"
-
-    @specialized_logging = Kamal::Configuration::Logging.new \
-      logging_config: specializations.fetch("logging", {}),
-      context: "servers/#{name}/logging"
-
-    initialize_specialized_proxy
   end
 
   def primary_host
@@ -32,11 +14,7 @@ class Kamal::Configuration::Role
   end
 
   def hosts
-    tagged_hosts.keys
+    @hosts ||= extract_hosts_from_config
-  end
-
-  def env_tags(host)
-    tagged_hosts.fetch(host).collect { |tag| config.env_tag(tag) }
   end
 
   def cmd
@@ -52,7 +30,7 @@ class Kamal::Configuration::Role
   end
 
   def labels
-    default_labels.merge(custom_labels)
+    default_labels.merge(traefik_labels).merge(custom_labels)
   end
 
   def label_args
@@ -60,51 +38,24 @@ class Kamal::Configuration::Role
   end
 
   def logging_args
-    logging.args
+    args = config.logging || {}
+    args.deep_merge!(specializations["logging"]) if specializations["logging"].present?
+
+    if args.any?
+      optionize({ "log-driver" => args["driver"] }.compact) +
+        argumentize("--log-opt", args["options"])
+    else
+      config.logging_args
+    end
   end
 
-  def logging
+
-    @logging ||= config.logging.merge(specialized_logging)
+  def env
+    @env ||= base_env.merge(specialized_env)
   end
 
-  def proxy
+  def env_args
-    @proxy ||= config.proxy.merge(specialized_proxy) if running_proxy?
+    env.args
-  end
-
-  def running_proxy?
-    @running_proxy
-  end
-
-  def ssl?
-    running_proxy? && proxy.ssl?
-  end
-
-  def stop_args
-    # When deploying with the proxy, kamal-proxy will drain request before returning so we don't need to wait.
-    timeout = running_proxy? ? nil : config.drain_timeout
-
-    [ *argumentize("-t", timeout) ]
-  end
-
-  def env(host)
-    @envs ||= {}
-    @envs[host] ||= [ config.env, specialized_env, *env_tags(host).map(&:env) ].reduce(:merge)
-  end
-
-  def env_args(host)
-    [ *env(host).clear_args, *argumentize("--env-file", secrets_path) ]
-  end
-
-  def env_directory
-    File.join(config.env_directory, "roles")
-  end
-
-  def secrets_io(host)
-    env(host).secrets_io
-  end
-
-  def secrets_path
-    File.join(config.env_directory, "roles", "#{name}.env")
   end
 
   def asset_volume_args
@@ -112,8 +63,71 @@ class Kamal::Configuration::Role
   end
 
 
+  def health_check_args(cord: true)
+    if health_check_cmd.present?
+      if cord && uses_cord?
+        optionize({ "health-cmd" => health_check_cmd_with_cord, "health-interval" => health_check_interval })
+          .concat(cord_volume.docker_args)
+      else
+        optionize({ "health-cmd" => health_check_cmd, "health-interval" => health_check_interval })
+      end
+    else
+      []
+    end
+  end
+
+  def health_check_cmd
+    health_check_options["cmd"] || http_health_check(port: health_check_options["port"], path: health_check_options["path"])
+  end
+
+  def health_check_cmd_with_cord
+    "(#{health_check_cmd}) && (stat #{cord_container_file} > /dev/null || exit 1)"
+  end
+
+  def health_check_interval
+    health_check_options["interval"] || "1s"
+  end
+
+
+  def running_traefik?
+    if specializations["traefik"].nil?
+      primary?
+    else
+      specializations["traefik"]
+    end
+  end
+
   def primary?
-    name == @config.primary_role_name
+    @primary
+  end
+
+
+  def uses_cord?
+    running_traefik? && cord_volume && health_check_cmd.present?
+  end
+
+  def cord_host_directory
+    File.join config.run_directory_as_docker_volume, "cords", [ container_prefix, config.run_id ].join("-")
+  end
+
+  def cord_volume
+    if (cord = health_check_options["cord"])
+      @cord_volume ||= Kamal::Configuration::Volume.new \
+        host_path: File.join(config.run_directory, "cords", [ container_prefix, config.run_id ].join("-")),
+        container_path: cord
+    end
+  end
+
+  def cord_host_file
+    File.join cord_volume.host_path, CORD_FILE
+  end
+
+  def cord_container_directory
+    health_check_options.fetch("cord", nil)
+  end
+
+  def cord_container_file
+    File.join cord_volume.container_path, CORD_FILE
   end
 
 
@@ -131,70 +145,38 @@ class Kamal::Configuration::Role
   end
 
   def assets?
-    asset_path.present? && running_proxy?
+    asset_path.present? && running_traefik?
   end
 
-  def asset_volume(version = config.version)
+  def asset_volume(version = nil)
     if assets?
       Kamal::Configuration::Volume.new \
-        host_path: asset_volume_directory(version), container_path: asset_path
+        host_path: asset_volume_path(version), container_path: asset_path
     end
   end
 
-  def asset_extracted_directory(version = config.version)
+  def asset_extracted_path(version = nil)
-    File.join config.assets_directory, "extracted", [ name, version ].join("-")
+    File.join config.run_directory, "assets", "extracted", container_name(version)
   end
 
-  def asset_volume_directory(version = config.version)
+  def asset_volume_path(version = nil)
-    File.join config.assets_directory, "volumes", [ name, version ].join("-")
+    File.join config.run_directory, "assets", "volumes", container_name(version)
   end
 
-  def ensure_one_host_for_ssl
+  def previous_roles
-    if running_proxy? && proxy.ssl? && hosts.size > 1
+    previous_role_names.map do |role_name|
-      raise Kamal::ConfigurationError, "SSL is only supported on a single server, found #{hosts.size} servers for role #{name}"
+      Kamal::Configuration::Role.new(role_name, config: config, specializations: specializations, primary: primary?)
     end
   end
 
   private
-    def initialize_specialized_proxy
+    attr_reader :config, :specializations
-      proxy_specializations = specializations["proxy"]
-
-      if primary?
-        # only false means no proxy for non-primary roles
-        @running_proxy = proxy_specializations != false
-      else
-        # false and nil both mean no proxy for non-primary roles
-        @running_proxy = !!proxy_specializations
-      end
-
-      if running_proxy?
-        proxy_config = proxy_specializations == true || proxy_specializations.nil? ? {} : proxy_specializations
-
-        @specialized_proxy = Kamal::Configuration::Proxy.new \
-          config: config,
-          proxy_config: proxy_config,
-          context: "servers/#{name}/proxy"
-      end
-    end
-
-    def tagged_hosts
-      {}.tap do |tagged_hosts|
-        extract_hosts_from_config.map do |host_config|
-          if host_config.is_a?(Hash)
-            host, tags = host_config.first
-            tagged_hosts[host] = Array(tags)
-          elsif host_config.is_a?(String)
-            tagged_hosts[host_config] = []
-          end
-        end
-      end
-    end
 
     def extract_hosts_from_config
-      if config.raw_config.servers.is_a?(Array)
+      if config.servers.is_a?(Array)
-        config.raw_config.servers
+        config.servers
       else
-        servers = config.raw_config.servers[name]
+        servers = config.servers[name]
         servers.is_a?(Array) ? servers : Array(servers["hosts"])
       end
     end
@@ -203,18 +185,58 @@ class Kamal::Configuration::Role
       { "service" => config.service, "role" => name, "destination" => config.destination }
     end
 
-    def specializations
+    def traefik_labels
-      if config.raw_config.servers.is_a?(Array) || config.raw_config.servers[name].is_a?(Array)
+      if running_traefik?
-        {}
+        {
+          # Setting a service property ensures that the generated service name will be consistent between versions
+          "traefik.http.services.#{traefik_service}.loadbalancer.server.scheme" => "http",
+
+          "traefik.http.routers.#{traefik_service}.rule" => "PathPrefix(`/`)",
+          "traefik.http.routers.#{traefik_service}.priority" => "2",
+          "traefik.http.middlewares.#{traefik_service}-retry.retry.attempts" => "5",
+          "traefik.http.middlewares.#{traefik_service}-retry.retry.initialinterval" => "500ms",
+          "traefik.http.routers.#{traefik_service}.middlewares" => "#{traefik_service}-retry@docker"
+        }
       else
-        config.raw_config.servers[name]
+        {}
       end
     end
 
+    def traefik_service
+      container_prefix
+    end
+
     def custom_labels
       Hash.new.tap do |labels|
         labels.merge!(config.labels) if config.labels.present?
         labels.merge!(specializations["labels"]) if specializations["labels"].present?
       end
     end
+
+    def specialized_env
+      Kamal::Configuration::Env.from_config config: specializations.fetch("env", {})
+    end
+
+    # Secrets are stored in an array, which won't merge by default, so have to do it by hand.
+    def base_env
+      Kamal::Configuration::Env.from_config \
+        config: config.env,
+        secrets_file: File.join(config.host_env_directory, "roles", "#{container_prefix}.env")
+    end
+
+    def http_health_check(port:, path:)
+      "curl -f #{URI.join("http://localhost:#{port}", path)} || exit 1" if path.present? || port.present?
+    end
+
+    def health_check_options
+      @health_check_options ||= begin
+        options = specializations["healthcheck"] || {}
+        options = config.healthcheck.merge(options) if running_traefik?
+        options
+      end
+    end
+
+    def previous_role_names
+      specializations.fetch("previously", [])
+    end
 end

lib/kamal/configuration/servers.rb

@@ -1,18 +0,0 @@
-class Kamal::Configuration::Servers
-  include Kamal::Configuration::Validation
-
-  attr_reader :config, :servers_config, :roles
-
-  def initialize(config:)
-    @config = config
-    @servers_config = config.raw_config.servers
-    validate! servers_config, with: Kamal::Configuration::Validator::Servers
-
-    @roles = role_names.map { |role_name| Kamal::Configuration::Role.new role_name, config: config }
-  end
-
-  private
-    def role_names
-      servers_config.is_a?(Array) ? [ "web" ] : servers_config.keys.sort
-    end
-end

lib/kamal/configuration/ssh.rb

@@ -1,45 +1,28 @@
 class Kamal::Configuration::Ssh
   LOGGER = ::Logger.new(STDERR)
 
-  include Kamal::Configuration::Validation
-
-  attr_reader :ssh_config
-
   def initialize(config:)
-    @ssh_config = config.raw_config.ssh || {}
+    @config = config.raw_config.ssh || {}
-    validate! ssh_config
   end
 
   def user
-    ssh_config.fetch("user", "root")
+    config.fetch("user", "root")
   end
 
   def port
-    ssh_config.fetch("port", 22)
+    config.fetch("port", 22)
   end
 
   def proxy
-    if (proxy = ssh_config["proxy"])
+    if (proxy = config["proxy"])
       Net::SSH::Proxy::Jump.new(proxy.include?("@") ? proxy : "root@#{proxy}")
-    elsif (proxy_command = ssh_config["proxy_command"])
+    elsif (proxy_command = config["proxy_command"])
       Net::SSH::Proxy::Command.new(proxy_command)
     end
   end
 
-  def keys_only
-    ssh_config["keys_only"]
-  end
-
-  def keys
-    ssh_config["keys"]
-  end
-
-  def key_data
-    ssh_config["key_data"]
-  end
-
   def options
-    { user: user, port: port, proxy: proxy, logger: logger, keepalive: true, keepalive_interval: 30, keys_only: keys_only, keys: keys, key_data: key_data }.compact
+    { user: user, port: port, proxy: proxy, logger: logger, keepalive: true, keepalive_interval: 30 }.compact
   end
 
   def to_h
@@ -47,11 +30,13 @@ class Kamal::Configuration::Ssh
   end
 
   private
+    attr_accessor :config
+
     def logger
       LOGGER.tap { |logger| logger.level = log_level }
     end
 
     def log_level
-      ssh_config.fetch("log_level", :fatal)
+      config.fetch("log_level", :fatal)
     end
 end

lib/kamal/configuration/sshkit.rb

@@ -1,22 +1,20 @@
 class Kamal::Configuration::Sshkit
-  include Kamal::Configuration::Validation
-
-  attr_reader :sshkit_config
-
   def initialize(config:)
-    @sshkit_config = config.raw_config.sshkit || {}
+    @options = config.raw_config.sshkit || {}
-    validate! sshkit_config
   end
 
   def max_concurrent_starts
-    sshkit_config.fetch("max_concurrent_starts", 30)
+    options.fetch("max_concurrent_starts", 30)
   end
 
   def pool_idle_timeout
-    sshkit_config.fetch("pool_idle_timeout", 900)
+    options.fetch("pool_idle_timeout", 900)
   end
 
   def to_h
-    sshkit_config
+    options
   end
+
+  private
+    attr_accessor :options
 end

lib/kamal/configuration/validation.rb

@@ -1,27 +0,0 @@
-require "yaml"
-require "active_support/inflector"
-
-module Kamal::Configuration::Validation
-  extend ActiveSupport::Concern
-
-  class_methods do
-    def validation_doc
-      @validation_doc ||= File.read(File.join(File.dirname(__FILE__), "docs", "#{validation_config_key}.yml"))
-    end
-
-    def validation_config_key
-      @validation_config_key ||= name.demodulize.underscore
-    end
-  end
-
-  def validate!(config, example: nil, context: nil, with: Kamal::Configuration::Validator)
-    context ||= self.class.validation_config_key
-    example ||= validation_yml[self.class.validation_config_key]
-
-    with.new(config, example: example, context: context).validate!
-  end
-
-  def validation_yml
-    @validation_yml ||= YAML.load(self.class.validation_doc)
-  end
-end

lib/kamal/configuration/validator.rb

@@ -1,171 +0,0 @@
-class Kamal::Configuration::Validator
-  attr_reader :config, :example, :context
-
-  def initialize(config, example:, context:)
-    @config = config
-    @example = example
-    @context = context
-  end
-
-  def validate!
-    validate_against_example! config, example
-  end
-
-  private
-    def validate_against_example!(validation_config, example)
-      validate_type! validation_config, example.class
-
-      if example.class == Hash
-        check_unknown_keys! validation_config, example
-
-        validation_config.each do |key, value|
-          next if extension?(key)
-          with_context(key) do
-            example_value = example[key]
-
-            if example_value == "..."
-              unless key.to_s == "proxy" && boolean?(value.class)
-                validate_type! value, *(Array if key == :servers), Hash
-              end
-            elsif key == "hosts"
-              validate_servers! value
-            elsif example_value.is_a?(Array)
-              if key == "arch"
-                validate_array_of_or_type! value, example_value.first.class
-              else
-                validate_array_of! value, example_value.first.class
-              end
-            elsif example_value.is_a?(Hash)
-              case key.to_s
-              when "options", "args"
-                validate_type! value, Hash
-              when "labels"
-                validate_hash_of! value, example_value.first[1].class
-              else
-                validate_against_example! value, example_value
-              end
-            else
-              validate_type! value, example_value.class
-            end
-          end
-        end
-      end
-    end
-
-
-    def valid_type?(value, type)
-      value.is_a?(type) ||
-        (type == String && stringish?(value)) ||
-        (boolean?(type) && boolean?(value.class))
-    end
-
-    def type_description(type)
-      if type == Integer || type == Array
-        "an #{type.name.downcase}"
-      elsif type == TrueClass || type == FalseClass
-        "a boolean"
-      else
-        "a #{type.name.downcase}"
-      end
-    end
-
-    def boolean?(type)
-      type == TrueClass || type == FalseClass
-    end
-
-    def stringish?(value)
-      value.is_a?(String) || value.is_a?(Symbol) || value.is_a?(Numeric) || value.is_a?(TrueClass) || value.is_a?(FalseClass)
-    end
-
-    def validate_array_of_or_type!(value, type)
-      if value.is_a?(Array)
-        validate_array_of! value, type
-      else
-        validate_type! value, type
-      end
-    rescue Kamal::ConfigurationError
-      type_error(Array, type)
-    end
-
-    def validate_array_of!(array, type)
-      validate_type! array, Array
-
-      array.each_with_index do |value, index|
-        with_context(index) do
-          validate_type! value, type
-        end
-      end
-    end
-
-    def validate_hash_of!(hash, type)
-      validate_type! hash, Hash
-
-      hash.each do |key, value|
-        with_context(key) do
-          validate_type! value, type
-        end
-      end
-    end
-
-    def validate_servers!(servers)
-      validate_type! servers, Array
-
-      servers.each_with_index do |server, index|
-        with_context(index) do
-          validate_type! server, String, Hash
-
-          if server.is_a?(Hash)
-            error "multiple hosts found" unless server.size == 1
-            host, tags = server.first
-
-            with_context(host) do
-              validate_type! tags, String, Array
-              validate_array_of! tags, String if tags.is_a?(Array)
-            end
-          end
-        end
-      end
-    end
-
-    def validate_type!(value, *types)
-      type_error(*types) unless types.any? { |type| valid_type?(value, type) }
-    end
-
-    def error(message)
-      raise Kamal::ConfigurationError, "#{error_context}#{message}"
-    end
-
-    def type_error(*expected_types)
-      error "should be #{expected_types.map { |type| type_description(type) }.join(" or ")}"
-    end
-
-    def unknown_keys_error(unknown_keys)
-      error "unknown #{"key".pluralize(unknown_keys.count)}: #{unknown_keys.join(", ")}"
-    end
-
-    def error_context
-      "#{context}: " if context.present?
-    end
-
-    def with_context(context)
-      old_context = @context
-      @context = [ @context, context ].select(&:present?).join("/")
-      yield
-    ensure
-      @context = old_context
-    end
-
-    def allow_extensions?
-      false
-    end
-
-    def extension?(key)
-      key.to_s.start_with?("x-")
-    end
-
-    def check_unknown_keys!(config, example)
-      unknown_keys = config.keys - example.keys
-      unknown_keys.reject! { |key| extension?(key) } if allow_extensions?
-      unknown_keys_error unknown_keys if unknown_keys.present?
-    end
-end

lib/kamal/configuration/validator/accessory.rb

@@ -1,9 +0,0 @@
-class Kamal::Configuration::Validator::Accessory < Kamal::Configuration::Validator
-  def validate!
-    super
-
-    if (config.keys & [ "host", "hosts", "roles" ]).size != 1
-      error "specify one of `host`, `hosts` or `roles`"
-    end
-  end
-end