From f9a78f4fcbaa244c27f804a34bb9f0e64305ee9d Mon Sep 17 00:00:00 2001 From: Donal McBreen Date: Fri, 17 Jan 2025 12:34:38 +0000 Subject: [PATCH] gcloud login tidy Use unless instead of if !, don't suggest running gcloud auth login, we've just tried that. --- lib/kamal/secrets/adapters/gcp_secret_manager.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/kamal/secrets/adapters/gcp_secret_manager.rb b/lib/kamal/secrets/adapters/gcp_secret_manager.rb index 9f4ed41c..8ce381ff 100644 --- a/lib/kamal/secrets/adapters/gcp_secret_manager.rb +++ b/lib/kamal/secrets/adapters/gcp_secret_manager.rb @@ -18,9 +18,9 @@ class Kamal::Secrets::Adapters::GcpSecretManager < Kamal::Secrets::Adapters::Bas # - "default|my-service-user@example.com" will use the default user, and enable service account impersonation as my-service-user # - "default|my-service-user@example.com,another-service-user@example.com" same as above, but with an impersonation delegation chain - if !logged_in? + unless logged_in? `gcloud auth login` - raise RuntimeError, "gcloud is not authenticated, please run `gcloud auth login`" if !logged_in? + raise RuntimeError, "could not login to gcloud" unless logged_in? end nil