spacebar/kamal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop treating RAILS_MASTER_KEY as special

Browse Source
This commit is contained in:
David Heinemeier Hansson
2023-02-04 15:26:59 +01:00
parent 64a5a790a7
commit cf9a402ad8
5 changed files with 5 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/commands/app_test.rb
View File

@@ -4,7 +4,7 @@ class CommandsAppTest < ActiveSupport::TestCase
setup do
ENV["RAILS_MASTER_KEY"] = "456"
@config = { service: "app", image: "dhh/app", registry: { "username" => "dhh", "password" => "secret" }, servers: [ "1.1.1.1" ] }
@config = { service: "app", image: "dhh/app", registry: { "username" => "dhh", "password" => "secret" }, servers: [ "1.1.1.1" ], env: { "secret" => [ "RAILS_MASTER_KEY" ] } }
@app = Mrsk::Commands::App.new Mrsk::Configuration.new(@config).tap { |c| c.version = "999" }
end
@@ -26,13 +26,6 @@ class CommandsAppTest < ActiveSupport::TestCase
@app.run.join(" ")
end
test "run without master key" do
ENV["RAILS_MASTER_KEY"] = nil
@app = Mrsk::Commands::App.new Mrsk::Configuration.new(@config.tap { |c| c[:skip_master_key] = true })
assert @app.run.exclude?("RAILS_MASTER_KEY=456")
end
test "start" do
assert_equal \
"docker start app-999",

9
test/configuration_test.rb
View File

@@ -143,15 +143,6 @@ class ConfigurationTest < ActiveSupport::TestCase
assert_equal "app", @config.ssh_options[:user]
end
test "master key" do
assert_equal "456", @config.master_key
end
test "skip master key" do
config = Mrsk::Configuration.new(@deploy.tap { |c| c[:skip_master_key] = true })
assert_nil @config.master_key
end
test "volume_args" do
assert_equal ["--volume", "/local/path:/container/path"], @config.volume_args
end