From cb73c730f91390bcefaad14536e9f021e5b3a807 Mon Sep 17 00:00:00 2001 From: Donal McBreen Date: Thu, 12 Sep 2024 14:31:21 +0100 Subject: [PATCH] No need for run_id --- lib/kamal/configuration.rb | 4 ---- test/commands/app_test.rb | 1 - test/configuration_test.rb | 5 ----- 3 files changed, 10 deletions(-) diff --git a/lib/kamal/configuration.rb b/lib/kamal/configuration.rb index 96784e64..76e6d9ee 100644 --- a/lib/kamal/configuration.rb +++ b/lib/kamal/configuration.rb @@ -189,10 +189,6 @@ class Kamal::Configuration raw_config.readiness_delay || 7 end - def run_id - @run_id ||= SecureRandom.hex(16) - end - def run_directory ".kamal" diff --git a/test/commands/app_test.rb b/test/commands/app_test.rb index 69931901..9c159365 100644 --- a/test/commands/app_test.rb +++ b/test/commands/app_test.rb @@ -3,7 +3,6 @@ require "test_helper" class CommandsAppTest < ActiveSupport::TestCase setup do setup_test_secrets("secrets" => "RAILS_MASTER_KEY=456") - Kamal::Configuration.any_instance.stubs(:run_id).returns("12345678901234567890123456789012") @config = { service: "app", image: "dhh/app", registry: { "username" => "dhh", "password" => "secret" }, servers: [ "1.1.1.1" ], env: { "secret" => [ "RAILS_MASTER_KEY" ] }, builder: { "arch" => "amd64" } } end diff --git a/test/configuration_test.rb b/test/configuration_test.rb index c10b8508..1df3fc3b 100644 --- a/test/configuration_test.rb +++ b/test/configuration_test.rb @@ -296,11 +296,6 @@ class ConfigurationTest < ActiveSupport::TestCase assert_equal "$(pwd)/.kamal", config.run_directory_as_docker_volume end - test "run id" do - SecureRandom.expects(:hex).with(16).returns("09876543211234567890098765432112") - assert_equal "09876543211234567890098765432112", @config.run_id - end - test "asset path" do assert_nil @config.asset_path assert_equal "foo", Kamal::Configuration.new(@deploy.merge!(asset_path: "foo")).asset_path