Improved deploy lock acquisition
1. Don't raise lock error for non-lock issues during lock acquire (see https://github.com/mrsked/mrsk/pull/181) 2. If there is an error while the lock is held, don't release the lock and send a warning to stderr
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
module Mrsk::Cli
|
||||
class LockError < StandardError; end
|
||||
end
|
||||
|
||||
# SSHKit uses instance eval, so we need a global const for ergonomics
|
||||
|
||||
@@ -6,8 +6,6 @@ module Mrsk::Cli
|
||||
class Base < Thor
|
||||
include SSHKit::DSL
|
||||
|
||||
class LockError < StandardError; end
|
||||
|
||||
def self.exit_on_failure?() true end
|
||||
|
||||
class_option :verbose, type: :boolean, aliases: "-v", desc: "Detailed logging"
|
||||
@@ -82,8 +80,11 @@ module Mrsk::Cli
|
||||
acquire_lock
|
||||
|
||||
yield
|
||||
ensure
|
||||
|
||||
release_lock
|
||||
rescue
|
||||
error " \e[31mDeploy lock was not released\e[0m" if MRSK.lock_count > 0
|
||||
raise
|
||||
end
|
||||
|
||||
def acquire_lock
|
||||
@@ -95,9 +96,10 @@ module Mrsk::Cli
|
||||
rescue SSHKit::Runner::ExecuteError => e
|
||||
if e.message =~ /cannot create directory/
|
||||
invoke "mrsk:cli:lock:status", []
|
||||
raise LockError, "Deploy lock found"
|
||||
else
|
||||
raise e
|
||||
end
|
||||
|
||||
raise LockError, "Deploy lock found"
|
||||
end
|
||||
|
||||
def release_lock
|
||||
|
||||
@@ -12,7 +12,7 @@ class Mrsk::Cli::Lock < Mrsk::Cli::Base
|
||||
message = options[:message]
|
||||
handle_missing_lock do
|
||||
on(MRSK.primary_host) { execute *MRSK.lock.acquire(message, MRSK.config.version) }
|
||||
say "Set the deploy lock"
|
||||
say "Acquired the deploy lock"
|
||||
end
|
||||
end
|
||||
|
||||
@@ -20,7 +20,7 @@ class Mrsk::Cli::Lock < Mrsk::Cli::Base
|
||||
def release
|
||||
handle_missing_lock do
|
||||
on(MRSK.primary_host) { execute *MRSK.lock.release }
|
||||
say "Removed the deploy lock"
|
||||
say "Released the deploy lock"
|
||||
end
|
||||
end
|
||||
|
||||
|
||||
Reference in New Issue
Block a user