spacebar/kamal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1152 from basecamp/skip-log-max-size

Browse Source 
Allow log max size to not be set
This commit is contained in:
Donal McBreen
2024-10-25 08:55:18 +01:00
committed by GitHub
parent 347eb69350 1980a79e73
commit b917d7cd40
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/kamal/configuration.rb
View File

@@ -254,7 +254,7 @@ class Kamal::Configuration
end end
def proxy_logging_args(max_size) def proxy_logging_args(max_size)
argumentize "--log-opt", "max-size=#{max_size}" argumentize "--log-opt", "max-size=#{max_size}" if max_size.present?
end end
def proxy_options_default def proxy_options_default

9
test/cli/proxy_test.rb
View File

@@ -263,6 +263,15 @@ class CliProxyTest < CliTestCase
end end
end end
test "boot_config set no log max size" do
run_command("boot_config", "set", "--log-max-size=").tap do |output|
%w[ 1.1.1.1 1.1.1.2 ].each do |host|
assert_match "Running /usr/bin/env mkdir -p .kamal/proxy on #{host}", output
assert_match "Uploading \"--publish 80:80 --publish 443:443\" to .kamal/proxy/options on #{host}", output
end
end
end
test "boot_config set custom ports" do test "boot_config set custom ports" do
run_command("boot_config", "set", "--http-port", "8080", "--https-port", "8443").tap do |output| run_command("boot_config", "set", "--http-port", "8080", "--https-port", "8443").tap do |output|
%w[ 1.1.1.1 1.1.1.2 ].each do |host| %w[ 1.1.1.1 1.1.1.2 ].each do |host|