From b809a971e29017006e7410d4343c75e8acd2b160 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Wed, 8 Mar 2023 17:43:23 +0100 Subject: [PATCH] One purpose per method --- lib/mrsk/commands/registry.rb | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/lib/mrsk/commands/registry.rb b/lib/mrsk/commands/registry.rb index 62ba58ce..1276da09 100644 --- a/lib/mrsk/commands/registry.rb +++ b/lib/mrsk/commands/registry.rb @@ -2,7 +2,7 @@ class Mrsk::Commands::Registry < Mrsk::Commands::Base delegate :registry, to: :config def login - docker :login, registry["server"], "-u", redact_credentials("username"), "-p", redact_credentials("password") + docker :login, registry["server"], "-u", redact(lookup("username")), "-p", redact(lookup("password")) end def logout @@ -10,13 +10,11 @@ class Mrsk::Commands::Registry < Mrsk::Commands::Base end private - def redact_credentials(key) - value = if registry[key].is_a?(Array) - ENV.fetch(registry[key].first).dup - else - registry[key] - end - - redact(value) + def lookup(key) + if registry[key].is_a?(Array) + ENV.fetch(registry[key].first).dup + else + registry[key] + end end end