Simpler API

No need for redactions, since values aren't shared.
This commit is contained in:
David Heinemeier Hansson
2023-01-20 10:07:17 +01:00
parent c16d950136
commit a8779f7055
2 changed files with 4 additions and 5 deletions

View File

@@ -1,8 +1,7 @@
require "mrsk/commands/base" require "mrsk/commands/base"
class Mrsk::Commands::Builder::Base < Mrsk::Commands::Base class Mrsk::Commands::Builder::Base < Mrsk::Commands::Base
delegate :argumentize, to: Mrsk::Configuration delegate :argumentize, :secretize, to: Mrsk::Configuration
delegate :simple_secretize, to: Mrsk::Configuration
def pull def pull
docker :pull, config.absolute_image docker :pull, config.absolute_image
@@ -13,7 +12,7 @@ class Mrsk::Commands::Builder::Base < Mrsk::Commands::Base
end end
def build_secrets def build_secrets
simple_secretize "--secret", secrets, redacted: true secretize "--secret", secrets
end end
private private

View File

@@ -22,8 +22,8 @@ class Mrsk::Configuration
attributes.flat_map { |k, v| [ argument, redacted ? Mrsk::Utils.redact("#{k}=#{v}") : "#{k}=#{v}" ] } attributes.flat_map { |k, v| [ argument, redacted ? Mrsk::Utils.redact("#{k}=#{v}") : "#{k}=#{v}" ] }
end end
def simple_secretize(secret, attributes, redacted: false) def secretize(secret, attributes)
attributes.flat_map { |k, v| [ secret, redacted ? Mrsk::Utils.redact("id=#{k}") : "id=#{k}" ] } attributes.flat_map { |k, v| [ secret, "id=#{k}" ] }
end end
private private