spacebar/kamal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change broadcast cmd to just take an argument instead of STDIN

Browse Source 
Simpler
This commit is contained in:
David Heinemeier Hansson
2023-02-18 18:22:46 +01:00
parent 0c03216fdf
commit 7f1191bf59
3 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
README.md
View File

@@ -348,7 +348,7 @@ If you need separate env variables for different destinations, you can set them
### Using audit broadcasts ### Using audit broadcasts
If you'd like to broadcast audits of deploys, rollbacks, etc to a chatroom or elsewhere, you can configure the `audit_broadcast_cmd` setting with the path to a bin file that reads the audit line from STDIN, and then does whatever with it: If you'd like to broadcast audits of deploys, rollbacks, etc to a chatroom or elsewhere, you can configure the `audit_broadcast_cmd` setting with the path to a bin file that will be passed the audit line as the first argument:
```yaml ```yaml
audit_broadcast_cmd: audit_broadcast_cmd:
@@ -359,14 +359,13 @@ The broadcast command could look something like:
```bash ```bash
#!/usr/bin/env bash #!/usr/bin/env bash
read curl -q -d content="[My App] ${1}" https://3.basecamp.com/XXXXX/integrations/XXXXX/buckets/XXXXX/chats/XXXXX/lines
curl -q -d content="[My app] ${REPLY}" https://3.basecamp.com/XXXXX/integrations/XXXXX/buckets/XXXXX/chats/XXXXX/lines
``` ```
That'll post a line like follows to a preconfigured chatbot in Basecamp: That'll post a line like follows to a preconfigured chatbot in Basecamp:
``` ```
[My App] [2023-02-18 11:29:52] [dhh] Rolled back to version d264c4e92470ad1bd18590f04466787262f605de [My App] [dhh] Rolled back to version d264c4e92470ad1bd18590f04466787262f605de
``` ```
### Using custom healthcheck path or port ### Using custom healthcheck path or port

4
lib/mrsk/commands/auditor.rb
View File

@@ -11,9 +11,7 @@ class Mrsk::Commands::Auditor < Mrsk::Commands::Base
# Runs locally # Runs locally
def broadcast(line) def broadcast(line)
if broadcast_cmd = config.audit_broadcast_cmd if broadcast_cmd = config.audit_broadcast_cmd
pipe \ [ broadcast_cmd, tagged_broadcast_line(line) ]
[ :echo, tagged_broadcast_line(line) ],
broadcast_cmd
end end
end end

2
test/commands/auditor_test.rb
View File

@@ -16,7 +16,7 @@ class CommandsAuditorTest < ActiveSupport::TestCase
test "broadcast" do test "broadcast" do
assert_match \ assert_match \
/echo '.* app removed container' \| bin\/audit_broadcast/, /bin\/audit_broadcast '\[.*\] app removed container'/,
new_command.broadcast("app removed container").join(" ") new_command.broadcast("app removed container").join(" ")
end end