From 69f90387a881332468686df2d1d1ea9afa664c42 Mon Sep 17 00:00:00 2001 From: Tim Tilberg Date: Mon, 15 Apr 2024 09:09:58 -0500 Subject: [PATCH] Allow capital letters to match valid service name, such as in MyApp --- lib/kamal/configuration.rb | 2 +- test/configuration_test.rb | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/kamal/configuration.rb b/lib/kamal/configuration.rb index df95f170..0a9c3576 100644 --- a/lib/kamal/configuration.rb +++ b/lib/kamal/configuration.rb @@ -301,7 +301,7 @@ class Kamal::Configuration end def ensure_valid_service_name - raise ArgumentError, "Service name can only include alphanumeric characters, hyphens, and underscores" unless raw_config[:service] =~ /^[a-z0-9_-]+$/ + raise ArgumentError, "Service name can only include alphanumeric characters, hyphens, and underscores" unless raw_config[:service] =~ /^[a-z0-9_-]+$/i true end diff --git a/test/configuration_test.rb b/test/configuration_test.rb index 6f89d669..36a9f305 100644 --- a/test/configuration_test.rb +++ b/test/configuration_test.rb @@ -44,6 +44,7 @@ class ConfigurationTest < ActiveSupport::TestCase test "service name valid" do assert Kamal::Configuration.new(@deploy.tap { _1[:service] = "hey-app1_primary" }).valid? + assert Kamal::Configuration.new(@deploy.tap { _1[:service] = "MyApp" }).valid? end test "service name invalid" do