From 3b16e047c59c94faed4fef73239778aedd1da15b Mon Sep 17 00:00:00 2001 From: Nick Hammond Date: Mon, 4 Mar 2024 10:03:22 -0700 Subject: [PATCH] Add hyphen to the allowed character list for service name --- lib/kamal/configuration.rb | 2 +- test/configuration_test.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/kamal/configuration.rb b/lib/kamal/configuration.rb index 2311f69c..3fb87124 100644 --- a/lib/kamal/configuration.rb +++ b/lib/kamal/configuration.rb @@ -284,7 +284,7 @@ class Kamal::Configuration end def ensure_valid_service_name - raise ArgumentError, "Service name can only include alphanumeric characters and hyphens" unless raw_config[:service] =~ /^[a-z0-9-]+$/ + raise ArgumentError, "Service name can only include alphanumeric characters, hyphens, and underscores" unless raw_config[:service] =~ /^[a-z0-9-_]+$/ true end diff --git a/test/configuration_test.rb b/test/configuration_test.rb index b005d2c8..37b5b4a0 100644 --- a/test/configuration_test.rb +++ b/test/configuration_test.rb @@ -43,7 +43,7 @@ class ConfigurationTest < ActiveSupport::TestCase end test "service name valid" do - assert Kamal::Configuration.new(@deploy.tap { _1[:service] = "hey-app1" }).valid? + assert Kamal::Configuration.new(@deploy.tap { _1[:service] = "hey-app1_primary" }).valid? end test "service name invalid" do