Escape the docker registry username and password

Fixes: https://github.com/basecamp/kamal/issues/278
2024-03-06 11:02:46 +00:00
parent 6563393d9a
commit 2be397b679
2 changed files with 18 additions and 4 deletions
--- a/lib/kamal/commands/registry.rb
+++ b/lib/kamal/commands/registry.rb
@@ -2,7 +2,10 @@ class Kamal::Commands::Registry < Kamal::Commands::Base
  delegate :registry, to: :config

  def login
-    docker :login, registry["server"], "-u", sensitive(lookup("username")), "-p", sensitive(lookup("password"))
+    docker :login,
+      registry["server"],
+      "-u", sensitive(Kamal::Utils.escape_shell_value(lookup("username"))),
+      "-p", sensitive(Kamal::Utils.escape_shell_value(lookup("password")))
  end

  def logout