Merge pull request #988 from igor-alexandrov/kamal-proxy-remove-no-target

Fixed kamal-proxy remove command
This commit is contained in:
Donal McBreen
2024-09-30 04:18:12 -04:00
committed by GitHub
6 changed files with 13 additions and 11 deletions

View File

@@ -121,8 +121,8 @@ class CommandsAppTest < ActiveSupport::TestCase
test "remove" do
assert_equal \
"docker exec kamal-proxy kamal-proxy remove app-web --target \"172.1.0.2:80\"",
new_command.remove(target: "172.1.0.2").join(" ")
"docker exec kamal-proxy kamal-proxy remove app-web",
new_command.remove.join(" ")
end

View File

@@ -8,7 +8,7 @@ class AppTest < IntegrationTest
kamal :app, :stop
assert_app_is_down
assert_app_not_found
kamal :app, :start
@@ -48,7 +48,7 @@ class AppTest < IntegrationTest
kamal :app, :remove
assert_app_is_down
assert_app_not_found
assert_app_directory_removed
end
end

View File

@@ -50,6 +50,12 @@ class IntegrationTest < ActiveSupport::TestCase
assert_equal "502", response.code
end
def assert_app_not_found
response = app_response
debug_response_code(response, "404")
assert_equal "404", response.code
end
def assert_app_is_up(version: nil, app: @app)
response = app_response(app: app)
debug_response_code(response, "200")